Skip to content

Trials P-1 and P-7: an App's pull request, approved by the machine user #14

Closed

Description

@don-petry

Part of the epic "Epic: slice 0, foundations. The repo holds the line, its context is tested, and the platform facts are recorded".

Why. Slice 1 is one event: the machine user's approval of a Factory pull request stands. These are that event's mechanics, tried before anything is built on them.

Done when

  • P-1: a pull request authored by an App needs one approval and no more under the ruleset's rule for unattributed changes.
  • P-7: the machine user's approval satisfies code-owner review and the last-push rule when an App pushed last.
  • The case slice 1 will actually meet: the Maintainer pushed last, and the machine user approves as code owner.

Needs. The story "Canary set-up", and so trial P-3's verdict. Blocked until the Maintainer has provided the collaborator, the token and the trial-only App.

Design. §6, P-1 and P-7; §6.1, batch 1; §5.1; §9.1, the critical path, item 2.

Activity

  1. changed the title [-]Trials P-1, P-7 and P-24: the approval mechanics[/-] [+]Trials P-1 and P-7: an App's pull request, approved by the machine user[/+] on Oct 11, 2026
  2. don-petry commented on Oct 19, 2026

    @don-petry
    ContributorAuthor

    Trial sitting planned for 2026-10-19 or 2026-10-20 (Maintainer, 2026-10-19). P-1 and P-7 here, then P-24 and the P-28 App case on #27, follow the runbook in one sitting. That leaves three days before DONPETRY_BOT's window ends (2026-10-24 at the latest) to re-run if P-1 or P-7 answers "no". Two observations come free in the same sitting: P-38 (whether the dismissed approval stays on its commit, and who the timeline says dismissed it) and the grounding rule an_approval_survives_a_push. #95's code-scanning threshold is set in the same sitting.

  3. don-petry commented on Oct 19, 2026

    @don-petry
    ContributorAuthor

    The sitting (plan review, 2026-10-19; the Maintainer chose this in chat, 2026-10-19)

    The machine user's token was set 2026-10-17 23:56Z for at most seven days, so the window ends by 2026-10-24. This story and #27 run in one sitting by the runbook runbook-p1-p7-p24.md (steps M1 to M10). The sitting is asked for by 2026-10-20, so that a "no" on P-1 or P-7, which would open a design issue on slice 1's approval mechanics, can be run again inside the window.

    Three additions to the runbook, none costing a click:

    1. P-38, observed. After M5 (the App pushes last), the READ already expects the Maintainer-approved review DISMISSED. From that same read, record whether the review is still readable with the commit it approved and its reviewer, and who the timeline names as dismissing it. That is P-38's question (design §6; decision 0025). If both hold, a_contract_approval_stays_on_its_commit is grounded by P-7.json and P-38 needs no run of its own in batch 2.
    2. The fake's rule an_approval_survives_a_push. The runbook already predicts it is wrong under this ruleset. The fixtures' PR corrects the rule's text in sim/grounding.py (an approval is dismissed as stale on a push under "dismiss stale approvals"), and sim/world.py if the world relies on it, rather than leaving it unverified.
    3. Code scanning fails on a security alert of any severity #95 in the same sitting. The Maintainer changes the repo's code-scanning failure threshold to any severity while he is at the settings; a session reads it back for The Factory repo's rulesets hold the Release tags and each required check's App #62's fixture.

    The runbook's step 8 (revoke the token, delete the secret, record on #27) closes the window; batch 2's trials that need the machine user (P-2, P-5, P-25) get a second token when their story runs.

  4. don-petry commented on Oct 19, 2026

    @don-petry
    ContributorAuthor

    P-1 and P-7 passed in the sitting of 2026-10-19 (canary PRs 29 and 34, both squash-merged with no bypass; records held outside the repo until the fixtures PR).

    • P-1: the trial-author App's pull request, with the machine user's one approval, gave APPROVED and CLEAN and merged.
    • P-7, Maintainer pushed last: the Maintainer's pull request, with the machine user's approval the only one (an App's stray approval from CodeRabbit was dismissed by hand first), gave APPROVED and CLEAN.
    • P-7, App pushed last: after the App's push, the machine user's approval of the new head gave APPROVED and CLEAN under code-owner review and last-push approval, and the merge succeeded.

    Two observations for the simulator and for P-38:

    1. an_approval_survives_a_push is wrong under the live ruleset: the App's push DISMISSED the earlier approval and the pull request fell back to REVIEW_REQUIRED and BLOCKED until re-approved. The fixtures PR leaves that rule unverified and says so.
    2. A review dismissed by a push keeps its commit_id (the commit it approved) with state DISMISSED; the timeline's review_dismissed event names the pusher as its actor, dismissal_commit_id the new head, and no message. A hand dismissal names the dismisser, carries the message and no commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions