Skip to content

feat: implement issue #85 — Compliance: unpinned-actions-dependabot-automerge.yml - #198

Merged
don-petry merged 8 commits into
mainfrom
dev-lead/issue-85-20260521-1927
May 24, 2026
Merged

don-petry merged 8 commits into
mainfrom
dev-lead/issue-85-20260521-1927

Conversation

@don-petry

@don-petry don-petry commented May 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #85

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration for internal automation processes.

Review Change Stack

@don-petry
don-petry requested a review from a team as a code owner May 21, 2026 19:27
Copilot AI review requested due to automatic review settings May 21, 2026 19:27
@coderabbitai

coderabbitai Bot commented May 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63267dba-ebed-4932-8611-5525bfea3f1a

📥 Commits

Reviewing files that changed from the base of the PR and between b181744 and ca3be9c.

📒 Files selected for processing (1)
  • .github/workflows/dependabot-automerge.yml

📝 Walkthrough

Walkthrough

The dependabot-automerge workflow reusable action reference is pinned from a semantic version tag (@v2) to a specific commit SHA (@376a4fcb...), aligning the workflow with action-pinning compliance standards.

Changes

Workflow Pinning

Layer / File(s) Summary
Reusable workflow SHA pinning
.github/workflows/dependabot-automerge.yml
The reusable workflow reference for dependabot-automerge-reusable.yml is pinned to commit SHA 376a4fcb1117444595e3e702fa450873d0e54310 instead of the @v2 tag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pinning the unpinned dependabot-automerge.yml action to a SHA, which directly addresses issue #85.
Linked Issues check ✅ Passed The PR successfully pins the reusable workflow action to a commit SHA, fully satisfying the compliance requirement from issue #85 to pin actions according to the action-pinning policy.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of pinning the unpinned action in dependabot-automerge.yml; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-85-20260521-1927

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file by adding a redundant entry for .dev-lead/. The review feedback correctly identifies that this entry is already present multiple times and notes a discrepancy between the pull request title and the actual files included in the diff.

Comment thread .gitignore Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Dependabot automerge workflow to comply with “unpinned actions” requirements by pinning the referenced reusable workflow to an immutable commit SHA (Issue #85).

Changes:

  • Pinned the reusable workflow reference from a tag (@v2) to a specific commit SHA.
  • Added an inline comment to retain the human-readable version reference (# v2).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry

Copy link
Copy Markdown
Contributor Author

@donpetry-bot please review — compliance fix awaiting auto-review (manually triggered after pr-auto-review.yml is not deployed to this fleet repo)

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

@don-petry
don-petry requested a review from donpetry-bot May 23, 2026 23:46
@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry assigned me as reviewer — starting a fresh review now. Results will appear in a few minutes.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 7159a1958c696eea67af586270128b61ac05241a
Review mode: triage-approved (single reviewer)

Summary

Single-line workflow change that pins the petry-projects/.github/.github/workflows/dependabot-automerge-reusable.yml reusable workflow from the mutable @v2 tag to the immutable commit SHA 376a4fcb1117444595e3e702fa450873d0e54310, retaining # v2 as a human-readable comment. This is the canonical remediation pattern for the org's action-pinning policy and exactly addresses the linked compliance finding.

Linked issue analysis

Closes #85 — Compliance: unpinned-actions-dependabot-automerge.yml. The issue flags uses: petry-projects/.github/.github/workflows/dependabot-automerge-reusable.yml@v1 (the body text references @v1, but the workflow currently references @v2; the underlying compliance check is about pinning to a SHA either way). The diff replaces the unpinned tag reference with a commit SHA + version comment, which is the remediation prescribed by standards/ci-standards.md#action-pinning-policy.

I verified the pinned SHA against the upstream tag:

  • gh api repos/petry-projects/.github/git/refs/tags/v2 returns object.sha = 376a4fcb1117444595e3e702fa450873d0e54310 — matches the diff exactly.

Findings

  • No blocking issues.
  • Pin is to a commit SHA, not a tag/branch — meets policy.
  • Inline # v2 comment preserves human-readable version provenance.
  • secrets: inherit and permissions: block are unchanged; no privilege expansion.
  • Diff is 1 addition / 1 deletion, scoped strictly to .github/workflows/dependabot-automerge.yml.
  • Earlier gemini-code-assist comment about a .gitignore change was against the initial commit b7fcb85b and no longer reflects the head; the current head only touches the workflow file.
  • copilot-pull-request-reviewer overview comment is informational, no blockers.
  • CodeRabbit's earlier rate-limit notice is superseded by a subsequent CodeRabbit SUCCESS status check.

CI status

  • CodeQL Analyze (actions) — SUCCESS
  • CodeQL (rollup) — SUCCESS
  • CodeRabbit — SUCCESS
  • SonarQube Cloud quality gate — passed (0 new issues, 0 hotspots)
  • pr-review-mention / handle-mention — SUCCESS
  • mergeable: MERGEABLE; mergeStateStatus: BLOCKED only on required approval.

No unresolved review threads and no unanswered human-reviewer questions. Triage assessment confirmed.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry don-petry closed this May 23, 2026
@don-petry don-petry reopened this May 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 45dbc8d into main May 24, 2026
19 of 20 checks passed
@don-petry
don-petry deleted the dev-lead/issue-85-20260521-1927 branch May 24, 2026 00:12
don-petry added a commit that referenced this pull request Jun 19, 2026
…utomerge.yml (#198)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: unpinned-actions-dependabot-automerge.yml

3 participants