Repository navigation
docs(codeowners): add explicit catch-all comment (closes #156) - #162
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@petry-projects/org-leads — this is a docs-only change to the CODEOWNERS comment. No functional change to ownership rules. Ready for review and merge once CI passes. |
There was a problem hiding this comment.
Pull request overview
Clarifies the repository’s CODEOWNERS “catch-all” intent so audits/reviewers can quickly confirm that all files are covered by a default owner rule and that code owner review requirements won’t be bypassed due to unmatched paths.
Changes:
- Replaces the existing header with a more explicit reference to the org standard and the “org-leads first” rule.
- Adds an explicit explanatory comment describing the
*catch-all’s purpose.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Auto-rebase failed — merge conflict — this branch has conflicts with Please resolve the conflicts and push: |
Outdated review (superseded by re-review at
|
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: df81cd26aca53dbd797bc1db76e9c3447aea2b18
Review mode: triage-approved (single reviewer)
Summary
Confirms the triage assessment. The diff is a single line in .github/workflows/pr-review-mention.yml:
- uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@v1
+ uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@0cb4bba11d7563bf197ad805f12fb8639e4879e4 # v1It pins the internal reusable workflow from the mutable @v1 tag to commit SHA 0cb4bba11d…, keeping the tag as a trailing comment for readability. No logic, permissions, secret handling, or trigger surface changes — permissions: pull-requests: write and secrets: inherit are untouched.
Linked issue analysis
Closes #139 (Compliance: unpinned-actions-pr-review-mention.yml), an action-pinning finding (severity: error) auto-filed by the weekly compliance audit. The issue body calls out exactly this uses: line as not pinned to SHA, references standards/ci-standards.md#action-pinning-policy, and asks for remediation. The PR is the minimal, on-point fix.
Findings
- Correctness of the pin. The new ref is a full 40-char hex SHA, in the canonical
owner/repo/path@SHAshape that GitHub Actions accepts for reusable workflows, with the human-readable# v1tag preserved as a comment — exactly the documented pattern for pin-to-SHA + tag hint. - Scope is appropriately narrow. One file, one line. No surrounding refactor, no other workflow refs touched, no caller signature change. Sibling action refs in the file already use SHA pins, so this brings the file fully into compliance.
- No security regression. Pinning an internal reusable workflow to an immutable SHA strengthens supply-chain posture vs. the prior mutable tag; it cannot regress it. The reusable workflow inherits secrets, so SHA-pinning is in fact the higher-value place to enforce this.
- Note on competing approach. A separate (different) PR in this repo proposes excluding internal refs from the pinning check rather than pinning them. The two approaches conflict, but from this PR's perspective the current org standard is "pin to SHA" and #139 was filed under that standard, so this fix is correct against today's policy. If the exclusion lands later, this pin remains valid and is simply no longer audit-required.
- Bot review noise (informational). A prior automated review on this same SHA was posted as APPROVED but its body describes a different PR (
scripts/compliance-audit.sh, issue #239). It does not change the assessment of this PR — flagging only so a human knows the duplicate APPROVED entry was not a content match.
CI status
All required checks green on df81cd2: CI / Validate, AgentShield, CodeQL (Analyze (actions)), SonarCloud (Quality Gate passed, 0 new issues / 0 hotspots), Claude Code, CodeRabbit, dependency-audit ecosystem detector. Skipped jobs (dependabot-automerge, language-specific audits, claude-ci-fix, claude-issue) are conditional and not applicable here. mergeStateStatus is BLOCKED only on the missing approving review — no failing check.
Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
The weekly compliance audit (2026-05-08) flagged codeowners-no-catchall, but the `*` catch-all was already present in main — the audit received 404 responses for all CODEOWNERS paths during that run (same root cause as issue #155). This PR makes the intent of the `*` catch-all pattern explicit through a descriptive comment, so future audits can verify at a glance that all files have an owner and require_code_owner_review applies to all paths. Closes #156 Co-authored-by: Don Petry <don-petry@users.noreply.github.com>
5fc7b22 to
46532e6
Compare
|
The weekly compliance audit (2026-05-08) flagged codeowners-no-catchall, but the `*` catch-all was already present in main — the audit received 404 responses for all CODEOWNERS paths during that run (same root cause as issue #155). This PR makes the intent of the `*` catch-all pattern explicit through a descriptive comment, so future audits can verify at a glance that all files have an owner and require_code_owner_review applies to all paths. Closes #156 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Don Petry <don-petry@users.noreply.github.com>



Summary
The weekly compliance audit (2026-05-08) raised issue #156 (
codeowners-no-catchall), but the*catch-all was already present inmain— the audit received 404 responses for all three CODEOWNERS lookup paths during that run (the same root cause as issue #155, which is addressed by PR #160).This PR makes the intent of the catch-all explicit through a descriptive comment, so future audits can confirm at a glance that:
*patternrequire_code_owner_reviewapplies to all pathsNo functional change — the
* @petry-projects/org-leadsrule was already in place.Closes #156
Test plan
.github/CODEOWNERScontains*as first pattern — ✅ already presentcodeowners-no-catchallcheck passes on next runGenerated with Claude Code