Skip to content

Compliance: unpinned-actions-shell-tests.yml #447

Closed

Description

@don-petry

Compliance Finding

Category: action-pinning
Severity: error
Check: unpinned-actions-shell-tests.yml

Detail

Workflow shell-tests.yml has 1 action(s) not pinned to SHA: - uses: actions/checkout@v7

Standard Reference

standards/ci-standards.md#action-pinning-policy

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-08-31)

    This finding is still open.

    Detail: Workflow shell-tests.yml has 1 action(s) not pinned to SHA: - uses: actions/checkout@v7

    Standard: standards/ci-standards.md#action-pinning-policy

  2. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Aug 31, 2026
  3. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #447 — Compliance: unpinned-actions-shell-tests.yml

    Scope

    Pin actions/checkout in .github/workflows/shell-tests.yml to the full commit SHA (v7.0.1) to satisfy the action-pinning standard, matching the repo-wide pin already used in ci.yml, sonarcloud.yml, apply-repo-settings.yml, and copilot-setup-steps.yml.

    Implementation Checklist

    • .github/workflows/shell-tests.yml — change uses: actions/checkout@v7 → uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 (SHA verified via GitHub API)

    Tests to Write

    • .github/scripts/tests/shell-tests-workflow.bats — static YAML regression guard asserting the checkout action is pinned to a 40-char commit SHA (not a moving @vN tag), following the existing workflow-bats pattern

    Test Command

    bats .github/scripts/tests/*.bats

  4. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet; the automation posts the authoritative
    completion record (with PR number + head SHA) after the push. Treat the notes
    below as intent, not delivered results.

    Plan Execution (intended)

    • Pinned actions/checkout@v7 → actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 in .github/workflows/shell-tests.yml. SHA verified via GitHub API (repos/actions/checkout/git/ref/tags/v7.0.1) and matches the pin already used in ci.yml, sonarcloud.yml, apply-repo-settings.yml, and copilot-setup-steps.yml.
    • Added .github/scripts/tests/shell-tests-workflow.bats — static-YAML regression guard (TDD: written failing first) asserting every uses: ref, and the checkout step specifically, stays pinned to a 40-char commit SHA.

    Local check output (provisional — not the pushed run)

    # new test (red before fix → green after)
    ok 1..4  shell-tests-workflow.bats
    
    # dev-lead-lint.sh: all checks passed
    

    Files touched (this workspace, not yet pushed)

    • .github/workflows/shell-tests.yml: pin checkout action to SHA
    • .github/scripts/tests/shell-tests-workflow.bats: new regression guard

    Notes

    • Pre-existing, unrelated failure in the full bats suite: apply-code-quality-ruleset.bats test 11 ("update adds the dependabot bypass...") fails on a clean tree with my workflow edit reverted. It concerns apply-code-quality-ruleset.sh, which Compliance: unpinned-actions-shell-tests.yml #447 does not touch — left out of scope. All other suites (46 tests) pass.
  5. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete — PR #455

    The implementation for issue #447 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  6. added a commit that references this issue on Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions