You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dev-lead.yml caller stub must pass with: agent_ref: dev-lead/<channel> (stable, next, or ring<N>) so the reusable checks out its own scripts/prompts from the same channel. Re-sync from standards/workflows/dev-lead.yml.
Repin the dev-lead.yml caller stub from the non-standard dev-lead/v1-stable channel to the canonical dev-lead/stable channel on both the uses: ref and the agent_ref input, resolving the dev-lead-stub-agent-ref (and companion dev-lead-stub-pin) compliance findings.
Root Cause
compliance-audit.sh:check_dev_lead_stub only accepts channels matching dev-lead/(stable|next|ring<N>). The committed stub pins @dev-lead/v1-stable with agent_ref: dev-lead/v1-stable; v1-stable is outside that set, so the uses: channel extracts as empty and the agent_ref fallback check fires dev-lead-stub-agent-ref. The canonical standards/workflows/dev-lead.yml uses dev-lead/stable.
Implementation Checklist
.github/workflows/dev-lead.yml line 64: uses: …/dev-lead-reusable.yml@dev-lead/v1-stable → @dev-lead/stable (keep the inline # NOSONAR(githubactions:S7637) marker)
.github/workflows/dev-lead.yml line 66: agent_ref: dev-lead/v1-stable → agent_ref: dev-lead/stable
Leave on:, permissions:, concurrency: untouched (centrally owned, not repo-adjustable)
Tests to Write
This is a workflow-configuration change with no application-code behavior. The markets app test suite (Jest) does not cover CI YAML. Per the Phase 2 exception (configuration change, no observable app behavior), no app-level test is added. Instead the fix is verified by:
Re-running the exact check_dev_lead_stub regexes from compliance-audit.sh locally against the edited file (expect: no pin/agent_ref finding)
Verified via local replay of the audit regexes, dev-lead-lint.sh, and template diff
Root Cause
check_dev_lead_stub only accepts a channel matching dev-lead/(stable|next|ring<N>). The stub pinned @dev-lead/v1-stable, so the uses: channel extraction returned empty and the agent_ref fallback branch fired dev-lead-stub-agent-ref (and the pin regex fired dev-lead-stub-pin). v1-stable is not a valid channel — the canonical template pins the moving dev-lead/stable tag.
Test Results
Configuration change (workflow YAML); no application-code behavior, so the Phase 2 app-test step is covered by replaying the exact audit regexes plus repo lint.
.github/workflows/dev-lead.yml: repinned the reusable uses: ref and the agent_ref input from the non-standard dev-lead/v1-stable channel to the canonical dev-lead/stable channel.
Notes
Scope kept minimal per the issue: only the channel pin was changed. The # NOSONAR(githubactions:S7635) marker on secrets: inherit (introduced by ci: inline NOSONAR(S7635) markers on secrets:inherit caller stubs #321) was deliberately preserved — it is out of scope for this finding, is not examined by check_dev_lead_stub or the surface-drift guard, and removing it would risk re-tripping the SonarCloud githubactions:S7635 gate.
The pre-existing comment lines that already referenced dev-lead/stable are now consistent with the actual pin.
Out of scope (separate reusables/checks, not touched): add-to-project.yml has a @add-to-project/stable vs agent_ref: add-to-project/v1-stable mismatch, and agent-shield.yml/dependency-audit.yml pin v2-stable. If those warrant compliance review, they should be tracked as their own findings.
Re-sync .github/workflows/dev-lead.yml verbatim from standards/workflows/dev-lead.yml so the caller stub passes a valid with: agent_ref: dev-lead/<channel> and carries no drift.
Root Cause
The current stub is pinned to a non-standard channel token dev-lead/v1-stable on both the reusable uses: ref and the agent_ref input. The valid channels per the dev-lead-stub-agent-ref check are stable, next, or ring<N>. The stub also carries an extra # NOSONAR(githubactions:S7635) marker on the secrets: inherit line that is not present in the canonical template (drift).
Implementation Checklist
Replace .github/workflows/dev-lead.yml with the verbatim canonical template from standards/workflows/dev-lead.yml (agent_ref + uses ref → dev-lead/stable; remove extra secrets NOSONAR marker)
Confirm no other tracked workflow references the old v1-stable token
Tests to Write
Pure CI-workflow configuration change with no observable runtime behavior — no unit test is applicable. The change is verified by the repo lint (.dev-lead/scripts/dev-lead-lint.sh) and a byte-for-byte diff against the canonical template. (Phase 2 test-first exception noted per instructions.)
Replaced .github/workflows/dev-lead.yml verbatim with the canonical template from standards/workflows/dev-lead.yml
Verified no other in-scope tracked file references the old dev-lead/v1-stable token (the only other v1-stable hit is add-to-project.yml, a different workflow — out of scope)
Root Cause & Fix
The stub was pinned to the non-standard channel token dev-lead/v1-stable, which is not one of the valid channels (stable, next, ring<N>) required by the dev-lead-stub-agent-ref check. Re-syncing from the canonical template:
Removed drift marker # NOSONAR(githubactions:S7635) from the secrets: inherit line (not present in the canonical template)
The resulting file is now byte-for-byte identical to standards/workflows/dev-lead.yml.
Test Results
This is a pure CI-workflow configuration change with no observable runtime behavior, so no unit test applies (Phase 2 test-first exception per instructions). Verification performed:
.github/workflows/dev-lead.yml: pinned reusable uses: ref and agent_ref input to the valid dev-lead/stable channel and removed a non-canonical NOSONAR marker on the secrets: inherit line (3 lines changed).
Notes
add-to-project.yml also uses a …/v1-stable token but for the separate add-to-project agent; it is unrelated to this issue and was intentionally left untouched.
Activity
don-petry commentedon Jul 17, 2026
Dev-Lead Implementation Plan
Issue: #328 — Compliance: dev-lead-stub-agent-ref
Scope
Repin the
dev-lead.ymlcaller stub from the non-standarddev-lead/v1-stablechannel to the canonicaldev-lead/stablechannel on both theuses:ref and theagent_refinput, resolving thedev-lead-stub-agent-ref(and companiondev-lead-stub-pin) compliance findings.Root Cause
compliance-audit.sh:check_dev_lead_stubonly accepts channels matchingdev-lead/(stable|next|ring<N>). The committed stub pins@dev-lead/v1-stablewithagent_ref: dev-lead/v1-stable;v1-stableis outside that set, so theuses:channel extracts as empty and the agent_ref fallback check firesdev-lead-stub-agent-ref. The canonicalstandards/workflows/dev-lead.ymlusesdev-lead/stable.Implementation Checklist
.github/workflows/dev-lead.ymlline 64:uses: …/dev-lead-reusable.yml@dev-lead/v1-stable→@dev-lead/stable(keep the inline# NOSONAR(githubactions:S7637)marker).github/workflows/dev-lead.ymlline 66:agent_ref: dev-lead/v1-stable→agent_ref: dev-lead/stablesecrets: inherit # NOSONAR(githubactions:S7635)untouched (added by ci: inline NOSONAR(S7635) markers on secrets:inherit caller stubs #321; out of scope; removing it risks a SonarCloud regression)on:,permissions:,concurrency:untouched (centrally owned, not repo-adjustable)Tests to Write
This is a workflow-configuration change with no application-code behavior. The markets app test suite (Jest) does not cover CI YAML. Per the Phase 2 exception (configuration change, no observable app behavior), no app-level test is added. Instead the fix is verified by:
check_dev_lead_stubregexes fromcompliance-audit.shlocally against the edited file (expect: no pin/agent_ref finding).dev-lead/scripts/dev-lead-lint.sh(shellcheck + agent frontmatter)Test Command
bash .dev-lead/scripts/dev-lead-lint.sh+ local compliance-audit regex replaydon-petry commentedon Jul 17, 2026
Dev-Lead: Implementation Complete
Plan Execution
standards/scripts/compliance-audit.sh:check_dev_lead_stuband the canonicalstandards/workflows/dev-lead.yml.github/workflows/dev-lead.ymluses:ref@dev-lead/v1-stable→@dev-lead/stablewith: agent_ref: dev-lead/v1-stable→dev-lead/stablesecrets: inherit # NOSONAR(S7635)(added by ci: inline NOSONAR(S7635) markers on secrets:inherit caller stubs #321) and theon:/permissions:/concurrency:surfaces untoucheddev-lead-lint.sh, and template diffRoot Cause
check_dev_lead_stubonly accepts a channel matchingdev-lead/(stable|next|ring<N>). The stub pinned@dev-lead/v1-stable, so theuses:channel extraction returned empty and the agent_ref fallback branch fireddev-lead-stub-agent-ref(and the pin regex fireddev-lead-stub-pin).v1-stableis not a valid channel — the canonical template pins the movingdev-lead/stabletag.Test Results
Configuration change (workflow YAML); no application-code behavior, so the Phase 2 app-test step is covered by replaying the exact audit regexes plus repo lint.
Files Changed
.github/workflows/dev-lead.yml: repinned the reusableuses:ref and theagent_refinput from the non-standarddev-lead/v1-stablechannel to the canonicaldev-lead/stablechannel.Notes
# NOSONAR(githubactions:S7635)marker onsecrets: inherit(introduced by ci: inline NOSONAR(S7635) markers on secrets:inherit caller stubs #321) was deliberately preserved — it is out of scope for this finding, is not examined bycheck_dev_lead_stubor the surface-drift guard, and removing it would risk re-tripping the SonarCloudgithubactions:S7635gate.dev-lead/stableare now consistent with the actual pin.add-to-project.ymlhas a@add-to-project/stablevsagent_ref: add-to-project/v1-stablemismatch, andagent-shield.yml/dependency-audit.ymlpinv2-stable. If those warrant compliance review, they should be tracked as their own findings.don-petry commentedon Jul 21, 2026
Dev-Lead Implementation Plan
Issue: #328 — Compliance: dev-lead-stub-agent-ref
Scope
Re-sync
.github/workflows/dev-lead.ymlverbatim fromstandards/workflows/dev-lead.ymlso the caller stub passes a validwith: agent_ref: dev-lead/<channel>and carries no drift.Root Cause
The current stub is pinned to a non-standard channel token
dev-lead/v1-stableon both the reusableuses:ref and theagent_refinput. The valid channels per thedev-lead-stub-agent-refcheck arestable,next, orring<N>. The stub also carries an extra# NOSONAR(githubactions:S7635)marker on thesecrets: inheritline that is not present in the canonical template (drift).Implementation Checklist
.github/workflows/dev-lead.ymlwith the verbatim canonical template fromstandards/workflows/dev-lead.yml(agent_ref + uses ref →dev-lead/stable; remove extra secrets NOSONAR marker)v1-stabletokenTests to Write
.dev-lead/scripts/dev-lead-lint.sh) and a byte-for-byte diff against the canonical template. (Phase 2 test-first exception noted per instructions.)Test Command
bash .dev-lead/scripts/dev-lead-lint.shdon-petry commentedon Jul 21, 2026
Dev-Lead: Implementation Complete
Plan Execution
.github/workflows/dev-lead.ymlverbatim with the canonical template fromstandards/workflows/dev-lead.ymldev-lead/v1-stabletoken (the only otherv1-stablehit isadd-to-project.yml, a different workflow — out of scope)Root Cause & Fix
The stub was pinned to the non-standard channel token
dev-lead/v1-stable, which is not one of the valid channels (stable,next,ring<N>) required by thedev-lead-stub-agent-refcheck. Re-syncing from the canonical template:uses: …dev-lead-reusable.yml@dev-lead/v1-stable→@dev-lead/stablewith: agent_ref: dev-lead/v1-stable→dev-lead/stable# NOSONAR(githubactions:S7635)from thesecrets: inheritline (not present in the canonical template)The resulting file is now byte-for-byte identical to
standards/workflows/dev-lead.yml.Test Results
This is a pure CI-workflow configuration change with no observable runtime behavior, so no unit test applies (Phase 2 test-first exception per instructions). Verification performed:
Files Changed
.github/workflows/dev-lead.yml: pinned reusableuses:ref andagent_refinput to the validdev-lead/stablechannel and removed a non-canonical NOSONAR marker on thesecrets: inheritline (3 lines changed).Notes
add-to-project.ymlalso uses a…/v1-stabletoken but for the separateadd-to-projectagent; it is unrelated to this issue and was intentionally left untouched.feat: implement issue #328 — Compliance: dev-lead-stub-agent-ref (#356)
feat: implement issue #328 — Compliance: dev-lead-stub-agent-ref (#356)
feat: implement issue #400 — Compliance: ruleset-bypass-dependabot-co…