Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #173 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive refactoring of the demand-radar codebase, modularizing several scripts by extracting monolithic logic into smaller, focused helper functions. These changes improve readability and maintainability across data processing, dashboard exporting, and review analysis scripts. Feedback suggests replacing Object.hasOwn in the dashboard template with a simpler logical OR fallback to prevent potential compatibility issues in older browsers or WebViews.
This comment has been minimized.
This comment has been minimized.
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-13T23:03:00Z. |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. Requested items addressed:
|
CodeAnt Nitpicks2 code suggestions1. When Reddit's token request fails, this call propagates the raw exception;
|
This comment has been minimized.
This comment has been minimized.
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-13T23:05:40Z. |
|
The PR's Quality Gate has passed with all measures showing acceptable status: 0 Security Hotspots, 99.7% Coverage on New Code, and 0.0% Duplication. The refactoring in this PR explicitly addresses SonarCloud cognitive complexity issues (commit 75f3625), and the Object.hasOwn compatibility fix is included in the latest commit (4823c93) per the feedback about older browser/WebView compatibility. The 6 new issues reported appear to be lower-priority code quality metrics that do not block the Quality Gate. |
|
Fixed both CodeAnt nitpick items:
Commit: 4dec706 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-13T23:12:40Z. |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. Requested items addressed:
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-20T19:56:35Z. |
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-reviews (no-changes)Agent reasoning |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No description provided. |
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-reviews (no-changes)Agent reasoning |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-20T21:35:44Z. |
|
No description provided. |
|
CodeRabbit's recent review generated no actionable comments. The SonarCloud Code Analysis CI check has completed successfully on this PR, confirming the analysis was performed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No description provided. |
|
Closing as superseded. Issue #168 was closed as completed on 2026-10-20, and SonarCloud reports 0 open python:S3776 (cognitive complexity) findings on main, so this 690+/430- refactor of the DemandRadar spike no longer fixes anything. Its recent commits are only auto-merges of main. Reopen if a new S3776 finding appears. |
|



Problem
SonarCloud: cognitive complexity (S3776)
From the issue: 14 open SonarCloud finding(s) in
petry-projects/incubator, worst severity CRITICAL. Generated by the org SonarCloud Audit.Risk
Low — 8 file(s) changed; no CI- or runtime-critical paths touched.
Test plan
No test files were added or updated. Verification:
bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
This PR's CI checks (Lint + bats) are the success/regression signal.
Closes #168