Repository navigation
Conversation
…ipts — .github/workflows/ci.yml
This comment has been minimized.
This comment has been minimized.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This comment has been minimized.
This comment has been minimized.
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #680 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check |
QA Lead — test-risk advisoryRisk tier: LOW. This change only touches CI. It swaps the license-gated gitleaks action for the gitleaks command-line tool, pinned and checksum-verified. The "Secret scan (gitleaks)" check is already green on this PR, and reverting is trivial. What I'd shore up (highest leverage first):
Escalate? no Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-11-09T18:00:36Z. |
|
No description provided. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
No description provided. |
|
Codex review failed to complete. No specific findings are listed in this comment—this appears to be an operational notice rather than actionable code issues. The bot can be retried with |
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-11-10T07:03:22Z. |
|
CodeRabbit's rate-limit notice is an operational status update indicating review throttling due to Fair Usage Limits, not an actionable code finding. The prior CodeRabbit review findings regarding gitleaks redaction verification have been addressed in the test file (lines 76–79 and 91–94 verify full redaction and the absence of weakening flags), and all CI checks pass. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
This comment has been minimized.
This comment has been minimized.
|
No description provided. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Acknowledged: the current body of this CodeRabbit comment is only an 'Action performed / Review finished' notice from a review command. It has no findings, no actionable, outside-diff or nitpick items, and no architecture section, so no action is needed. |
|
No description provided. |
The first test 'runs gitleaks detect over full history and fails on findings' was checking both full-history/exit-code behavior AND detailed redaction verification. The detailed redaction checks are now the exclusive responsibility of the dedicated second test 'runs gitleaks with full redaction that cannot be weakened', reducing duplication and making each test's purpose clearer. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
|
No description provided. |
|
No description provided. |
|
Updated PR title from 'feat: implement issue #679 — [Fleet Monitor] combsmith/google-app-scripts — .github/workflows/ci.yml' to 'ci: replace gitleaks action with pinned, verified CLI in secret-scan' to address the CodeRabbit pre-merge check finding. The title now clearly states the main change without tracker labels or file paths, as recommended. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Re-read the current body of this CodeAnt review-status comment (edited after my earlier disposition). It only lists completed incremental reviews, the latest on aa405d9. It contains no findings and needs no action. |
|
Re-read the current body of this CodeAnt PR Risk comment (edited after my earlier disposition). It rates the PR Low Risk at aa405d9 and raises no findings, so no action is needed. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: MEDIUM
Reviewed commit: aa405d95fd28e00a2679b76b4bb4a6996a5abef9
Review mode: triage-approved (single reviewer)
Summary
The secret-scan job in .github/workflows/ci.yml now uses the gitleaks CLI (v8.30.1) instead of gitleaks/gitleaks-action. The CLI is downloaded from the official GitHub release, checked with sha256sum -c against a pinned checksum, and then installed. The job no longer reads GITLEAKS_LICENSE or GITHUB_TOKEN, so it can run on Dependabot-triggered PRs, which get no Actions secrets. security-events: write is removed because nothing uploads SARIF. The job keeps contents: read. The scan command is unchanged: detect --source . --redact --verbose --exit-code 1, with fetch-depth: 0. The new file scripts/tests/ci-workflow.test.js checks the job's structure: job name, no action or license secret, pinned version and checksum, full history, exit code, full redaction and permissions.
I raised the risk from triage's LOW to MEDIUM. The change only touches CI and is easy to revert, but it changes how a required security gate works. That gate now runs a downloaded binary instead of a pinned action. None of the HIGH triggers apply. The PR removes a secret dependency and handles no secrets. The safety checks report no CI weakening and no secret in a run: step. No third-party reusable workflow is added.
Linked issue analysis
#679 is a Fleet Monitor warning: ci.yml failed 1 of 6 runs (16.7%). The issue has no acceptance criteria and is already CLOSED, so Closes #679 does nothing. The PR says the failure came from gitleaks-action needing a license secret on Dependabot runs. That is a plausible cause, and the fix addresses it directly. Unconfirmed: the issue does not link the failed run, and I had no access to the run logs, so I could not check that this was the failure. The QA-lead advisory raised the same point. Someone should confirm the fix on the next Dependabot PR. The p95 duration in the issue (555s) almost certainly comes from another job and won't change with this PR.
Findings
No blocking findings.
Verified from the diff and checks:
- The install fails safely. GitHub's default
bash -eshell stops the step ifwget,sha256sum -c,tarormvfails, so an unverified binary never runs.tarextracts only thegitleaksbinary. - The checksum matches the real release. The
Secret scan (gitleaks)check passed on this head SHA, andsha256sum -cruns inside it. That success implies the pinned checksum matched the downloaded archive. I could not compare it against upstream's publishedchecksums.txtmyself. - Least privilege improves. Write permission is removed and no secrets are used.
- The test helper is robust.
extractJobaccepts quoted job keys and inline comments, and ignores column-0 comments, which resolves the Gemini robustness feedback. The redaction test requires exactly one bare--redactor--redact=100, which resolves the Cubic P2 and CodeRabbit nitpick. TheGITLEAKS_LICENSEandsecrets.assertions apply only to the job's own lines, so the header comment that mentionsGITLEAKS_LICENSEdoes not trip them. - The new test runs in CI. CodeRabbit's unverified note was that
ci.ymlnever runsnpm test. The separateNode.js Testsworkflow runs the Jest suite and passed on this SHA.
Non-blocking notes:
- Wider scan scope. On
pull_requestevents, gitleaks-action scanned only the PR's commit range. The CLI scans the whole repository history on every run. That is stricter and passes today, but a secret already in history will now fail every PR until it is allowlisted or removed. - Deprecated subcommand.
gitleaks detectis deprecated in recent 8.x releases in favour ofgitleaks git. It still works in 8.30.1. Consider switching when the version is next bumped. - The tests only check the YAML text. They confirm the job is configured correctly but not that the scan catches anything. As the QA lead suggested, a later improvement could run the same command against a temporary repo with a planted fake secret.
- The PR body is slightly wrong. It says "the bats suite runs in CI", but the new test is a Jest test.
- Org standard not checked. The job comment points to the org-canonical job in
combsmith/.githubstandards/workflows/ci.yml. That file is not in this review's context, so I could not confirm the job matches it.
Not checked (no access): the MCP run_secret_scanning tool was not available, so no GitHub secret scan ran on the diff. The diff adds only a public release checksum and a version string, no credentials. I could not read review-thread resolution state from the pre-fed data. Cubic's latest review says all its reported issues were addressed, and no reviewer has requested changes.
CI status
All quality checks passed on aa405d9:
- CI:
Secret scan (gitleaks),build-and-testandautofix - Tests and coverage:
Node.js Tests,coverageandPlaywright UI Tests - CodeQL: actions, javascript-typescript and python
- SonarCloud: quality gate passed, with 0 new issues and 0 hotspots
- Dependency audit: gate passed
- Agent and review checks:
AgentShield,cubicandpr-auto-review
dev-lead / dispatch, dev-lead / ci-relay and dev-lead / resume were CANCELLED. These are agent-orchestration jobs that a newer run superseded, not quality gates. The skipped checks (Dependabot auto-merge, the non-npm ecosystem audits, CodeRabbit) are skipped because they don't apply to this PR. The merge state is BLOCKED only because the org-leads approval is still required.
Reviewed automatically by the PR-review agent (single-reviewer mode: opus 5.5 [opus 4.8, opus 4.7]). Reply if you need a human review.
|
pr-review approved on PARTIAL advisory evidence: 4/5 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
No description provided. |
|
|
No description provided. |
Dev-Lead — rate-limited (intent: fix-reviews)PR: #680 |



User description
Problem
[Fleet Monitor] combsmith/google-app-scripts — .github/workflows/ci.yml
From the issue: | Metric | Value | |---|---| | Failure Rate | 16.7% (1 / 6 runs) | | Status | WARNING | | p50 Duration | 254s | | p95 Duration | 555s | | Successful Runs | 5 | | Cancelled Runs | 0 |
Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
scripts/tests/ci-workflow.test.js. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.
Closes #679
Summary by CodeRabbit
CodeAnt-AI Description
Allow secret scans to run on Dependabot pull requests
What Changed
Impact
✅ Dependabot pull requests can run the required secret scan✅ Secret scanning no longer requires a Gitleaks license secret✅ Secret findings remain fully redacted💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.