Skip to content

fix: pin dependency-audit reusable workflow to SHA - #219

Closed
don-petry wants to merge 42 commits into
mainfrom
claude/issue-158-20260419-2333
Closed

don-petry wants to merge 42 commits into
mainfrom
claude/issue-158-20260419-2333

Conversation

@don-petry

@don-petry don-petry commented Apr 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Pins the reusable workflow reference from @v1 to commit SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d to satisfy the Action Pinning Policy.

Before:

uses: petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1

After:

uses: petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1

The SHA was resolved from the v1 tag via gh api repos/petry-projects/.github/git/refs/tags/v1.

Closes #158

Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Pinned a reusable workflow dependency to a specific commit to improve build reproducibility and stability.
    • Updated workflow guidance comments to reflect the pinning policy and provide clearer editing instructions.

Review Change Stack

Pins the reusable workflow reference from @v1 to commit SHA to satisfy
the Action Pinning Policy (ci-standards.md#action-pinning-policy).

SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d corresponds to the v1 tag
of petry-projects/.github as of 2026-04-19.

Closes #158

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 19, 2026 23:34
@don-petry

Copy link
Copy Markdown
Collaborator Author

This PR is ready for review and merge. @don-petry — you are the code owner, could you please review and merge this to close the compliance finding in issue #158? This is a single-line change pinning the reusable workflow SHA.

@coderabbitai

coderabbitai Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0feabf0d-817e-47a8-88c9-c751cd5f2d30

📥 Commits

Reviewing files that changed from the base of the PR and between 392499c and d0193e9.

📒 Files selected for processing (1)
  • .github/workflows/dependency-audit.yml

📝 Walkthrough

Walkthrough

Updated .github/workflows/dependency-audit.yml to pin the reusable workflow reference from @v1 to a specific commit SHA and refreshed the inline “AGENTS — READ BEFORE EDITING” guidance to require SHA pinning.

Changes

GitHub Actions Workflow Configuration

Layer / File(s) Summary
Pin reusable workflow & guidance
.github/workflows/dependency-audit.yml
Updated guidance comment to require pinning and replaced uses: .../dependency-audit-reusable.yml@v1 with .../dependency-audit-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d (kept # v1 annotation).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pinning the dependency-audit reusable workflow reference from a tag to a specific commit SHA.
Linked Issues check ✅ Passed The PR directly addresses issue #158 by pinning the unpinned reusable workflow reference to a commit SHA, fully complying with the Action Pinning Policy requirement.
Out of Scope Changes check ✅ Passed All changes are scoped to the specific compliance requirement: updating the workflow reference to use a pinned SHA instead of the v1 tag, with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-158-20260419-2333

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the dependency-audit reusable workflow reference to a specific commit SHA to satisfy the organization’s GitHub Actions pinning policy (closes #158).

Changes:

  • Replace @v1 with a commit SHA for petry-projects/.github/.github/workflows/dependency-audit-reusable.yml.
  • Add an inline # v1 note to preserve the semantic version context.

jobs:
dependency-audit:
uses: petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1
uses: petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1

Copilot AI Apr 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comment says you "MUST NOT change ... the uses: line", but this PR necessarily changes it to comply with the action pinning policy. Consider updating that guidance to reflect the intended maintenance process (e.g., uses should be pinned to a commit SHA, and only the SHA may be updated when the reusable workflow/tag advances) so future edits aren’t blocked by contradictory instructions.

Copilot uses AI. Check for mistakes.
@github-actions
github-actions Bot requested a review from a team as a code owner May 4, 2026 20:39
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@donpetry-bot

Copy link
Copy Markdown
Contributor

Review — fix requested (cycle 2/3)

The automated review identified the following issues. Please address each one:

Findings to fix

Automated review — NEEDS HUMAN REVIEW

Risk: LOW
Reviewed commit: b8295f9d9852426ba653de13bede2631a694aa96
Review mode: triage-approved (single reviewer)

Summary

The substantive change is identical to what the prior bot review approved at e7854a2: a single-line pin of petry-projects/.github/.github/workflows/dependency-audit-reusable.yml from the mutable @v1 tag to commit SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1, plus a refreshed in-file header that aligns editing guidance with the action-pinning policy. The change itself remains low-risk and confirms the triage assessment — but the branch has since fallen out of mergeability and the PR cannot land in its current state.

Linked issue analysis

Closes #158 — Compliance: unpinned-actions-dependency-audit.yml, citing ci-standards.md#action-pinning-policy. The diff is exactly the remediation called for by the standard (tag → full SHA with # v1 annotation), so the issue is substantively addressed by the change. Resolution is blocked only on the merge problem below.

Findings

  • major — Branch is CONFLICTING with main (mergeable: CONFLICTING, mergeStateStatus: DIRTY). The github-actions auto-rebase failed on 2026-05-21 and the conflict still stands. Author must resolve manually:
    git fetch origin
    git merge origin/main
    # resolve conflicts, then:
    git add .
    git commit
    git push
    
  • minor — Unanswered human-reviewer ask: @dev-lead - please fix this PR (2026-05-20) has not been actioned. The earlier @claude request to address Copilot/CodeRabbit comments errored out, though the underlying Copilot comment about the contradictory header was already resolved in commit 7a1ce58 and CodeRabbit had no actionable items.
  • info — PR-level diff is still +5/-4 on one file (.github/workflows/dependency-audit.yml); no scope creep despite 51 commits accumulating on the branch via repeated auto-rebases from main.
  • info — The new head comment now correctly states that uses: MUST be SHA-pinned and that trigger events / job name remain immutable (preserving the required status check). No logic changes.

CI status

All required checks green at this SHA: Analyze (actions), Analyze (javascript-typescript), Analyze (python), CodeQL, CodeRabbit. SonarCloud Quality Gate passed (0 new issues, 0 security hotspots). The only merge blocker is the conflict with main, not CI.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

Additional tasks

  1. Resolve all unresolved review thread comments from other reviewers
  2. Ensure all CI checks pass after your changes
  3. Rebase on the target branch if behind
  4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

@donpetry-bot
donpetry-bot dismissed their stale review June 2, 2026 03:37

Superseded by automated re-review at b8295f9.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:16

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: unpinned-actions-dependency-audit.yml

3 participants