You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix javascript:S4790 in src/gas-utils.js by replacing MD5 with SHA-256 in getFileHash. The hash is only used to compare attachment content within a single run (both sides recomputed each time, nothing persisted), so dedup behavior stays the same.
The implementation for issue #638 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.
Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
Activity
don-petry commentedon Oct 20, 2026
Dev-Lead Implementation Plan
Issue: #638 — SonarCloud: JavaScript/TypeScript code quality
Scope
Fix javascript:S4790 in
src/gas-utils.jsby replacing MD5 with SHA-256 ingetFileHash. The hash is only used to compare attachment content within a single run (both sides recomputed each time, nothing persisted), so dedup behavior stays the same.Implementation Checklist
src/gas-utils.js:crypto.createHash('md5')→'sha256', update JSDocsrc/gmail-to-drive-by-labels/code.gs:Utilities.DigestAlgorithm.MD5→SHA_256for parity with the tested Node implementationsrc/index.js,code.gs, README,docs/component-inventory.md)Tests to Write
tests/gas-utils.test.jsgetFileHashexpectations to the SHA-256 digests (64 hex chars) — red before implementationTest Command
npm testandnpm run checkdon-petry commentedon Oct 20, 2026
Dev-Lead: Implementation Complete — PR #639
The implementation for issue #638 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.
dfce684a59a1d28d42366da23e939428a2abe673main: 8 file(s), +27/-21 linesReview happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
feat: implement issue #638 — SonarCloud: JavaScript/TypeScript code q…