Skip to content

Add persona-mention.yml to .prettierignore before the stub sync #618

Closed

Description

@don-petry

Problem

The org-standard persona-mention.yml caller stub is about to be synced into this repo (combsmith/.github#781), and this repo's formatter will rewrite it.

.prettierignore already lists every other standards-owned stub here — dev-lead.yml, initiative-driver.yml, feature-ideation.yml, pr-auto-review.yml, agent-shield.yml — each with a comment explaining that the stub is copied verbatim from petry-projects/.github/standards/workflows/ and that Prettier would reintroduce drift (it collapses the two-space gap before the # NOSONAR marker and reflows comments). .github/workflows/persona-mention.yml is not listed.

Without the entry, two things go wrong:

  • On a same-repo PR, the autofix job in ci.yml runs npm run format and pushes the result, so the sync PR stops being the template. This already happened to the stub in PR 614 (comments reflowed, marker spacing changed).
  • If the stub merged unformatted, Check formatting and lint (push to main) runs npm run check (prettier --check .) and main goes red.

Sync PR 617 carried the verbatim stub and was closed for this reason before autofix ran.

Change

Add .github/workflows/persona-mention.yml to .prettierignore, with a comment in the same style as its neighbours naming the template it is copied from (petry-projects/.github/standards/workflows/persona-mention.yml).

Ignoring a path that does not exist yet is harmless, so this can and should merge before the stub arrives.

Acceptance criteria

  1. .prettierignore contains .github/workflows/persona-mention.yml with an explanatory comment.
  2. npm run check passes.
  3. No file under .github/workflows/ is added or edited in this change. In particular, do not add persona-mention.yml here: the standards sweep delivers it, pinned to this repo's ring.

Budget guard

One file. If npm run check fails for an unrelated reason, report it and stop.

Activity

  1. don-petry commented on Oct 11, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #618 — Add persona-mention.yml to .prettierignore before the stub sync lands

    Scope

    Add .github/workflows/persona-mention.yml to .prettierignore with an explanatory comment matching the neighbouring stub entries. No workflow files are added or edited.

    Implementation Checklist

    • .prettierignore: append comment + .github/workflows/persona-mention.yml entry

    Tests to Write

    • None — configuration-only change (TDD exception). Verified via npm run check.

    Test Command

    npm run check and npm test

  2. changed the title [-]Add persona-mention.yml to .prettierignore before the stub sync lands — autofix would reformat the verbatim stub and main would fail the format check[/-] [+]Add persona-mention.yml to .prettierignore before the stub sync[/+] on Oct 11, 2026
  3. don-petry commented on Oct 11, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #618 — Add persona-mention.yml to .prettierignore before the stub sync

    Scope

    Add .github/workflows/persona-mention.yml to .prettierignore with an explanatory comment matching its neighbours. No workflow files added or edited.

    Implementation Checklist

    • .prettierignore: append comment + .github/workflows/persona-mention.yml entry

    Tests to Write

    • None — pure configuration change (TDD exception). Verification via npm run check and npm test.

    Test Command

    npm run check && npm test

  4. don-petry commented on Oct 11, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete — PR #619

    The implementation for issue #618 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  5. added a commit that references this issue on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions