Skip to content

[Fleet Monitor] petry-projects/google-app-scripts β€” dependency-audit.ymlΒ #304

Closed

Description

@github-actions

πŸ”΄ CRITICAL: petry-projects/google-app-scripts / dependency-audit.yml

Metric Value
Failure Rate 100% (40 / 40 runs)
Status CRITICAL
p50 Duration 719s
p95 Duration 1349s
Successful Runs 0
Cancelled Runs 0

Workflow: dependency-audit.yml

Last updated by Fleet Monitor run on 2026-05-19.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 3, 2026
  2. don-petry commented on Jun 8, 2026

    @don-petry
    Collaborator

    Dev-Lead Implementation Plan

    Issue: #304 β€” [Fleet Monitor] petry-projects/google-app-scripts β€” dependency-audit.yml

    Root Cause Investigation

    After investigating the 100% failure rate (40/40 runs), I found the following:

    Root cause: npm audit --audit-level=low was detecting two real vulnerabilities in the package-lock.json at the time of the May 19, 2026 fleet report:

    1. brace-expansion 5.0.2–5.0.5 (moderate) β€” GHSA-jxxr-4gwj-5jf2: Large numeric range defeats max DoS protection
    2. fast-uri ≀3.1.1 (high) β€” GHSA-v39h-62p7-jpjc: host confusion via percent-encoded authority delimiters

    The workflow was behaving correctly β€” it detected genuine vulnerabilities and failed the build.

    Current State

    • npm audit now reports 0 vulnerabilities (both packages are no longer transitive dependencies in the current lockfile)
    • All dependency-audit workflow runs since June 1, 2026 show success
    • The dependency-audit.yml was also updated from @v1 β†’ @v2 of the reusable workflow as part of org-wide changes merged June 7, 2026

    Scope

    No code changes are required β€” the issue is already resolved. This plan documents the investigation and verification steps.

    Implementation Checklist

    • Fetch and inspect actual CI failure logs to determine root cause
    • Verify npm audit now reports 0 vulnerabilities
    • Confirm all 301 tests pass (npm test)
    • Confirm lint/format checks pass (npm run check)
    • Confirm dependency-audit.yml runs succeed in CI (most recent 50 runs all pass)

    Tests to Write

    No new tests required β€” this was a dependency vulnerability issue, not a logic defect. The dependency-audit.yml workflow itself is the test.

    Test Command

    npm test (all 301 unit tests), npm run check (lint/format), npm audit (0 vulnerabilities)

  3. don-petry commented on Jun 8, 2026

    @don-petry
    Collaborator

    Dev-Lead: Implementation Complete

    Plan Execution

    • Investigated CI failure logs for May 2026 failures β€” root cause identified as real npm vulnerabilities
    • Verified npm audit now reports 0 vulnerabilities (fixed upstream by package updates)
    • Confirmed all 301 tests pass across 12 test suites
    • Confirmed lint/format checks pass (0 errors)
    • Confirmed dev-lead lint script passes (only pre-existing shellcheck warnings)
    • Confirmed coverage meets all thresholds (statements 98.91%, branches 90%, functions 98%, lines 100%)
    • Confirmed dependency-audit CI workflow has been passing since June 1, 2026 (all 50 checked runs pass)

    Root Cause

    The workflow was failing correctly β€” it detected two genuine npm vulnerabilities:

    1. brace-expansion 5.0.2–5.0.5 (moderate) β€” GHSA-jxxr-4gwj-5jf2
    2. fast-uri ≀3.1.1 (high) β€” GHSA-v39h-62p7-jpjc

    These were transitive dependencies. Both have since been resolved: neither package appears in the current dependency tree.

    Test Results

    Test Suites: 12 passed, 12 total
    Tests:       301 passed, 301 total
    npm audit: 0 vulnerabilities
    
    Coverage:
    βœ… statements: 98.91% (required: 95%)
    βœ… branches:   90.00% (required: 85%)
    βœ… functions:  98.00% (required: 95%)
    βœ… lines:     100.00% (required: 100%)
    

    Files Changed

    No files changed β€” the vulnerabilities were already resolved by package updates in the main branch prior to this issue being assigned.

    Notes

    This is a resolved-by-upstream-fix scenario. The fleet monitor issue was filed on 2026-05-19 when the package-lock.json contained vulnerable transitive dependencies. Those packages are no longer present in the dependency tree as of the current main branch. The dependency-audit.yml workflow has been passing continuously since 2026-06-01. No further action is required beyond closing this issue.

  4. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  5. don-petry commented on Jun 9, 2026

    @don-petry
    Collaborator

    Dev-Lead Implementation Plan

    Issue: #304 β€” [Fleet Monitor] petry-projects/google-app-scripts β€” dependency-audit.yml

    Scope

    Investigate and resolve the 100% failure rate (40/40 runs) for the dependency-audit.yml workflow that was reported on 2026-05-19.

    Investigation Findings

    This issue was previously investigated (see prior comments). After verifying the current state:

    • Root cause (historical): npm audit --audit-level=low correctly detected two real vulnerabilities in the package-lock.json as of May 2026:
      1. brace-expansion 5.0.2–5.0.5 (moderate) β€” GHSA-jxxr-4gwj-5jf2
      2. fast-uri ≀3.1.1 (high) β€” GHSA-v39h-62p7-jpjc
    • Current state: npm audit reports 0 vulnerabilities; all workflow runs since June 1, 2026 are passing

    Implementation Checklist

    • Verify npm audit reports 0 vulnerabilities
    • Confirm all tests pass (npm test β€” 301/301)
    • Confirm lint/format checks pass (npm run check β€” 0 errors)
    • Confirm dev-lead lint passes (only pre-existing shellcheck warnings)
    • Confirm dependency-audit.yml workflow running successfully in CI

    Tests to Write

    None β€” this is a resolved-by-upstream-fix scenario. No code changes required.

    Test Command

    npm test (unit tests), npm run check (lint/format), npm audit (vulnerability audit)

    Exception (Phase 2/3)

    Skipping TDD and implementation phases per the exception rule: this is a pure configuration/dependency issue with no observable behavioral change to implement β€” the vulnerability was fixed upstream in the npm dependency graph.

  6. don-petry commented on Jun 9, 2026

    @don-petry
    Collaborator

    Dev-Lead: Implementation Complete

    Plan Execution

    • Verified npm audit reports 0 vulnerabilities (confirmed: found 0 vulnerabilities)
    • Confirmed all 301 tests pass across 12 test suites
    • Confirmed lint/format checks pass (0 errors, 22 warnings pre-existing)
    • Confirmed dev-lead lint passes (only pre-existing SC2043 shellcheck warnings)
    • Confirmed dependency-audit.yml workflow has been passing continuously since 2026-06-01

    Root Cause

    The workflow was operating correctly β€” it failed because it detected genuine npm vulnerabilities:

    1. brace-expansion 5.0.2–5.0.5 (moderate) β€” GHSA-jxxr-4gwj-5jf2: DoS via large numeric range
    2. fast-uri ≀3.1.1 (high) β€” GHSA-v39h-62p7-jpjc: host confusion via percent-encoded authority

    These were transitive dependencies now absent from the current dependency tree. Additionally, the workflow was updated from @v1 β†’ @v2 of the reusable workflow in June 2026.

    Test Results

    Test Suites: 12 passed, 12 total
    Tests:       301 passed, 301 total
    npm audit:   0 vulnerabilities
    npm run check: 0 errors
    dev-lead-lint: pass (pre-existing warnings only)
    

    Files Changed

    No files changed β€” the vulnerabilities were resolved upstream; the dependency-audit.yml caller stub is already on @v2 and correct.

    Notes

    This is a resolved-by-upstream-fix scenario. The fleet monitor issue was filed on 2026-05-19 when the package-lock.json contained vulnerable transitive dependencies. Those packages are no longer present in the dependency tree. All 50 recent workflow runs show success. No further action required.

  7. don-petry commented on Jul 15, 2026

    @don-petry
    Collaborator

    βœ… Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-05-19 (57 days) β€” the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions