Skip to content

Compliance: delete_branch_on_merge #164

Closed

Description

@don-petry

Compliance Finding

Category: settings
Severity: warning
Check: delete_branch_on_merge

Detail

Automatically delete head branches must be enabled (current: null, expected: true)

Standard Reference

standards/github-settings.md#repository-settings--standard-defaults

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Apr 9, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-09)

    This finding is still open.

    Detail: Automatically delete head branches must be enabled (current: null, expected: true)

    Standard: standards/github-settings.md#repository-settings--standard-defaults

  2. don-petry commented on Apr 9, 2026

    @don-petry
    CollaboratorAuthor

    Claude encountered an error —— View job


    I'll analyze this and get back to you.

  3. don-petry commented on Apr 10, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-10)

    This finding is still open.

    Detail: Automatically delete head branches must be enabled (current: null, expected: true)

    Standard: standards/github-settings.md#repository-settings--standard-defaults

  4. don-petry commented on Apr 14, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 1m 2s —— View job • claude/issue-164-20260414-1130 • [Create PR ➔](https://github.com/petry-projects/google-app-scripts/compare/main...claude/issue-164-20260414-1130?quick_pull=1&title=Issue%20%23164%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23164%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)


    Fixing delete_branch_on_merge Compliance Finding

    • Read org standards for GitHub settings
    • Check existing settings file in repo
    • Implement delete_branch_on_merge: true fix
    • Create PR and self-review
    • Tag CODEOWNERS for review

    Added delete_branch_on_merge: true to .github/settings.yml under the repository section. When probot/settings runs, it will apply this setting to enable automatic deletion of head branches after PR merge, resolving the compliance finding.

    petry-projects/google-app-scripts#184

  5. added a commit that references this issue on Apr 14, 2026
    89cc303
  6. don-petry commented on Apr 17, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-17)

    This finding is still open.

    Detail: Automatically delete head branches must be enabled (current: null, expected: true)

    Standard: standards/github-settings.md#repository-settings--standard-defaults

  7. don-petry commented on Apr 18, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 3m 57s —— View job • claude/issue-164-20260418-1849 • [Create PR ➔](https://github.com/petry-projects/google-app-scripts/compare/main...claude/issue-164-20260418-1849?quick_pull=1&title=Issue%20%23164%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23164%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)


    Fixing delete_branch_on_merge Compliance Finding

    What was done: Added delete_branch_on_merge: true under a repository: section in .github/settings.yml. The GitHub API already returns true for this setting (likely set manually), but the declarative config was missing. Persisting it ensures probot/settings enforces the value on every run, making the compliance state durable.

    petry-projects/google-app-scripts#200 | | Branch

  8. added a commit that references this issue on Apr 18, 2026
    28490f5
  9. 11 remaining items

  10. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Automatically delete head branches must be enabled (current: null, expected: true)

    Standard: standards/github-settings.md#repository-settings--standard-defaults

  11. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Automatically delete head branches must be enabled (current: null, expected: true)

    Standard: standards/github-settings.md#repository-settings--standard-defaults

  12. don-petry commented on May 13, 2026

    @don-petry
    CollaboratorAuthor

    Resolved! This check is now passing as of 2026-05-13. Closing automatically.

  13. don-petry commented on Jun 2, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #164 — Compliance: delete_branch_on_merge

    Scope

    Enable delete_branch_on_merge repository setting to satisfy the compliance audit requirement (expected: true).

    Investigation Finding

    Before writing any code, I verified the current state:

    • .github/settings.yml already contains delete_branch_on_merge: true
    • GitHub API (gh api repos/petry-projects/google-app-scripts) already returns delete_branch_on_merge: true

    The repository is already compliant. The settings.yml has the correct value and the live GitHub repository setting matches.

    Implementation Checklist

    • Verify .github/settings.yml contains delete_branch_on_merge: true — confirmed on main
    • Verify GitHub repository API returns delete_branch_on_merge: true — confirmed via API

    Tests to Write

    None required — this is a pure repository configuration change with no observable behavioral change in code. TDD exception applies per AGENTS.md: "For pure documentation, configuration, or behavior-preserving refactors with no observable behavioral change, skip this phase."

    Test Command

    npm test

    Next Steps

    Post completion report confirming compliance. No code changes needed.

  14. don-petry commented on Jun 2, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Read AGENTS.md and project standards
    • Verified .github/settings.yml already contains delete_branch_on_merge: true
    • Verified GitHub repository API already returns delete_branch_on_merge: true
    • Confirmed all other standard settings (allow_auto_merge: true, has_wiki: false) are also correct
    • Ran full test suite — all tests pass

    Test Results

    Test Suites: 12 passed, 12 total
    Tests:       301 passed, 301 total
    Snapshots:   0 total
    Time:        4.336 s
    Ran all test suites.
    

    Files Changed

    None — no changes were required.

    Notes

    The repository was already fully compliant at investigation time:

    • .github/settings.yml on main has delete_branch_on_merge: true (managed via probot/settings)
    • The live GitHub repository setting also returns true via the API

    The compliance audit likely flagged this before probot/settings had a chance to sync the settings.yml configuration to the actual repository. No code or configuration changes were necessary.

    TDD exception noted: This was a pure configuration compliance check with no behavioral code change, so Phase 2 (failing tests) was skipped per AGENTS.md policy.

  15. don-petry commented on Jun 5, 2026

    @don-petry
    CollaboratorAuthor

    Resolved! This check is now passing as of 2026-06-05. Closing automatically.

  16. added a commit that references this issue on Jun 15, 2026
  17. added 4 commits that reference this issue on Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions