Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
Implements the mobile UI + client-side plumbing for Epic 10’s planning surfaces (homepage context cards + weekly plan queue), including new GraphQL operations, React Query hooks, updated tab screens, and tests.
Changes:
- Added planning GraphQL documents plus React Query hooks for weekly queue and task actions.
- Replaced placeholder Home/Plan tab screens with a “Happy Context” homepage and a weekly plan queue UI.
- Updated navigation tests and added dedicated homepage tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/mobile/src/services/graphql/planning.ts | Adds GraphQL queries/mutations for weekly queue, homepage context, task actions, and seasonal calendar. |
| apps/mobile/src/features/planning/hooks/use-weekly-queue.ts | Adds React Query hooks for fetching the weekly queue and mutating task status. |
| apps/mobile/app/(tabs)/plan/index.tsx | Implements Weekly Plan screen UI (materials checklist, apiary accordion, task action buttons). |
| apps/mobile/app/(tabs)/index.tsx | Implements homepage greeting + context card UI + primary navigation CTAs. |
| apps/mobile/tests/navigation.test.tsx | Updates screen stub expectations and adds mocks for new planning/auth dependencies. |
| apps/mobile/tests/homepage.test.tsx | Adds tests for homepage greeting, cards, and CTA navigation. |
| _bmad-output/implementation-artifacts/sprint-status.yaml | Updates sprint status tracking for Epic 10 items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Review — fix requested (cycle 1/3)The automated review identified the following issues. Please address each one: Findings to fix
Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
|
@claude Please address all open review comments on this PR from CodeRabbit and Copilot. |
|
Claude finished @don-petry's task in 5m 58s —— View job Addressing Review CommentsAll open Copilot and don-petry review findings addressed in commit Todo List
What was fixed
|
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
4 similar comments
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
1 similar comment
Review — fix requested (cycle 2/3)The automated review identified the following issues. Please address each one: Findings to fix[Findings would be inserted here] Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
|
CI Failure: SonarCloud Code AnalysisStep: SonarCloud Code Analysis (external quality gate) SonarCloud triggered a quality gate failure on this PR. The PR adds Suggested fix: Open the SonarCloud dashboard for this PR, identify which quality gate condition failed (coverage below threshold, new bugs, or code smells), then either add tests to cover the flagged uncovered code or adjust the |
CI Failure: SonarCloud Code AnalysisStep: SonarCloud Quality Gate This PR adds ~1943 lines of new code while introducing Suggested fix: Add unit tests for the |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
CI Failure: SonarCloud Code AnalysisStep: SonarCloud Quality Gate This PR adds Suggested fix: Add unit tests targeting the new Epic 10 components ( |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
CI Failure: SonarCloud Code AnalysisStep: SonarCloud Scan The Quality Gate failed on two conditions: 0.0% Coverage on New Code (required ≥ 80%) and C Security Rating on New Code (required ≥ A). The coverage is 0.0% because this PR adds Suggested fix: Add |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
|
| echo "EXPO_PUBLIC_API_URL=${EXPO_PUBLIC_API_URL}" >> .env | ||
|
|
||
| - name: Inject native Firebase config (Android) | ||
| if: env.GOOGLE_SERVICES_JSON != '' |
There was a problem hiding this comment.
In GitHub Actions, step-level env: is not populated when the step's if: condition is evaluated, so if: env.GOOGLE_SERVICES_JSON != '' (and if: env.GOOGLE_SERVICE_INFO_PLIST != '' on line 263) will always evaluate to false unless those variables are defined at the job/workflow level. In addition, mobile-build writes .env and native config files but never runs a build or bundle verification step afterward.
| @@ -0,0 +1,43 @@ | |||
| import { gql } from 'urql'; | |||
|
|
|||
| export const NOTIFICATIONS_QUERY = gql` | |||
There was a problem hiding this comment.
None of the GraphQL operations in this file (notifications, markNotificationRead, unreadNotificationCount, updateNotificationPreferences, NotificationPreferencesInput) exist in apps/api/graph/schema/*.graphql, and the preference fields (enabled, quietHoursStart, quietHoursEnd) do not match the notification_preferences schema in 000005_skill_notifications.up.sql (sensitivity_level, suppression_window_start, suppression_window_end). Any runtime call to these documents will fail GraphQL validation against the API.
| <Text size="md" className="font-medium">{task.title}</Text> | ||
| <Text size="xs" className="text-typography-400">{task.hiveName}</Text> | ||
| </View> | ||
| {task.isOverdue && ( |
There was a problem hiding this comment.
TaskRow never inspects task.priority (CRITICAL / HIGH / MEDIUM / LOW) and instead renders the URGENT badge solely when task.isOverdue is true. As a result, a non-overdue CRITICAL task shows no priority indicator, while an overdue LOW priority task is labeled URGENT (note that plan-screen.test.tsx:578 comments // Only critical should be URGENT, which only passed because task-1 in MOCK_QUEUES happened to have isOverdue: true).




Summary
Stacked on #35 (Epic 9).
Test plan
🤖 Generated with Claude Code
Problem
See the linked issue.
Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
tests/e2e/.gitkeep,tests/e2e/app-loads.spec.tstests/e2e/onboarding-flow.spec.ts,tests/e2e/web-compatibility.spec.ts. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.