Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement issue #180 — Compliance: check-suite-auto-trigger-1236702 #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: implement issue #180 — Compliance: check-suite-auto-trigger-1236702 #216
Changes from all commits
1511fa4f6376a97cdf673File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 50 in scripts/apply-repo-settings.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 60 in scripts/apply-repo-settings.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 62 in scripts/apply-repo-settings.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 67 in scripts/apply-repo-settings.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 102 in scripts/apply-repo-settings.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script calls
gh api -X PATCH repos/$ORG/$REPO/check-suite/preferences, but GitHub’s documented route for this operation is/repos/{owner}/{repo}/check-suites/preferences(pluralcheck-suites). Inscripts/apply-repo-settings.sh, this singular path will return a not-found error, and becauseset -eis enabled the script exits before applying any setting, so the intended auto-trigger disablement never happens outside dry-run mode.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch the request path to
/repos/{owner}/{repo}/check-suites/preferences(plural), because the currentcheck-suite/preferencesroute does not exist for this API. In non-dry-run mode this causesgh apito fail and, withset -euo pipefail, the script exits before applying any repository setting, so the intended auto-trigger disablement never happens.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.