Skip to content

Compliance: dev-lead-stub-agent-ref #411

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: error
Check: dev-lead-stub-agent-ref

Detail

The dev-lead.yml caller stub must pass with: agent_ref: dev-lead/<channel> (stable, next, or ring<N>) so the reusable checks out its own scripts/prompts from the same channel. Re-sync from standards/workflows/dev-lead.yml.

Standard Reference

standards/ci-standards.md#dev-lead-agent

Remediation

Copy the relevant workflow template from standards/workflows/ verbatim — do not generate from scratch:

gh api repos/petry-projects/.github/contents/standards/workflows/<template>.yml --jq '.content' | base64 -d > .github/workflows/<template>.yml

Available templates: agent-shield.yml, dev-lead.yml, dependabot-automerge.yml, dependabot-rebase.yml, dependency-audit.yml, feature-ideation.yml


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Jul 17, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #411 — Compliance: dev-lead-stub-agent-ref

    Scope

    Re-sync .github/workflows/dev-lead.yml from the canonical standards/workflows/dev-lead.yml template so the caller stub pins a valid dev-lead channel. The stub currently pins dev-lead/v1-stable, which is not one of the allowed channels (stable, next, ring<N>) enforced by check_dev_lead_stub in the compliance audit; the canonical template pins dev-lead/stable.

    Root Cause

    .github/workflows/dev-lead.yml line 64 (uses:) and line 66 (agent_ref:) both carry dev-lead/v1-stable. The dev-lead-stub-agent-ref check requires agent_ref: dev-lead/<channel> where <channel> matches stable|next|ring[0-9]+; v1-stable fails the regex. Fix is to copy the template verbatim (only diff is v1-stable -> stable on those two lines).

    Implementation Checklist

    • Update uses: ref on line 64 to ...dev-lead-reusable.yml@dev-lead/stable (retain the # NOSONAR(...) marker)
    • Update with.agent_ref on line 66 to dev-lead/stable
    • Confirm resulting file is byte-identical to standards/workflows/dev-lead.yml

    Tests to Write

    • No unit tests apply: this is a behavior-preserving CI-config change to a workflow YAML (Phase 2 config exception). Validation is via the repo lint script and a verbatim diff against the canonical template.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh (plus diff against the fetched canonical template)

  2. don-petry commented on Jul 17, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Updated uses: ref (line 64) to ...dev-lead-reusable.yml@dev-lead/stable, retaining the # NOSONAR(githubactions:S7637) marker
    • Updated with.agent_ref (line 66) to dev-lead/stable
    • Confirmed the resulting file is byte-identical to the canonical standards/workflows/dev-lead.yml

    Root Cause

    The stub pinned dev-lead/v1-stable in both the uses: ref and agent_ref. check_dev_lead_stub in the compliance audit only accepts channels matching stable|next|ring[0-9]+, so v1-stable failed the dev-lead-stub-agent-ref check. Re-synced from the canonical template, whose pin is dev-lead/stable.

    Verification

    Required lint script:

      [lint] shellcheck on 2 file(s)...
      [lint] validating CODEOWNERS...
    OK: CODEOWNERS
      [lint] all checks passed
    

    Compliance-audit check_dev_lead_stub checks reproduced locally against the fixed file:

    1) uses pin (stable|next|ring[0-9]+) ......... PASS (channel=stable)
    2) agent_ref matches uses channel ............ PASS
    3) no per-stub concurrency block ............. PASS
    4) statuses: read permission present ......... PASS
    

    Verbatim template match:

    diff .github/workflows/dev-lead.yml <canonical>  ->  IDENTICAL to canonical template
    

    Files Changed

    • .github/workflows/dev-lead.yml: changed the dev-lead channel pin from v1-stable to stable on the uses: ref and the with.agent_ref input (2 lines). No other lines touched; on:, permissions:, and the absence of a concurrency: block are unchanged.

    Notes

    • No unit tests were added: this is a behavior-preserving CI-configuration change to a workflow YAML (Phase 2 config exception). Validation is via the repo lint script and a byte-for-byte diff against the canonical template.
    • The channel pin is the only per-repo-adjustable field in this stub; it now uses the production default stable, consistent with the file's own header comments.
  3. added a commit that references this issue on Jul 17, 2026
  4. added 5 commits that reference this issue on Aug 4, 2026
  5. added a commit that references this issue on Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions