You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SonarCloud open findings in petry-projects/broodly — 7 issue(s) grouped as one workstream. Part of the org SonarCloud tuning initiative combsmith/.github#593.
Apply the flagged idiom fixes: optional chaining (S6582), replaceAll (S7781), globalThis over window (S7764), Number.parseInt (S7773), and the other per-line suggestions. Each carries SonarCloud's exact recommendation. Mechanical; behavior identical.
Acceptance
All listed SonarCloud findings for this repo/workstream resolved to zero
No behavior change; existing tests/CI green
Fixes are real (no blanket NOSONAR unless a confirmed false positive, noted inline)
Apply the 7 flagged SonarCloud fixes (S6759 ×2, S6767 ×2, S7726, S4782, S1871) across 5 Expo/RN files — all mechanical, behavior-preserving, verified against the SonarCloud API for exact line numbers.
as PropType flagged unused by both MappedHeading & Heading — split base type so MappedHeading no longer declares as, and make Heading's as usage statically detectable
apps/mobile/components/ui/heading/index.tsx:106
S1871
default case block duplicates case 'lg' — remove redundant explicit case 'lg' (falls through to identical default → H4)
apps/mobile/babel.config.js:1
S7726
Name the anonymous module.exports = function (api)
apps/mobile/components/ui/button/index.tsx:339
S4782
className?: string | undefined → drop redundant | undefined
Implementation Checklist
App.tsx — wrap ColorSwatch props in Readonly<>
gluestack-ui-provider/index.tsx — wrap provider props in Readonly<>
heading/index.tsx — split IHeadingProps base (no as) for MappedHeading; make Heading's as detectably used; remove duplicate case 'lg'
babel.config.js — name the config function
button/index.tsx — drop | undefined
Tests to Write
smoke-test.test.tsx — guard Heading renders at lg size (dedup path) and with a custom as component (behavior lock for the as refactor)
Test Command
pnpm --filter mobile test (jest), plus pnpm --filter mobile run lint and bash .dev-lead/scripts/dev-lead-lint.sh
Notes
Behavior-preserving refactors: no runtime change. Guard tests added for the two heading paths I touch. No NOSONAR used — all fixes are real.
Dev-Lead: issue #371 implementation failed — will retry
The engine failed (engine-error — e.g. a timeout or transient engine error). This was attempt 1 of 3; dev-lead will retry automatically. You can also re-apply the dev-lead label to retry now.
Dev-Lead: issue #371 implementation failed — will retry
The engine failed (engine-error — e.g. a timeout or transient engine error). This was attempt 2 of 3; dev-lead will retry automatically. You can also re-apply the dev-lead label to retry now.
Apply 7 mechanical, behavior-preserving SonarCloud idiom fixes across 5 files (exact locations confirmed via SonarCloud issues API).
Findings → Fixes
typescript:S6759 — apps/mobile/App.tsx:10 — mark ColorSwatch props Readonly<...>
typescript:S6759 — apps/mobile/components/ui/gluestack-ui-provider/index.tsx:8 — mark GluestackUIProvider props Readonly<...>
javascript:S7726 — apps/mobile/babel.config.js:1 — name the exported function (babelConfig)
typescript:S4782 — apps/mobile/components/ui/button/index.tsx:339 — drop redundant | undefined from className?: string | undefined
typescript:S6767 ×2 — apps/mobile/components/ui/heading/index.tsx:9 — split props type so MappedHeading no longer declares the unused as prop (kept on the public Heading, which uses it)
typescript:S1871 — apps/mobile/components/ui/heading/index.tsx:106 — remove duplicate case 'lg' block; 'lg' falls through to identical default (H4)
This issue has had no activity for 60 days. It will be closed in 7 days unless there is new activity. If this is still relevant, please comment or remove the stale label.
Activity
don-petry commentedon Jul 3, 2026
Dev-Lead Implementation Plan
Issue: #371 — SonarCloud: JavaScript code-quality modernization (×7)
Scope
Apply the 7 flagged SonarCloud fixes (S6759 ×2, S6767 ×2, S7726, S4782, S1871) across 5 Expo/RN files — all mechanical, behavior-preserving, verified against the SonarCloud API for exact line numbers.
Findings → Fixes (confirmed via SonarCloud API)
apps/mobile/App.tsx:10ColorSwatchpropsReadonly<>apps/mobile/components/ui/gluestack-ui-provider/index.tsx:8Readonly<>apps/mobile/components/ui/heading/index.tsx:9(×2)asPropType flagged unused by bothMappedHeading&Heading— split base type soMappedHeadingno longer declaresas, and makeHeading'sasusage statically detectableapps/mobile/components/ui/heading/index.tsx:106defaultcase block duplicatescase 'lg'— remove redundant explicitcase 'lg'(falls through to identicaldefault→ H4)apps/mobile/babel.config.js:1module.exports = function (api)apps/mobile/components/ui/button/index.tsx:339className?: string | undefined→ drop redundant| undefinedImplementation Checklist
App.tsx— wrapColorSwatchprops inReadonly<>gluestack-ui-provider/index.tsx— wrap provider props inReadonly<>heading/index.tsx— splitIHeadingPropsbase (noas) forMappedHeading; makeHeading'sasdetectably used; remove duplicatecase 'lg'babel.config.js— name the config functionbutton/index.tsx— drop| undefinedTests to Write
smoke-test.test.tsx— guardHeadingrenders atlgsize (dedup path) and with a customascomponent (behavior lock for theasrefactor)Test Command
pnpm --filter mobile test(jest), pluspnpm --filter mobile run lintandbash .dev-lead/scripts/dev-lead-lint.shNotes
Behavior-preserving refactors: no runtime change. Guard tests added for the two heading paths I touch. No
NOSONARused — all fixes are real.don-petry commentedon Jul 3, 2026
Dev-Lead: issue #371 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 1 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errordon-petry commentedon Jul 3, 2026
Dev-Lead: issue #371 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 2 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errorLast 40 lines of engine output (redacted)
don-petry commentedon Jul 4, 2026
Dev-Lead Implementation Plan
Issue: #371 — SonarCloud: JavaScript code-quality modernization (×7)
Scope
Apply 7 mechanical, behavior-preserving SonarCloud idiom fixes across 5 files (exact locations confirmed via SonarCloud issues API).
Findings → Fixes
typescript:S6759—apps/mobile/App.tsx:10— markColorSwatchpropsReadonly<...>typescript:S6759—apps/mobile/components/ui/gluestack-ui-provider/index.tsx:8— markGluestackUIProviderpropsReadonly<...>javascript:S7726—apps/mobile/babel.config.js:1— name the exported function (babelConfig)typescript:S4782—apps/mobile/components/ui/button/index.tsx:339— drop redundant| undefinedfromclassName?: string | undefinedtypescript:S6767×2 —apps/mobile/components/ui/heading/index.tsx:9— split props type soMappedHeadingno longer declares the unusedasprop (kept on the publicHeading, which uses it)typescript:S1871—apps/mobile/components/ui/heading/index.tsx:106— remove duplicatecase 'lg'block;'lg'falls through to identicaldefault(H4)Implementation Checklist
apps/mobile/App.tsx— Readonly ColorSwatch propsapps/mobile/components/ui/gluestack-ui-provider/index.tsx— Readonly provider propsapps/mobile/babel.config.js— named functionapps/mobile/components/ui/button/index.tsx— remove redundant| undefinedapps/mobile/components/ui/heading/index.tsx— split props type + dedupe switch caseTests to Write
Heading size="lg"renders (guards S1871 default fallthrough)Heading as={...}renders polymorphically (guards S6767 type split)Test Command
pnpm --filter mobile run test(also:pnpm -r run typecheck,pnpm -r run lint,pnpm format:check)don-petry commentedon Jul 4, 2026
Dev-Lead: cannot implement issue #371 — needs human attention
Automatic retries are exhausted (attempt 3 of 3). The most recent failure was
engine-error.Please review the failures above. To retry anyway, remove the
dev-lead:needs-humanlabel and re-apply thedev-leadlabel.github-actions commentedon Sep 7, 2026
This issue has had no activity for 60 days. It will be closed in 7 days unless there is new activity. If this is still relevant, please comment or remove the
stalelabel.github-actions commentedon Sep 14, 2026
Closed after 60 days of inactivity followed by 7 days in stale state (~67 days total). Re-open if this is still relevant.