You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Replace the current feature-ideation.yml with the canonical stub pinned to @v1 (SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d) per the org standard, adding the missing dry_run input, actions: read permission, and related with: block entries.
Implementation Checklist
Update .github/workflows/feature-ideation.yml: pin uses: to @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1
Add dry_run workflow_dispatch input (missing from current stub)
Add actions: read permission (missing from current stub)
Add commented sources_file option and dry_run pass-through in with: block
Tests to Write
N/A — this is a pure CI configuration compliance fix with no observable behavioral change in application code; no unit/integration tests apply.
Test Command
yamllint .github/workflows/feature-ideation.yml (YAML lint to validate syntax)
Added dry_run workflow_dispatch input (was missing from the repo's stub)
Added actions: read permission (required by v1 reusable for feed checkpoint query)
Added sources_file comment and dry_run pass-through in with: block
Updated "To adopt" instructions to match canonical (added step 3 about sources file)
Updated permissions comment block to document actions: read
Test Results
TDD exception noted: this is a pure CI configuration compliance fix — no observable behavioral change in application code. No unit/integration tests apply.
YAML validation:
YAML valid
Files Changed
.github/workflows/feature-ideation.yml: Replaced @v2 SHA pin with canonical @v1 SHA (ee22b427cbce9ecadcf2b436acb57c3adf0cb63d); added dry_run input, actions: read permission, sources_file comment, and dry_run pass-through — bringing the stub fully in line with the canonical from standards/workflows/feature-ideation.yml.
Notes
The repo's stub was pinned to the v2 SHA (376a4fcb...) of the reusable workflow while the org standard specifies v1 (ee22b427...). All additional fields present in the canonical stub but absent here (dry_run, actions: read, sources_file comment) were also added in the same pass. The project_context placeholder was left as-is (TODO) since it was already a placeholder in the pre-existing file and filling it in is outside the scope of this compliance issue.
Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.
Replace .github/workflows/feature-ideation.yml with the canonical stub from petry-projects/.github/standards/workflows/feature-ideation.yml, which delegates to feature-ideation-reusable.yml@v1 (currently the repo pins a v2 SHA), and fill the per-repo project_context with Broodly's actual description.
Implementation Checklist
Overwrite .github/workflows/feature-ideation.yml with the canonical stub (pinned to @897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1, including the discussion: created trigger, dry_run input, actions: read permission, target_discussion input, and sources_file guidance)
Set project_context to a Broodly-specific description (the one required per-repo edit)
Tests to Write
N/A — pure CI config change with no executable behavior. Validate via YAML parse + .dev-lead/scripts/dev-lead-lint.sh (Phase 2 exception noted)
Overwrote .github/workflows/feature-ideation.yml with the canonical stub from petry-projects/.github/standards/workflows/feature-ideation.yml
Repinned the reusable from @376a4fcb… # v2 → @897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1 (org standard)
Adopted the canonical stub additions: discussion: created trigger + Ideas-category guard, dry_run input, target_discussion input, actions: read permission, and sources_file guidance
Filled the per-repo project_context with Broodly's actual description (the one required per-repo edit)
Test Results
No executable tests apply — this is a pure CI-config (workflow YAML) change (Phase 2 TDD exception). Verified instead by:
$ python3 -c "import yaml; d=yaml.safe_load(open('.github/workflows/feature-ideation.yml')); print(d['jobs']['ideate']['uses'])"
YAML OK
uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda
$ bash .dev-lead/scripts/dev-lead-lint.sh
[lint] shellcheck on 2 file(s)...
[lint] validating CODEOWNERS...
OK: CODEOWNERS
[lint] all checks passed
Files Changed
.github/workflows/feature-ideation.yml: replaced with the canonical thin-caller stub delegating to feature-ideation-reusable.yml@v1; preserved trigger/permissions/secrets shape required by the reusable and customised only project_context.
Notes
The reusable is referenced by its v1-tagged commit SHA (@897e4dede… # v1) per the canonical stub and supply-chain pinning convention — this resolves the "not pinned to @v1" finding. The previous repo file pinned a v2 SHA and was missing the discussion-trigger/dry_run/actions-read additions. No other files were touched.
Activity
don-petry commentedon May 26, 2026
Dev-Lead Implementation Plan
Issue: #254 — Compliance: non-stub-feature-ideation.yml
Scope
Replace the current
feature-ideation.ymlwith the canonical stub pinned to@v1(SHAee22b427cbce9ecadcf2b436acb57c3adf0cb63d) per the org standard, adding the missingdry_runinput,actions: readpermission, and relatedwith:block entries.Implementation Checklist
.github/workflows/feature-ideation.yml: pinuses:to@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1dry_runworkflow_dispatch input (missing from current stub)actions: readpermission (missing from current stub)sources_fileoption anddry_runpass-through inwith:blockTests to Write
Test Command
yamllint .github/workflows/feature-ideation.yml(YAML lint to validate syntax)don-petry commentedon May 26, 2026
Dev-Lead: Implementation Complete
Plan Execution
uses:line:@376a4fcb1117444595e3e702fa450873d0e54310 # v2→@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1(core compliance fix)dry_runworkflow_dispatch input (was missing from the repo's stub)actions: readpermission (required by v1 reusable for feed checkpoint query)sources_filecomment anddry_runpass-through inwith:blockactions: readTest Results
Files Changed
.github/workflows/feature-ideation.yml: Replaced@v2SHA pin with canonical@v1SHA (ee22b427cbce9ecadcf2b436acb57c3adf0cb63d); addeddry_runinput,actions: readpermission,sources_filecomment, anddry_runpass-through — bringing the stub fully in line with the canonical fromstandards/workflows/feature-ideation.yml.Notes
The repo's stub was pinned to the v2 SHA (
376a4fcb...) of the reusable workflow while the org standard specifies v1 (ee22b427...). All additional fields present in the canonical stub but absent here (dry_run,actions: read,sources_filecomment) were also added in the same pass. Theproject_contextplaceholder was left as-is (TODO) since it was already a placeholder in the pre-existing file and filling it in is outside the scope of this compliance issue.don-petry commentedon May 29, 2026
Weekly Compliance Audit (2026-05-29)
This finding is still open.
Detail: Centralized workflow
feature-ideation.ymlreferences the reusable but is not pinned to@v1(org standard). Replace with the canonical stub fromstandards/workflows/feature-ideation.ymlwhich delegates topetry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon May 30, 2026
Weekly Compliance Audit (2026-05-30)
This finding is still open.
Detail: Centralized workflow
feature-ideation.ymlreferences the reusable but is not pinned to@v1(org standard). Replace with the canonical stub fromstandards/workflows/feature-ideation.ymlwhich delegates topetry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon May 30, 2026
@dev-lead
don-petry commentedon May 30, 2026
@dev-lead
don-petry commentedon May 30, 2026
@don-petry-dev-lead
don-petry commentedon Jun 5, 2026
Weekly Compliance Audit (2026-06-05)
This finding is still open.
Detail: Centralized workflow
feature-ideation.ymlreferences the reusable but is not pinned to@v1(org standard). Replace with the canonical stub fromstandards/workflows/feature-ideation.ymlwhich delegates topetry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon Jun 12, 2026
Weekly Compliance Audit (2026-06-12)
This finding is still open.
Detail: Centralized workflow
feature-ideation.ymlreferences the reusable but is not pinned to@v1(org standard). Replace with the canonical stub fromstandards/workflows/feature-ideation.ymlwhich delegates topetry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon Jun 19, 2026
Weekly Compliance Audit (2026-06-19)
This finding is still open.
Detail: Centralized workflow
feature-ideation.ymlreferences the reusable but is not pinned to@v1(org standard). Replace with the canonical stub fromstandards/workflows/feature-ideation.ymlwhich delegates topetry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon Jun 19, 2026
Dev-Lead Implementation Plan
Issue: #254 — Compliance: non-stub-feature-ideation.yml
Scope
Replace
.github/workflows/feature-ideation.ymlwith the canonical stub frompetry-projects/.github/standards/workflows/feature-ideation.yml, which delegates tofeature-ideation-reusable.yml@v1(currently the repo pins av2SHA), and fill the per-repoproject_contextwith Broodly's actual description.Implementation Checklist
.github/workflows/feature-ideation.ymlwith the canonical stub (pinned to@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1, including thediscussion: createdtrigger,dry_runinput,actions: readpermission,target_discussioninput, and sources_file guidance)project_contextto a Broodly-specific description (the one required per-repo edit)Tests to Write
.dev-lead/scripts/dev-lead-lint.sh(Phase 2 exception noted)Test Command
bash .dev-lead/scripts/dev-lead-lint.sh+python3 -c "import yaml; yaml.safe_load(open('.github/workflows/feature-ideation.yml'))"don-petry commentedon Jun 19, 2026
Dev-Lead: Implementation Complete
Plan Execution
.github/workflows/feature-ideation.ymlwith the canonical stub frompetry-projects/.github/standards/workflows/feature-ideation.yml@376a4fcb… # v2→@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1(org standard)discussion: createdtrigger + Ideas-category guard,dry_runinput,target_discussioninput,actions: readpermission, and sources_file guidanceproject_contextwith Broodly's actual description (the one required per-repo edit)Test Results
No executable tests apply — this is a pure CI-config (workflow YAML) change (Phase 2 TDD exception). Verified instead by:
Files Changed
.github/workflows/feature-ideation.yml: replaced with the canonical thin-caller stub delegating tofeature-ideation-reusable.yml@v1; preserved trigger/permissions/secrets shape required by the reusable and customised onlyproject_context.Notes
The reusable is referenced by its
v1-tagged commit SHA (@897e4dede… # v1) per the canonical stub and supply-chain pinning convention — this resolves the "not pinned to @v1" finding. The previous repo file pinned av2SHA and was missing the discussion-trigger/dry_run/actions-read additions. No other files were touched.feat: implement issue #254 — Compliance: non-stub-feature-ideation.yml (