Skip to content

Compliance: codeowners-no-catchall #247

Closed

Description

@don-petry

Compliance Finding

Category: settings
Severity: warning
Check: codeowners-no-catchall

Detail

CODEOWNERS has no default * catch-all pattern — files not matched by a path rule will have no owner and require_code_owner_review will not apply to them

Standard Reference

standards/codeowners-standard.md

Remediation

Run scripts/apply-repo-settings.sh broodly with a token that has admin access to the repository (requires a classic PAT with repo scope or equivalent):

GH_TOKEN=<admin-pat> bash scripts/apply-repo-settings.sh broodly

This script applies all standard settings defined in standards/github-settings.md in one pass.
For a dry run to preview changes without applying: DRY_RUN=true GH_TOKEN=<admin-pat> bash scripts/apply-repo-settings.sh broodly


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on May 26, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #247 — Compliance: codeowners-no-catchall

    Scope

    Ensure .github/CODEOWNERS contains the * catch-all pattern so every file in the repository has a designated code owner and require_code_owner_review applies universally.

    Findings

    The compliance audit flagged this repository as missing a catch-all pattern. Upon inspection, commit f054b7a (merged 2026-05-26) added .github/CODEOWNERS with the correct catch-all already in place:

    * @petry-projects/org-leads
    

    No additional source changes are required.

    Implementation Checklist

    • .github/CODEOWNERS — verify * catch-all present and assigns @petry-projects/org-leads

    Tests to Write

    N/A — this is a pure repository-settings/configuration change. Per org standards, TDD phase is skipped for behavior-preserving configuration fixes with no observable code behavior.

    Test Command

    pnpm test (no tests for CODEOWNERS itself; compliance check passes once the file is correct on main)

  2. don-petry commented on May 26, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Investigated .github/CODEOWNERS on current main branch
    • Confirmed * @petry-projects/org-leads catch-all is present (added in commit f054b7a, merged 2026-05-26)
    • Verified file has clean Unix line endings and correct GitHub CODEOWNERS syntax
    • Confirmed no diff exists between dev-lead branch and main for this file

    Test Results

    N/A — pure configuration file; no executable tests apply.
    The compliance check (codeowners-no-catchall) will pass on next audit run
    since the catch-all pattern is present on main.
    

    Files Changed

    • .github/CODEOWNERS: No changes needed — the * catch-all (* @petry-projects/org-leads) was already added in commit f054b7a prior to this dev-lead branch being created.

    Notes

    The compliance audit that generated this issue ran before commit f054b7a was merged. That commit created .github/CODEOWNERS with the required catch-all in one pass, resolving the finding. The next weekly compliance audit should clear this issue automatically. No follow-up issues needed.

    TDD exception: Phase 2 skipped per org standards — this is a pure repository-settings/configuration change with no observable behavioral change in application code.

  3. don-petry commented on May 29, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-05-29)

    This finding is still open.

    Detail: CODEOWNERS has no default * catch-all pattern — files not matched by a path rule will have no owner and require_code_owner_review will not apply to them

    Standard: standards/codeowners-standard.md

  4. don-petry commented on May 30, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-05-30)

    This finding is still open.

    Detail: CODEOWNERS has no default * catch-all pattern — files not matched by a path rule will have no owner and require_code_owner_review will not apply to them

    Standard: standards/codeowners-standard.md

  5. don-petry commented on May 30, 2026

    @don-petry
    ContributorAuthor
  6. don-petry commented on May 30, 2026

    @don-petry
    ContributorAuthor
  7. don-petry commented on May 30, 2026

    @don-petry
    ContributorAuthor

    @don-petry-dev-lead

  8. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 2, 2026
  9. don-petry commented on Jun 5, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-06-05)

    This finding is still open.

    Detail: CODEOWNERS has no default * catch-all pattern — files not matched by a path rule will have no owner and require_code_owner_review will not apply to them

    Standard: standards/codeowners-standard.md

  10. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 6, 2026
  11. don-petry commented on Jun 12, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-06-12)

    This finding is still open.

    Detail: CODEOWNERS has no default * catch-all pattern — files not matched by a path rule will have no owner and require_code_owner_review will not apply to them

    Standard: standards/codeowners-standard.md

  12. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 12, 2026
  13. don-petry commented on Jun 19, 2026

    @don-petry
    ContributorAuthor

    Resolved! This check is now passing as of 2026-06-19. Closing automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions