Skip to content

Compliance: reusable-workflow-path-duplicate-github #158

Closed

Description

@don-petry

Compliance Finding

Category: workflow-syntax
Severity: error
Check: reusable-workflow-path-duplicate-github

Detail

Workflow agent-shield.yml has 1 reusable workflow reference(s) with duplicate .github/ segment. Change petry-projects/.github/.github/workflows/ to petry-projects/.github/workflows/

Standard Reference

standards/ci-standards.md#action-pinning-policy

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Apr 21, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-04-21)

    This finding is still open.

    Detail: Workflow dependabot-automerge.yml has 1 reusable workflow reference(s) with duplicate .github/ segment. Change petry-projects/.github/.github/workflows/ to petry-projects/.github/workflows/

    Standard: standards/ci-standards.md#action-pinning-policy

  2. don-petry commented on Apr 21, 2026

    @don-petry
    ContributorAuthor

    Claude finished @don-petry's task in 2m 10s —— View job • claude/issue-158-20260421-0139 • [Create PR ➔](https://github.com/petry-projects/broodly/compare/main...claude/issue-158-20260421-0139?quick_pull=1&title=Issue%20%23158%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23158%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)


    Fixing Duplicate .github/ Segment in Workflow References

    • Gather context (read issue, identify affected files: agent-shield.yml and dependabot-automerge.yml)
    • Fetch canonical templates from petry-projects/.github/standards/workflows/ (templates also had the bug; applied the compliance-mandated fix directly)
    • Apply fix to agent-shield.yml — uses: petry-projects/.github/workflows/agent-shield-reusable.yml@v1
    • Apply fix to dependabot-automerge.yml — uses: petry-projects/.github/workflows/dependabot-automerge-reusable.yml@v1
    • Commit and push changes
    • Create PR — petry-projects/broodly#160
    • Self-review: changes are minimal (4 lines: 2 uses: lines + 2 comment lines in each file), no bugs or regressions
    • Tag CODEOWNERS (@don-petry) for review

    What was done

    Both agent-shield.yml and dependabot-automerge.yml had a duplicate .github/ segment in their reusable workflow uses: references:

    # Before (incorrect)
    uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@v1
    
    # After (correct)
    uses: petry-projects/.github/workflows/agent-shield-reusable.yml@v1
    

    The # Reusable: header comment in each file was also updated to match.

    CI checks are queued — @don-petry please review and merge when green.

    View PR |

  3. don-petry commented on Apr 28, 2026

    @don-petry
    ContributorAuthor

    Resolved by combsmith/.github#165 which disabled the false positive 'reusable-workflow-path-duplicate-github' check. The pattern petry-projects/.github/.github/workflows/... is correct per GitHub's reusable workflow syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit finding

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions