Skip to content

Compliance: stub-surface-drift-pr-auto-review.yml-concurrency #508

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: warning
Check: stub-surface-drift-pr-auto-review.yml-concurrency

Detail

The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Copy the relevant workflow template from standards/workflows/ verbatim — do not generate from scratch:

gh api repos/petry-projects/.github/contents/standards/workflows/<template>.yml --jq '.content' | base64 -d > .github/workflows/<template>.yml

Available templates: agent-shield.yml, dev-lead.yml, dependabot-automerge.yml, dependabot-rebase.yml, dependency-audit.yml, feature-ideation.yml


This issue was automatically created by the weekly compliance audit.

Activity

  1. added
    compliance-auditAutomated compliance audit finding
    dev-leadFor dev-lead agent pickup
    compliance-findingMachine-owned: created and auto-closed by the compliance audit. Do not hand-apply.
    on Sep 18, 2026
  2. don-petry commented on Sep 18, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: implementation deferred — automation PR queue is full

    No pull request was opened for issue #508. The org-wide
    open-automation-PR queue is currently at its signed-off cap (see
    standards/pr-limits.json in petry-projects/.github).

    This issue stays labeled dev-lead and will be re-attempted automatically once
    the queue drains — no action is required.

  3. don-petry commented on Sep 25, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-09-25)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

  4. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 25, 2026
  5. don-petry commented on Sep 25, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #508 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency

    Scope

    Re-sync the missing concurrency: block in the thin caller stub .github/workflows/pr-auto-review.yml verbatim from the canonical standards/workflows/pr-auto-review.yml, restoring the centrally-owned concurrency surface that has drifted.

    Root cause

    The local stub is missing the entire concurrency: block (group expression + cancel-in-progress) and its explanatory comment that exist between permissions: {} and jobs: in the canonical template (issue #1126 dedup logic). The only other diff — the workflow_run.workflows comment — is inside the documented repo-adjustable surface (workflow name(s)) and is intentionally kept as-is; the finding is scoped to concurrency.

    Implementation Checklist

    • Insert the canonical concurrency: block (with its preceding comment) verbatim into .github/workflows/pr-auto-review.yml between permissions: {} and jobs:
    • Leave the repo-adjustable on:/workflow_run comment untouched (not part of the finding)
    • Confirm no with: forwarding is added (channel-pin guardrail — N/A here, no inputs changed)

    Tests to Write

    • None — pure CI-workflow configuration re-sync of a centrally-owned block, copied verbatim. Phase 2 TDD exception applies (no observable behavioral change; no existing test targets pr-auto-review.yml). Verification is via YAML validity + dev-lead lint + diff-against-canonical (concurrency block now matches).

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh (plus a byte-for-byte diff of the concurrency block against the canonical template)

  6. don-petry commented on Sep 25, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet; the automation posts the authoritative
    completion record (with PR number + head SHA) after the push. Treat the notes
    below as intent, not delivered results.

    Plan Execution (intended)

    • Inserted the canonical concurrency: block (group expression + cancel-in-progress, with its issue-#1126 explanatory comment) verbatim into .github/workflows/pr-auto-review.yml, between permissions: {} and jobs: — the block was previously absent (the drift).
    • Confirmed the concurrency surface now diffs byte-for-byte clean against standards/workflows/pr-auto-review.yml; the only remaining diff is the repo-adjustable workflow_run.workflows comment (documented as changeable — outside this finding's scope, left untouched).
    • No with: forward added → channel-pin sequencing guardrail (#1052/#1253) not implicated.

    Local check output (provisional — not the pushed run)

    dev-lead lint: all checks passed (shellcheck 12 files, CODEOWNERS OK)
    YAML parse: OK
    workflow guard test suites (ci / gitleaks / pr-review / sonarcloud): all passed
    

    Files touched (this workspace, not yet pushed)

    • .github/workflows/pr-auto-review.yml: added the missing centrally-owned concurrency: block, re-synced verbatim from canonical.

    Notes

    Pure CI-workflow configuration re-sync of a centrally-owned block copied verbatim — Phase 2 TDD exception applies (no observable behavioral change; no existing test targets pr-auto-review.yml). No repo has a pr-auto-review guard script, so nothing to update there.

  7. don-petry commented on Sep 25, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete — PR #521

    The implementation for issue #508 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  8. don-petry commented on Oct 2, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-10-02)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

  9. don-petry commented on Oct 9, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-10-09)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingcompliance-findingMachine-owned: created and auto-closed by the compliance audit. Do not hand-apply.dev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions