Skip to content

SonarCloud: misc cleanup (mixed findings) (×1) #343

Closed

Description

@don-petry

SonarCloud misc cleanup (small mixed findings)

SonarCloud open findings in petry-projects/TalkTerm — 1 issue(s) grouped as one workstream. Part of the org SonarCloud tuning initiative combsmith/.github#593.

Findings

Rule Count Representative message
githubactions:S1135 1 Complete the task associated to this "TODO" comment.

Affected files

  • .github/workflows/pr-auto-review.yml (1)

Approach

Small mixed leftover findings (incl. TODO-tag tracking S1135); apply each rule's suggested fix per its message, or resolve/ticket TODOs. Grouped to avoid single-finding issues.

Acceptance

  • All listed SonarCloud findings for this repo/workstream resolved to zero
  • No behavior change; existing tests/CI green
  • Fixes are real (no blanket NOSONAR unless a confirmed false positive, noted inline)

Filed from the 2026-07-03 org SonarCloud review.

Activity

  1. don-petry commented on Jul 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #343 — SonarCloud: misc cleanup (mixed findings) (×1)

    Scope

    Resolve the single SonarCloud finding githubactions:S1135 (TODO tracking) in .github/workflows/pr-auto-review.yml by completing/resolving the TODO on line 31.

    Analysis

    The TODO reads: # TODO: replace "CI" with your repository's CI workflow name(s).
    This repo's CI workflow is .github/workflows/ci.yml, whose name: is literally CI. Therefore the existing trigger workflows: ["CI"] is already correct for TalkTerm — the task the TODO describes is already satisfied. The fix is to remove the TODO tag and replace it with a plain descriptive comment (no behavior change).

    Implementation Checklist

    • .github/workflows/pr-auto-review.yml — replace the # TODO: comment (line 31) with a non-TODO descriptive comment confirming "CI" is this repo's CI workflow name

    Tests to Write

    • N/A — behavior-preserving change to a comment in a GitHub Actions workflow file. No test surface (TDD phase skipped per protocol exception for config/comment-only changes with no observable behavior change). Verification via lint + existing CI.

    Test Command

    npm test

  2. don-petry commented on Jul 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Analyzed githubactions:S1135 finding in .github/workflows/pr-auto-review.yml (line 31 TODO)
    • Confirmed this repo's CI workflow (.github/workflows/ci.yml) has name: CI, so the existing trigger workflows: ["CI"] is already correct — the TODO's task is satisfied
    • Replaced the # TODO: comment with a plain descriptive comment (resolves S1135, no behavior change)
    • Verified no other TODO markers remain in the file
    • Ran .dev-lead/scripts/dev-lead-lint.sh (shellcheck + CODEOWNERS) — passed
    • Validated YAML still parses and the trigger value is unchanged

    Test Results

    $ bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 3 file(s)...
      [lint] validating CODEOWNERS...
    OK: CODEOWNERS
      [lint] all checks passed
    
    $ python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr-auto-review.yml'))"
    YAML valid
    

    Note: repo has no package.json / JS test suite yet (planning/scaffolding stage), so npm test is not applicable. Change is a comment-only edit to a GitHub Actions workflow with no observable behavior change — TDD phase skipped per the protocol exception for config/comment-only changes.

    Files Changed

    • .github/workflows/pr-auto-review.yml: Replaced the S1135 TODO comment on line 31 with # "CI" is TalkTerm's CI workflow name (see .github/workflows/ci.yml). The trigger workflows: ["CI"] is unchanged and correct for this repo.

    Notes

    • No blanket NOSONAR used — this is a real resolution of the TODO.
    • The pre-existing NOSONAR(githubactions:S7637) on line 54 is a different rule not listed in this issue and was left untouched.
    • check_suite continues to handle third-party checks (e.g. SonarCloud), so listing only "CI" under workflow_run.workflows is correct.
  3. added a commit that references this issue on Jul 3, 2026
  4. added 3 commits that reference this issue on Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupenhancementFeature requests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions