Skip to content

Compliance: dev-lead-stub-agent-ref #273

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: error
Check: dev-lead-stub-agent-ref

Detail

The dev-lead.yml caller stub must pass with: agent_ref: dev-lead/stable so the reusable checks out its own scripts/prompts from the same channel. Re-sync from standards/workflows/dev-lead.yml.

Standard Reference

standards/ci-standards.md#dev-lead-agent

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Jun 19, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-06-19)

    This finding is still open.

    Detail: The dev-lead.yml caller stub must pass with: agent_ref: dev-lead/stable so the reusable checks out its own scripts/prompts from the same channel. Re-sync from standards/workflows/dev-lead.yml.

    Standard: standards/ci-standards.md#dev-lead-agent

  2. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 19, 2026
  3. don-petry commented on Jun 19, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #273 — Compliance: dev-lead-stub-agent-ref

    Scope

    Re-sync .github/workflows/dev-lead.yml from the canonical standards/workflows/dev-lead.yml so the caller stub pins the reusable to the dev-lead/stable channel and threads with: agent_ref: dev-lead/stable into the reusable workflow.

    Implementation Checklist

    • Replace .github/workflows/dev-lead.yml body with the canonical stub from petry-projects/.github/standards/workflows/dev-lead.yml
    • Change uses: from the pinned SHA @5a9a247... to @dev-lead/stable
    • Add with: agent_ref: dev-lead/stable
    • Sync surrounding comments (concurrency note, jobs rationale block, permissions)

    Tests to Write

    • N/A — pure CI-workflow/config change with no testable runtime behavior. TDD phase skipped per the documentation/config exception; verification is via YAML validity + dev-lead lint.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh (plus npm test for repo regression safety)

  4. don-petry commented on Jun 19, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Replaced .github/workflows/dev-lead.yml body with the canonical stub from petry-projects/.github/standards/workflows/dev-lead.yml
    • Changed uses: from the pinned SHA @5a9a247... to @dev-lead/stable
    • Added with: agent_ref: dev-lead/stable
    • Synced surrounding comments (concurrency note, jobs rationale block, permissions)

    Verification

    • Canonical parity: local stub is now byte-identical to standards/workflows/dev-lead.yml (diff clean).
    • YAML validity: yaml.safe_load parses without error.
    • Dev-lead lint: bash .dev-lead/scripts/dev-lead-lint.sh → all checks passed.
    • Repo test suite: N/A — no source tree, package.json, or other build manifest exists at the repo root yet (planning-stage repo), so there is no runtime test suite to run.

    Diff

    diff --git a/.github/workflows/dev-lead.yml b/.github/workflows/dev-lead.yml
    index fc2164b..9c236b6 100644
    --- a/.github/workflows/dev-lead.yml
    +++ b/.github/workflows/dev-lead.yml
    @@ -38,13 +38,19 @@ on:
     permissions: {}
     
     # Concurrency is centralised in the reusable workflow (dev-lead-reusable.yml) with
    -# per-issue / per-PR lanes (cancel-in-progress: false, so same-lane runs queue rather
    -# than overlap — preserving the dirty-checkout protection without cancelling issue
    -# pickups, the bug this repo previously hit). See petry-projects/.github#402.
    +# per-issue / per-PR lanes, so issue pickups are never cancelled by PR follow-up
    +# traffic and the grouping can't drift per-repo. See petry-projects/.github#402.
     
     jobs:
       dev-lead:
    -    uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@5a9a2476575cfcf0e730993f589587db054219f1 # main
    +    # Pinned to the moving dev-lead/stable channel tag, not @main, so a broken
    +    # change to dev-lead can no longer gate its own fix (the self-host circular
    +    # dependency). Promotion is done by moving the dev-lead/stable tag centrally; this
    +    # caller is never edited on release. agent_ref threads the same channel into
    +    # dev-lead's own scripts/prompts checkout. See ci-standards.md#dev-lead-agent.
    +    uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/stable
    +    with:
    +      agent_ref: dev-lead/stable
         secrets: inherit
         permissions:
           contents: write
    @@ -52,4 +58,4 @@ jobs:
           issues: write
           actions: read
           checks: read
    -      statuses: read   # required by dev-lead-reusable.yml since #435
    +      statuses: read

    Files Changed

    • .github/workflows/dev-lead.yml: pin the reusable to the moving @dev-lead/stable channel tag (was a @main-pinned SHA) and thread with: agent_ref: dev-lead/stable into the reusable so dev-lead checks out its own scripts/prompts from the same channel. Comments re-synced to match the standard.

    Notes

    TDD/test-first phase skipped per the documentation/config exception — this is a CI-workflow caller stub with no testable runtime behavior. Verification was via canonical byte-parity, YAML parse, and the required dev-lead lint gate.

  5. added 3 commits that reference this issue on Jun 20, 2026
  6. don-petry commented on Jun 26, 2026

    @don-petry
    ContributorAuthor

    Resolved! This check is now passing as of 2026-06-26. Closing automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions