You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run 26776727498 failed because a Dependabot pull_request event triggered the workflow. When Dependabot triggers pull_request, GitHub sets Secret source: Dependabot and org secrets (like GH_PAT_WORKFLOWS) are not available. The reusable workflow sets GH_TOKEN from that secret, so GH_TOKEN is empty, causing gh pr view to exit with code 4.
Scope
Add an if: github.actor != 'dependabot[bot]' guard on the pr-auto-review job so the workflow skips silently for Dependabot PRs (which are handled by dependabot-automerge.yml, not the AI review agent).
Implementation Checklist
.github/workflows/pr-auto-review.yml β add if: github.actor != 'dependabot[bot]' to the pr-auto-review job
Tests to Write
N/A β this is a pure CI configuration change with no application-code behaviour to unit-test. No automated test framework for GitHub Actions YAML exists in this repo. TDD phase skipped per exception: "For pure documentation, configuration, or behavior-preserving refactors with no observable behavioral change, skip this phase." The fix will be verified by the absence of future failures for Dependabot-triggered pull_request events.
Test Command
npm run lint && npm run typecheck (no workflow-file tests exist; application tests unchanged)
Add missing statuses: read permission to the pr-auto-review job in .github/workflows/pr-auto-review.yml, matching the fix already applied to dev-lead.yml in commit a414516.
Root Cause
The pr-auto-review-reusable.yml@v2 calls GitHub API endpoints that require statuses permission (added as a requirement in combsmith/.github#435). Because GitHub Actions reusable workflows cannot receive more permissions than the calling job, the missing statuses: read on the caller causes intermittent API failures β explaining the 11.5% failure rate (6/52 runs).
The same root cause was already diagnosed and fixed for dev-lead.yml in the most recent commit (a414516 fix(dev-lead): align to @main β drop broken concurrency + grant statuses:read (#248)).
Implementation Checklist
.github/workflows/pr-auto-review.yml β add statuses: read to the pr-auto-review job permissions block
Tests to Write
Exception: This is a pure CI configuration change. There is no application code or executable logic to unit-test. The fix is verified by the workflow running without failures after the permission is granted. No new test files are needed.
Identified root cause: missing statuses: read permission on the pr-auto-review job
Applied fix: added statuses: read to .github/workflows/pr-auto-review.yml
Ran bash ".dev-lead/scripts/dev-lead-lint.sh" β all checks passed
Rubber-duck reviewed the diff β one-line change, consistent with surrounding style
Root Cause
The pr-auto-review-reusable.yml@v2 calls GitHub API endpoints that require the statuses permission (introduced in combsmith/.github#435). GitHub Actions reusable workflows cannot be granted more permissions than the calling job, so the missing statuses: read on the caller caused intermittent API authorization failures β the direct explanation for the 11.5% failure rate (6/52 runs).
The identical root cause was diagnosed and fixed for dev-lead.yml in commit a414516 (fix(dev-lead): align to @main β drop broken concurrency + grant statuses:read (#248)).
Lint Results
[lint] shellcheck on 1 file(s)...
[lint] all checks passed
Files Changed
.github/workflows/pr-auto-review.yml: added statuses: read to the pr-auto-review job permissions block
Notes
TDD exception applied: pure CI configuration change with no executable application logic to unit-test. Correctness is validated by the workflow no longer failing after the permission is granted.
Activity
don-petry commentedon Jun 2, 2026
Dev-Lead Implementation Plan
Issue: #239 β [Fleet Monitor] petry-projects/TalkTerm β pr-auto-review.yml
Root Cause
Run 26776727498 failed because a Dependabot
pull_requestevent triggered the workflow. When Dependabot triggerspull_request, GitHub setsSecret source: Dependabotand org secrets (likeGH_PAT_WORKFLOWS) are not available. The reusable workflow setsGH_TOKENfrom that secret, soGH_TOKENis empty, causinggh pr viewto exit with code 4.Scope
Add an
if: github.actor != 'dependabot[bot]'guard on thepr-auto-reviewjob so the workflow skips silently for Dependabot PRs (which are handled bydependabot-automerge.yml, not the AI review agent).Implementation Checklist
.github/workflows/pr-auto-review.ymlβ addif: github.actor != 'dependabot[bot]'to thepr-auto-reviewjobTests to Write
N/A β this is a pure CI configuration change with no application-code behaviour to unit-test. No automated test framework for GitHub Actions YAML exists in this repo. TDD phase skipped per exception: "For pure documentation, configuration, or behavior-preserving refactors with no observable behavioral change, skip this phase." The fix will be verified by the absence of future failures for Dependabot-triggered
pull_requestevents.Test Command
npm run lint && npm run typecheck(no workflow-file tests exist; application tests unchanged)don-petry commentedon Jun 8, 2026
Dev-Lead Implementation Plan
Issue: #239 β [Fleet Monitor] petry-projects/TalkTerm β pr-auto-review.yml
Scope
Add missing
statuses: readpermission to thepr-auto-reviewjob in.github/workflows/pr-auto-review.yml, matching the fix already applied todev-lead.ymlin commit a414516.Root Cause
The
pr-auto-review-reusable.yml@v2calls GitHub API endpoints that requirestatusespermission (added as a requirement in combsmith/.github#435). Because GitHub Actions reusable workflows cannot receive more permissions than the calling job, the missingstatuses: readon the caller causes intermittent API failures β explaining the 11.5% failure rate (6/52 runs).The same root cause was already diagnosed and fixed for
dev-lead.ymlin the most recent commit (a414516 fix(dev-lead): align to @main β drop broken concurrency + grant statuses:read (#248)).Implementation Checklist
.github/workflows/pr-auto-review.ymlβ addstatuses: readto thepr-auto-reviewjob permissions blockTests to Write
Test Command
bash ".dev-lead/scripts/dev-lead-lint.sh"don-petry commentedon Jun 8, 2026
Dev-Lead: Implementation Complete
Plan Execution
statuses: readpermission on thepr-auto-reviewjobstatuses: readto.github/workflows/pr-auto-review.ymlbash ".dev-lead/scripts/dev-lead-lint.sh"β all checks passedRoot Cause
The
pr-auto-review-reusable.yml@v2calls GitHub API endpoints that require thestatusespermission (introduced in combsmith/.github#435). GitHub Actions reusable workflows cannot be granted more permissions than the calling job, so the missingstatuses: readon the caller caused intermittent API authorization failures β the direct explanation for the 11.5% failure rate (6/52 runs).The identical root cause was diagnosed and fixed for
dev-lead.ymlin commita414516(fix(dev-lead): align to @main β drop broken concurrency + grant statuses:read (#248)).Lint Results
Files Changed
.github/workflows/pr-auto-review.yml: addedstatuses: readto thepr-auto-reviewjob permissions blockNotes
TDD exception applied: pure CI configuration change with no executable application logic to unit-test. Correctness is validated by the workflow no longer failing after the permission is granted.
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
18 remaining items
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
chore: exclude dev-lead stub from SonarCloud (#482)
fix(sonar): suppress S7637 on stubs via rule, not exclusions (#482)
chore: repin dev-lead stub to the dev-lead/stable channel tag (#482) (#β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
chore: repin dev-lead stub to the dev-lead/stable channel tag (#482) (#β¦
feat: implement issue #454 β Compliance: ruleset-drift-pr-quality-reqβ¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦
chore: repin dev-lead stub to the dev-lead/stable channel tag (#482) (#β¦
feat: implement issue #239 β [Fleet Monitor] petry-projects/TalkTerm β¦