Skip to content

[Fleet Monitor] petry-projects/TalkTerm β€” copilot-setup-steps.ymlΒ #207

Closed

Description

@don-petry

🟠 DEGRADED: petry-projects/TalkTerm / copilot-setup-steps.yml

Metric Value
Failure Rate 42.9% (6 / 14 runs)
Status DEGRADED
p50 Duration 40s
p95 Duration 468s
Successful Runs 8
Cancelled Runs 0

Workflow: copilot-setup-steps.yml

Last updated by Fleet Monitor run on 2026-05-21.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    fleet-trackerTracked by the Actions Fleet Monitor
    health-checkAutomated health check result
    on May 21, 2026
  2. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 3, 2026
  3. don-petry commented on Jun 8, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #207 β€” [Fleet Monitor] petry-projects/TalkTerm β€” copilot-setup-steps.yml

    Root Cause Analysis

    Two bugs in the original feat/add-copilot-setup-steps branch caused 6 of 14 runs to fail:

    1. setup-node with cache: "npm" set but no lock file β€” actions/setup-node fails with "Dependencies lock file is not found" when cache: "npm" is configured but no package-lock.json / yarn.lock exists in the repo.
    2. npm ci running unconditionally β€” npm ci requires a lock file; without the if: hashFiles('package-lock.json') != '' guard it fails on repos without one.

    Both bugs were introduced during development on feat/add-copilot-setup-steps and fixed before the branch was merged to main. All 8 runs since the fix have succeeded.

    Scope

    Verify the current main workflow has both fixes, confirm no remaining risk, run lint, and close the issue.

    Implementation Checklist

    • Confirm cache: "npm" is absent from setup-node step in current workflow
    • Confirm if: hashFiles('package-lock.json') != '' guard is present on npm ci step
    • Run bash .dev-lead/scripts/dev-lead-lint.sh to verify lint passes
    • Perform rubber duck review of changed files (none expected β€” verifying existing fix)

    Tests to Write

    TDD Exception: This is a pure CI/workflow configuration fix. The failing behaviour (npm install aborting due to missing lock file) cannot be reproduced in a unit or integration test against workflow YAML. Confirming the fix is limited to reviewing the current workflow content and re-running the CI job.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh

  4. don-petry commented on Jun 8, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Root Cause

    Two bugs in the initial feat/add-copilot-setup-steps branch caused 6 of 14 runs to fail:

    1. setup-node with cache: "npm" and no lock file β€” actions/setup-node throws "Dependencies lock file is not found" when cache: "npm" is configured but no package-lock.json exists (this repo has no package.json yet).
    2. npm ci running unconditionally β€” npm ci requires a lock file; without a hashFiles guard it fails on repos that haven't initialised npm yet.

    Both were fixed before feat/add-copilot-setup-steps was merged to main.

    Plan Execution

    • Confirmed cache: "npm" is absent from setup-node step (line 73: explicitly omitted with comment)
    • Confirmed if: hashFiles('package-lock.json') != '' guard is present on npm ci step (line 81)
    • Ran bash .dev-lead/scripts/dev-lead-lint.sh β†’ all checks passed
    • Rubber duck review: no changes needed β€” fix already in place on main

    Test Results

      [lint] shellcheck on 1 file(s)...
      [lint] all checks passed
    

    All 8 workflow runs since the fix (2026-05-21 through 2026-06-08) have succeeded.

    Files Changed

    None β€” both fixes were already applied in the feat/add-copilot-setup-steps β†’ main merge. This issue required investigation and confirmation only.

    Notes

    • TDD exception applied: this is a pure CI configuration fix with no unit-testable behaviour.
    • actions/checkout has a Dependabot PR ready (v6.0.2 β†’ v6.0.3) β€” unrelated to these failures, tracked separately.
    • The workflow will continue to skip npm ci gracefully until package-lock.json is committed as part of npm project initialisation.
  5. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  6. don-petry commented on Jun 9, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #207 β€” [Fleet Monitor] petry-projects/TalkTerm β€” copilot-setup-steps.yml

    Investigation

    All 6 failures in the rolling window occurred on the same initial-setup branch (feat/add-copilot-setup-steps) on 2026-05-21:

    Run Failure
    4 runs setup-node with cache: "npm" failed: "Dependencies lock file is not found" (no package-lock.json yet)
    2 runs npm ci failed EUSAGE: package.json and package-lock.json out of sync during workflow iteration

    These root causes were already remediated in PR #205 (closed previous issue #198):

    • Switched the stack comment to Node.js / npm
    • Pinned actions/setup-node@v6.4.0, dropped cache: "npm" until a lockfile is committed
    • Added if: hashFiles('package-lock.json') != '' guard around npm ci

    Every run since 2026-05-21 12:19 has succeeded. The DEGRADED status reflects historical failures still in the Fleet Monitor's rolling window, not a current defect.

    Scope

    Align copilot-setup-steps.yml with the org canonical template at petry-projects/.github/standards/workflows/copilot-setup-steps.yml by hardening npm ci with --ignore-scripts. This is the only behavioural delta vs. the canonical for the Node.js stack block. It also triggers a fresh successful run on this PR, helping retire the historical failures from the rolling window.

    Implementation Checklist

    • Add a workflow assertion test under scripts/test-copilot-setup-steps-workflow.sh that fails until npm ci --ignore-scripts is present
    • Modify .github/workflows/copilot-setup-steps.yml: change run: npm ci β†’ run: npm ci --ignore-scripts

    Tests to Write

    • scripts/test-copilot-setup-steps-workflow.sh β€” grep-based assertion that npm ci is invoked with --ignore-scripts, runs yq/python3 YAML parse for syntax validity, exits non-zero if either check fails

    Test Command

    bash scripts/test-copilot-setup-steps-workflow.sh && bash .dev-lead/scripts/dev-lead-lint.sh

  7. 19 remaining items

  8. added 11 commits that reference this issue on Jun 23, 2026
  9. added 4 commits that reference this issue on Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupfleet-trackerTracked by the Actions Fleet Monitorhealth-checkAutomated health check result

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions