You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two bugs in the original feat/add-copilot-setup-steps branch caused 6 of 14 runs to fail:
setup-node with cache: "npm" set but no lock file β actions/setup-node fails with "Dependencies lock file is not found" when cache: "npm" is configured but no package-lock.json / yarn.lock exists in the repo.
npm ci running unconditionally β npm ci requires a lock file; without the if: hashFiles('package-lock.json') != '' guard it fails on repos without one.
Both bugs were introduced during development on feat/add-copilot-setup-steps and fixed before the branch was merged to main. All 8 runs since the fix have succeeded.
Scope
Verify the current main workflow has both fixes, confirm no remaining risk, run lint, and close the issue.
Implementation Checklist
Confirm cache: "npm" is absent from setup-node step in current workflow
Confirm if: hashFiles('package-lock.json') != '' guard is present on npm ci step
Run bash .dev-lead/scripts/dev-lead-lint.sh to verify lint passes
TDD Exception: This is a pure CI/workflow configuration fix. The failing behaviour (npm install aborting due to missing lock file) cannot be reproduced in a unit or integration test against workflow YAML. Confirming the fix is limited to reviewing the current workflow content and re-running the CI job.
Two bugs in the initial feat/add-copilot-setup-steps branch caused 6 of 14 runs to fail:
setup-node with cache: "npm" and no lock file β actions/setup-node throws "Dependencies lock file is not found" when cache: "npm" is configured but no package-lock.json exists (this repo has no package.json yet).
npm ci running unconditionally β npm ci requires a lock file; without a hashFiles guard it fails on repos that haven't initialised npm yet.
Both were fixed before feat/add-copilot-setup-steps was merged to main.
Plan Execution
Confirmed cache: "npm" is absent from setup-node step (line 73: explicitly omitted with comment)
Confirmed if: hashFiles('package-lock.json') != '' guard is present on npm ci step (line 81)
Ran bash .dev-lead/scripts/dev-lead-lint.sh β all checks passed
Rubber duck review: no changes needed β fix already in place on main
Test Results
[lint] shellcheck on 1 file(s)...
[lint] all checks passed
All 8 workflow runs since the fix (2026-05-21 through 2026-06-08) have succeeded.
Files Changed
None β both fixes were already applied in the feat/add-copilot-setup-steps β main merge. This issue required investigation and confirmation only.
Notes
TDD exception applied: this is a pure CI configuration fix with no unit-testable behaviour.
actions/checkout has a Dependabot PR ready (v6.0.2 β v6.0.3) β unrelated to these failures, tracked separately.
The workflow will continue to skip npm ci gracefully until package-lock.json is committed as part of npm project initialisation.
All 6 failures in the rolling window occurred on the same initial-setup branch (feat/add-copilot-setup-steps) on 2026-05-21:
Run
Failure
4 runs
setup-node with cache: "npm" failed: "Dependencies lock file is not found" (no package-lock.json yet)
2 runs
npm ci failed EUSAGE: package.json and package-lock.json out of sync during workflow iteration
These root causes were already remediated in PR #205 (closed previous issue #198):
Switched the stack comment to Node.js / npm
Pinned actions/setup-node@v6.4.0, dropped cache: "npm" until a lockfile is committed
Added if: hashFiles('package-lock.json') != '' guard around npm ci
Every run since 2026-05-21 12:19 has succeeded. The DEGRADED status reflects historical failures still in the Fleet Monitor's rolling window, not a current defect.
Scope
Align copilot-setup-steps.yml with the org canonical template at petry-projects/.github/standards/workflows/copilot-setup-steps.yml by hardening npm ci with --ignore-scripts. This is the only behavioural delta vs. the canonical for the Node.js stack block. It also triggers a fresh successful run on this PR, helping retire the historical failures from the rolling window.
Implementation Checklist
Add a workflow assertion test under scripts/test-copilot-setup-steps-workflow.sh that fails until npm ci --ignore-scripts is present
Modify .github/workflows/copilot-setup-steps.yml: change run: npm ci β run: npm ci --ignore-scripts
Tests to Write
scripts/test-copilot-setup-steps-workflow.sh β grep-based assertion that npm ci is invoked with --ignore-scripts, runs yq/python3 YAML parse for syntax validity, exits non-zero if either check fails
Activity
don-petry commentedon Jun 8, 2026
Dev-Lead Implementation Plan
Issue: #207 β [Fleet Monitor] petry-projects/TalkTerm β copilot-setup-steps.yml
Root Cause Analysis
Two bugs in the original
feat/add-copilot-setup-stepsbranch caused 6 of 14 runs to fail:setup-nodewithcache: "npm"set but no lock file βactions/setup-nodefails with "Dependencies lock file is not found" whencache: "npm"is configured but nopackage-lock.json/yarn.lockexists in the repo.npm cirunning unconditionally βnpm cirequires a lock file; without theif: hashFiles('package-lock.json') != ''guard it fails on repos without one.Both bugs were introduced during development on
feat/add-copilot-setup-stepsand fixed before the branch was merged tomain. All 8 runs since the fix have succeeded.Scope
Verify the current
mainworkflow has both fixes, confirm no remaining risk, run lint, and close the issue.Implementation Checklist
cache: "npm"is absent fromsetup-nodestep in current workflowif: hashFiles('package-lock.json') != ''guard is present onnpm cistepbash .dev-lead/scripts/dev-lead-lint.shto verify lint passesTests to Write
Test Command
bash .dev-lead/scripts/dev-lead-lint.shdon-petry commentedon Jun 8, 2026
Dev-Lead: Implementation Complete
Root Cause
Two bugs in the initial
feat/add-copilot-setup-stepsbranch caused 6 of 14 runs to fail:setup-nodewithcache: "npm"and no lock file βactions/setup-nodethrows "Dependencies lock file is not found" whencache: "npm"is configured but nopackage-lock.jsonexists (this repo has nopackage.jsonyet).npm cirunning unconditionally βnpm cirequires a lock file; without ahashFilesguard it fails on repos that haven't initialised npm yet.Both were fixed before
feat/add-copilot-setup-stepswas merged tomain.Plan Execution
cache: "npm"is absent fromsetup-nodestep (line 73: explicitly omitted with comment)if: hashFiles('package-lock.json') != ''guard is present onnpm cistep (line 81)bash .dev-lead/scripts/dev-lead-lint.shβ all checks passedmainTest Results
All 8 workflow runs since the fix (2026-05-21 through 2026-06-08) have succeeded.
Files Changed
None β both fixes were already applied in the
feat/add-copilot-setup-stepsβmainmerge. This issue required investigation and confirmation only.Notes
actions/checkouthas a Dependabot PR ready (v6.0.2βv6.0.3) β unrelated to these failures, tracked separately.npm cigracefully untilpackage-lock.jsonis committed as part of npm project initialisation.don-petry commentedon Jun 9, 2026
Dev-Lead Implementation Plan
Issue: #207 β [Fleet Monitor] petry-projects/TalkTerm β copilot-setup-steps.yml
Investigation
All 6 failures in the rolling window occurred on the same initial-setup branch (
feat/add-copilot-setup-steps) on 2026-05-21:setup-nodewithcache: "npm"failed: "Dependencies lock file is not found" (nopackage-lock.jsonyet)npm cifailed EUSAGE:package.jsonandpackage-lock.jsonout of sync during workflow iterationThese root causes were already remediated in PR #205 (closed previous issue #198):
actions/setup-node@v6.4.0, droppedcache: "npm"until a lockfile is committedif: hashFiles('package-lock.json') != ''guard aroundnpm ciEvery run since 2026-05-21 12:19 has succeeded. The DEGRADED status reflects historical failures still in the Fleet Monitor's rolling window, not a current defect.
Scope
Align
copilot-setup-steps.ymlwith the org canonical template atpetry-projects/.github/standards/workflows/copilot-setup-steps.ymlby hardeningnpm ciwith--ignore-scripts. This is the only behavioural delta vs. the canonical for the Node.js stack block. It also triggers a fresh successful run on this PR, helping retire the historical failures from the rolling window.Implementation Checklist
scripts/test-copilot-setup-steps-workflow.shthat fails untilnpm ci --ignore-scriptsis present.github/workflows/copilot-setup-steps.yml: changerun: npm ciβrun: npm ci --ignore-scriptsTests to Write
scripts/test-copilot-setup-steps-workflow.shβ grep-based assertion thatnpm ciis invoked with--ignore-scripts, runsyq/python3YAML parse for syntax validity, exits non-zero if either check failsTest Command
bash scripts/test-copilot-setup-steps-workflow.sh && bash .dev-lead/scripts/dev-lead-lint.sh19 remaining items
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #454 β Compliance: ruleset-drift-pr-quality-reqβ¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #207 β [Fleet Monitor] petry-projects/TalkTerm β¦