Skip to content

Mention stub template must grant contents:read - #778

Merged
don-petry merged 1 commit into
mainfrom
fix/persona-mention-template-contents-read
Jul 18, 2026
Merged

don-petry merged 1 commit into
mainfrom
fix/persona-mention-template-contents-read

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

The router reusable's job needs contents: read (to check out its tooling); the stub template granted only issues+pull-requests read, so every adopting repo would hit startup_failure — a reusable is granted no more than the caller (persona-standards §5, which this template violated).

Caught by the next-ring soak (combsmith/.github-private#1300/#1301). Companion to the .github-private adopted-stub fix.

🤖 Generated with Claude Code

The router reusable's job needs contents:read (to checkout its tooling); the stub
template granted only issues+pull-requests read, so every adopting repo would hit
startup_failure — a reusable is granted no more than the caller (persona-standards
§5, which this template violated). Caught by the next-ring soak
(combsmith/.github-private#1300/#1301). Companion to the .github-private
adopted-stub fix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 18, 2026 13:33
@don-petry
don-petry requested a review from a team as a code owner July 18, 2026 13:33
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8b292764-f3fa-4f08-8bf5-fc5bdbb3de92

📥 Commits

Reviewing files that changed from the base of the PR and between 1dd98b7 and b36b4a2.

📒 Files selected for processing (1)
  • standards/workflows/persona-mention.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/persona-mention-template-contents-read

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GitHub Actions workflow standards/workflows/persona-mention.yml to include the contents: read permission for the persona-mention job, which is required for the reusable workflow to check out its tooling repository. There are no review comments, and I have no additional feedback to provide.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the persona-mention workflow stub template to grant the minimal contents: read permission required by the downstream reusable workflow (so it can check out its tooling repo), preventing startup failures in adopting repositories.

Changes:

  • Add contents: read to the jobs.persona-mention.permissions block.
  • Document the rationale inline (reusable workflows cannot receive more permissions than the caller).

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 18, 2026 13:38

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: b36b4a2d0cd61697a34f263b20a9d5ee4d8f0e28
Review mode: triage-approved (single reviewer)

Summary

3-line permissions fix to the persona-mention stub template: adds contents: read to the caller job so the reusable router (whose route job needs contents: read for actions/checkout of its tooling repo) does not fail at startup in adopting repos. Verified against the reusable workflow source — the grant is required, minimal, and read-only. Triage assessment confirmed.

Linked issue analysis

No linked issues (closingIssuesReferences is empty). PR body references the next-ring soak findings in combsmith/.github-private#1300/#1301 (cross-repo context) and describes this as the companion to the .github-private adopted-stub fix; the change substantively matches that stated motivation.

Findings

  • Verified: the reusable's route job declares contents: read (checkout of tooling repo), issues: read, pull-requests: read — the stub previously granted only the latter two, violating the caller-must-grant rule (persona-standards §5) and causing startup_failure. Fix is exactly the missing grant, read-only, with inline rationale.
  • No security concerns: read-only permission addition to a template; no new write scopes, no secrets, no script changes.
  • Secret scan: gitleaks CI check passed. The run_secret_scanning MCP tool is not available in this environment (no finding fabricated).
  • Non-blocking observation: the stub pins @persona-mention/v1-stable, which does not exist yet as a tag or branch (only v1-next / v1.0.0). This is a pre-existing line outside this diff, consistent with the ring-promotion flow — flagging for awareness only.

CI status

All checks green: Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), CodeQL, SonarCloud (quality gate passed, 0 issues), AgentShield, dependency audits. Two dev-lead check runs show CANCELLED — a superseded duplicate dispatch; the surviving dev-lead run succeeded with status no-changes. mergeStateStatus BLOCKED reflects the pending required review (org-leads), not failing CI.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit c3cebd3 into main Jul 18, 2026
26 of 28 checks passed
@don-petry
don-petry deleted the fix/persona-mention-template-contents-read branch July 18, 2026 13:40

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: b36b4a2d0cd61697a34f263b20a9d5ee4d8f0e28
Review mode: triage-approved (single reviewer)

Summary

Confirmation review of a 3-line permissions fix: the persona-mention stub template now grants contents: read alongside issues: read and pull-requests: read. Verified against the reusable workflow source — its route job requires contents: read for actions/checkout of the tooling repo, and a reusable is granted no more than its caller, so the stub as previously written caused startup_failure in every adopting repo. The grant is required, minimal, and read-only. Triage assessment confirmed.

Linked issue analysis

No linked issues (closingIssuesReferences is empty). PR body cites the next-ring soak findings (combsmith/.github-private#1300/#1301) and describes this as the companion to the .github-private adopted-stub fix; the change substantively matches that stated motivation.

Findings

  • Verified against the reusable at its source of truth: the route job declares contents: read (checkout of tooling repo), issues: read, pull-requests: read. The stub previously granted only the latter two, violating persona-standards §5 (caller must grant at least what the reusable's jobs request). The fix adds exactly the missing grant, read-only, with inline rationale.
  • No security concerns: read-only permission addition to a template file; no new write scopes, no secrets, no script or logic changes.
  • Secret scan: gitleaks CI check passed. The run_secret_scanning MCP tool is not available in this environment (noted, not fabricated).
  • Non-blocking, pre-existing observation (carried from the prior review): the stub pins @persona-mention/v1-stable, which does not yet exist as a tag or branch (existing refs: v0.0.1–v0.0.7, v1-next, v1.0.0). Outside this diff; consistent with the ring-promotion flow.
  • Note: this PR already carries an approved pr-review-agent review at this same SHA; this run is a confirming re-review and reaches the same verdict.

CI status

All checks green: Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), CodeQL, SonarCloud (quality gate passed, 0 issues), AgentShield, dependency audits, CodeRabbit status SUCCESS. Two dev-lead check runs show CANCELLED — a superseded duplicate dispatch; the surviving dev-lead run succeeded (status no-changes). SKIPPED runs are conditional jobs not applicable to this change.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants