Repository navigation
chore: drop the transitional @v1/@v2 pin grace (#870) - #540
Conversation
The #482 migration added a transitional grace so the ring-aware audit and deploy sweep would accept a stub still on its pre-ring @v1/@v2 pin mid-migration. With #482 closed, a full-fleet scan confirms no consumer repo pins @v1/@v2 for any of the 7 ring reusables — the only two remaining (@v2 on .github's own dependabot-automerge/agent-shield dogfood callers) live in .github, which both consumers skip. The migration is complete, so the grace is now masking genuine drift. Remove @v1/@v2 from ring_accepted_refs; a stub on @v1/@v2/SHA/@main is now flagged. The higher-tier ring-channel grace is retained (a repo pinned above its tier, e.g. ring1 still on /stable, stays compliant so cut-release.sh promotions roll without the audit tripping mid-promotion). Centralized in ring-pins.sh, so this tightens BOTH the audit and the deploy sweep at once. Tests updated; full-fleet dry-run still reports 0 non-compliant. Refs #870
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 49 minutes and 2 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@donpetry-bot please review |
|
@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
There was a problem hiding this comment.
Code Review
This pull request removes the legacy pre-ring @v1 and @v2 migration grace channels from the accepted references list and updates the associated compliance and unit tests. The review feedback suggests addressing a duplication issue where the canonical reference is printed twice in ring_accepted_refs, and adding an explicit test assertion to verify that the canonical reference is correctly excluded from the ring_legacy_csv output.
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
10 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
26 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |



Summary
Final cleanup from the #482/#870 canary-ring migration: drop the transitional
@v1/@v2pin grace now that the fleet is fully on<name>/<tier>channels.The grace was added so the ring-aware audit/deploy wouldn't flag a stub still on its pre-ring
@v1/@v2pin mid-migration. A full-fleet scan now finds no consumer repo pinned@v1/@v2for any of the 7 ring reusables — the only two left (@v2on.github's owndependabot-automerge/agent-shielddogfood callers) live in.github, which both consumers skip. So the grace is no longer protecting anything; it's only masking genuine drift.Change
scripts/lib/ring-pins.sh— removev1/v2fromring_accepted_refs. A stub on@v1/@v2/SHA/@mainis now flagged./stable, or a/nextpin promoted toward/stable— stays compliant, socut-release.shpromotions roll without the audit tripping mid-promotion).compliance-audit.shanddeploy-standard-workflows.shat once.Verification
shellcheck --severity=warningclean.@v1/@v2cases now assert rejection.deploy --dry-run= 0 non-compliant (no repo flagged by the drop).Refs #870
🤖 Generated with Claude Code