Skip to content

fix: deploy the persona mention router to combsmith/.github itself - #1427

Merged
don-petry merged 1 commit into
mainfrom
fix/add-persona-mention-router
Oct 29, 2026
Merged

don-petry merged 1 commit into
mainfrom
fix/add-persona-mention-router

Conversation

@don-petry

@don-petry don-petry commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem

@combsmith/<persona> mentions on issues and PRs in this repo are never routed. combsmith/.github hosts persona-mention-reusable.yml and is listed as the ring0 member for persona-mention in standards/canary-rings.json, but the caller workflow .github/workflows/persona-mention.yml was never added here. Without it, comments in this repo never trigger the router.

For example, the @combsmith/solution-architect mention on #1410 (2026-10-28 11:52 UTC) never got a reply. The same mention works in any repo that has the caller workflow, such as empower-personal-dashboard and .github-private.

Change

Adds .github/workflows/persona-mention.yml, copied from standards/workflows/persona-mention.yml with two changes:

The diff from the template is only those two lines. Under scripts/lib/stub-verbatim.sh this file is checked only on its uses: pin, so keeping the ring channel is allowed.

Test plan

Rollback

Delete the file. Nothing else depends on it.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

combsmith/.github hosts persona-mention-reusable.yml and is registered as
the RING0 member for persona-mention in standards/canary-rings.json, but it
never carried the caller stub. So `@combsmith/<persona>` mentions on this
repo's issues and PRs are never routed. Example: the solution-architect
mention on #1410 (2026-10-28) got no response.

Add the standard stub from standards/workflows/persona-mention.yml, pinned
to the ring0 channel `persona-mention/v1-ring0` (like feature-ideation.yml
here), with the header naming that channel so header and pin agree (#1297).
The stub is pin-managed (scripts/lib/stub-verbatim.sh), so only the `uses:`
pin is compared and the ring tier is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 29, 2026 01:28
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7e9c6434-1bed-426b-b96f-0671f65b9c18
Commits

Reviewing files that changed from the base of the PR and between bcdb2b8 and e07ad58.

Files selected for processing: 1
  • .github/workflows/persona-mention.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T01:29:36.742122Z e07ad58 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1427
No changes were committed, but the PR still can't be marked done: required check SonarCloud is still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-10-29T01:59:15Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check SonarCloud is still pending. I'll re-check automatically.
Next attempt after: 2026-10-29T01:59:15Z

@don-petry
don-petry enabled auto-merge (squash) October 29, 2026 01:29
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-29T02:30:05Z.

@don-petry
don-petry merged commit 9a3aa4a into main Oct 29, 2026
39 checks passed
@don-petry
don-petry deleted the fix/add-persona-mention-router branch October 29, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants