Repository navigation
feat: implement issue #1210 — [Phase 2] Switch feature-ideation-reusable.yml model default to the opus family and verify alias resolution #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
don-petry
wants to merge
17
commits into
main
Choose a base branch
from
dev-lead/issue-1210-20261003-2213
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a0d9fd4
feat: implement issue #1210 — [Phase 2] Switch feature-ideation-reusa…
don-petry 1f3e96d
fix(reviews): restore sonnet/haiku in model description; harden model…
don-petry 2422ce9
fix(bot): install yq in feature-ideation test environment
don-petry 83ab2dd
fix(bot): pin mikefarah/yq to v4.44.3 in feature-ideation-tests
don-petry 04b71b9
fix(reviews): hardcode yq sha256 and add curl timeouts
don-petry 856d052
fix(reviews): align model input description with #1210 AC2 exact wording
don-petry 03f0041
fix(reviews): add final period to model input description per #1210 AC2
don-petry be5e8a8
fix(bot): record claude-code-action v1.0.259 model resolution for opu…
don-petry a8c2eab
fix(bot): update claude-code-action version in model resolution comme…
don-petry 792dfcf
fix(bot): clarify model input description and update test
don-petry 680bcb9
fix(bot): Add final periods and clarify model resolution guidance
don-petry 6481a89
fix(bot): Reformat model description to comply with line-length lint …
don-petry f6f7edb
fix(bot): update model resolution comment to reflect current claude-c…
don-petry 834fad1
fix(reviews): add retry flags to pinned-yq curl
don-petry 36ca692
fix(reviews): drop duplicate yq install; make model-resolution commen…
don-petry a319c25
fix(bot): correct step name to match what is actually installed
don-petry d0f21c3
Merge branch 'main' into dev-lead/issue-1210-20261003-2213
don-petry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #!/usr/bin/env bats | ||
| # Tests for the `model` input of the reusable feature-ideation workflow | ||
| # (issue #1210). The default must be the model FAMILY (`opus`) so the BMAD | ||
| # Analyst auto-tracks the current Opus via the Claude Code CLI's client-side | ||
| # alias resolution — a pinned version id must never be the default. | ||
|
|
||
| load 'helpers/setup' | ||
|
|
||
| WF="${TT_REPO_ROOT}/.github/workflows/feature-ideation-reusable.yml" | ||
|
|
||
| @test "model input: default is the opus family" { | ||
| run yq -r '.on.workflow_call.inputs.model.default' "$WF" | ||
| [ "$status" -eq 0 ] | ||
| [ "$output" = "opus" ] | ||
| } | ||
|
|
||
| @test "model input: default is not a pinned claude-* version id" { | ||
| run yq -r '.on.workflow_call.inputs.model.default' "$WF" | ||
| [ "$status" -eq 0 ] | ||
| [[ "$output" != claude-* ]] | ||
| } | ||
|
|
||
| @test "model input: description recommends the opus family with an id override" { | ||
| run yq -r '.on.workflow_call.inputs.model.description' "$WF" | ||
| [ "$status" -eq 0 ] | ||
| [ "$output" = 'Model family (`opus` recommended — Sonnet produces shallower adversarial passes) or an explicit model ID. Client-side resolution by the Claude Code CLI; never pin a version-specific model ID.' ] | ||
| } | ||
|
|
||
| @test "analyst step: model is passed via --model so the CLI resolves the family" { | ||
| run yq -r '.jobs[].steps[]? | select(.name == "Run Claude Code — BMAD Analyst") | .with.claude_args' "$WF" | ||
| [ "$status" -eq 0 ] | ||
| [[ "$output" == *'--model ${{ inputs.model }}'* ]] | ||
| } | ||
|
|
||
| @test "analyst step: no ANTHROPIC_MODEL env bypasses the CLI's alias resolver" { | ||
| run yq -r '.jobs[].steps[]? | select(.name == "Run Claude Code — BMAD Analyst") | .env // {} | has("ANTHROPIC_MODEL")' "$WF" | ||
|
don-petry marked this conversation as resolved.
Resolved
|
||
| [ "$status" -eq 0 ] | ||
| [ "$output" = "false" ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.