Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a0d9fd4
feat: implement issue #1210 — [Phase 2] Switch feature-ideation-reusa…
don-petry Oct 3, 2026
1f3e96d
fix(reviews): restore sonnet/haiku in model description; harden model…
don-petry Oct 3, 2026
2422ce9
fix(bot): install yq in feature-ideation test environment
don-petry Oct 4, 2026
83ab2dd
fix(bot): pin mikefarah/yq to v4.44.3 in feature-ideation-tests
don-petry Oct 6, 2026
04b71b9
fix(reviews): hardcode yq sha256 and add curl timeouts
don-petry Oct 6, 2026
856d052
fix(reviews): align model input description with #1210 AC2 exact wording
don-petry Oct 9, 2026
03f0041
fix(reviews): add final period to model input description per #1210 AC2
don-petry Oct 9, 2026
be5e8a8
fix(bot): record claude-code-action v1.0.259 model resolution for opu…
don-petry Oct 30, 2026
a8c2eab
fix(bot): update claude-code-action version in model resolution comme…
don-petry Nov 3, 2026
792dfcf
fix(bot): clarify model input description and update test
don-petry Nov 5, 2026
680bcb9
fix(bot): Add final periods and clarify model resolution guidance
don-petry Nov 9, 2026
6481a89
fix(bot): Reformat model description to comply with line-length lint …
don-petry Nov 9, 2026
f6f7edb
fix(bot): update model resolution comment to reflect current claude-c…
don-petry Nov 10, 2026
834fad1
fix(reviews): add retry flags to pinned-yq curl
don-petry Nov 12, 2026
36ca692
fix(reviews): drop duplicate yq install; make model-resolution commen…
don-petry Nov 12, 2026
a319c25
fix(bot): correct step name to match what is actually installed
don-petry Nov 13, 2026
d0f21c3
Merge branch 'main' into dev-lead/issue-1210-20261003-2213
don-petry Nov 17, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/feature-ideation-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,13 @@ on:
default: 'standard'
type: string
model:
description: >
Model family — `opus` (default, recommended), `sonnet`, or `haiku`.
The resolver/CLI maps the family to the current version ID. An
operator MAY override with a concrete model ID for a one-off pin.
# The Claude Code CLI resolves the family client-side (`--model opus`
# in the analyst step) to the current version ID — never pin a
# version ID here. See standards/agent-standards.md.
description: >-
Model family (`opus` recommended — Sonnet produces shallower adversarial
passes) or an explicit model ID. Client-side resolution by the Claude Code
CLI; never pin a version-specific model ID.
required: false
default: 'opus'
type: string
Expand Down Expand Up @@ -332,6 +335,8 @@ jobs:
ENHANCE_BACKLOG: ${{ inputs.enhance_backlog && '1' || '0' }}
SOURCES_FILE_PATH: ${{ inputs.sources_file }}
RESEARCH_DEPTH: ${{ inputs.research_depth }}
# Model family resolution: `--model` is passed through to the Claude
# CLI, which resolves the family alias (#1210 AC3).
uses: anthropics/claude-code-action@4fa93a88de49bbef68b10eb15aabedf28ca0e1ed # v1.0.271
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/feature-ideation-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ jobs:
tmp="$(mktemp -d)"
# --proto '=https' --proto-redir '=https' enforces HTTPS on both the
# initial request and any redirect -L follows (SonarCloud S6506, #1360).
curl -sL --proto '=https' --proto-redir '=https' -o "${tmp}/yq" \
# Same retry/timeout flags as the install step above (#739).
curl -sSfL --proto '=https' --proto-redir '=https' --connect-timeout 10 --max-time 60 \
--retry 5 --retry-delay 2 --retry-connrefused --retry-all-errors -o "${tmp}/yq" \
"https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_amd64"
echo "${YQ_SHA256} ${tmp}/yq" | sha256sum -c -
sudo install -m 0755 "${tmp}/yq" /usr/local/bin/yq
Expand Down
39 changes: 39 additions & 0 deletions test/workflows/feature-ideation/model-input.bats
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
#!/usr/bin/env bats
# Tests for the `model` input of the reusable feature-ideation workflow
# (issue #1210). The default must be the model FAMILY (`opus`) so the BMAD
# Analyst auto-tracks the current Opus via the Claude Code CLI's client-side
# alias resolution — a pinned version id must never be the default.

load 'helpers/setup'

WF="${TT_REPO_ROOT}/.github/workflows/feature-ideation-reusable.yml"

@test "model input: default is the opus family" {
run yq -r '.on.workflow_call.inputs.model.default' "$WF"
Comment thread
don-petry marked this conversation as resolved.
Resolved
[ "$status" -eq 0 ]
[ "$output" = "opus" ]
}

@test "model input: default is not a pinned claude-* version id" {
run yq -r '.on.workflow_call.inputs.model.default' "$WF"
[ "$status" -eq 0 ]
[[ "$output" != claude-* ]]
}

@test "model input: description recommends the opus family with an id override" {
run yq -r '.on.workflow_call.inputs.model.description' "$WF"
[ "$status" -eq 0 ]
[ "$output" = 'Model family (`opus` recommended — Sonnet produces shallower adversarial passes) or an explicit model ID. Client-side resolution by the Claude Code CLI; never pin a version-specific model ID.' ]
}

@test "analyst step: model is passed via --model so the CLI resolves the family" {
run yq -r '.jobs[].steps[]? | select(.name == "Run Claude Code — BMAD Analyst") | .with.claude_args' "$WF"
[ "$status" -eq 0 ]
[[ "$output" == *'--model ${{ inputs.model }}'* ]]
}

@test "analyst step: no ANTHROPIC_MODEL env bypasses the CLI's alias resolver" {
run yq -r '.jobs[].steps[]? | select(.name == "Run Claude Code — BMAD Analyst") | .env // {} | has("ANTHROPIC_MODEL")' "$WF"
Comment thread
don-petry marked this conversation as resolved.
Resolved
[ "$status" -eq 0 ]
[ "$output" = "false" ]
}
Loading