You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exempt repo-template from the feature-ideation-placeholder-context check in scripts/compliance-audit.sh (a template repo is expected to hold the placeholder). Add a bats case asserting repo-template does NOT get the finding while a normal repo still does.
Audit run on repo-template produces nofeature-ideation-placeholder-context finding; a non-template repo on the placeholder still does (bats-covered).
standards/ci-standards.md (or the deploy script header) documents the SKIP_REPOS opt-in pattern.
No repo is simultaneously flagged required-but-missing AND intentionally exempt without a SKIP_OVERRIDES opt-in (audit + deploy config are consistent; bats-covered).
Exempt repo-template from the feature-ideation-placeholder-context audit finding (its seed placeholder is intentional), and codify the SKIP_REPOS → SKIP_OVERRIDES opt-in as the canonical way a self-managing meta-repo satisfies a universal-required workflow, with a static consistency guard so no SKIP_REPO is left required-but-unreconciled.
Implementation Checklist
scripts/compliance-audit.sh: add pure feature_ideation_placeholder_exempt + feature_ideation_should_flag_placeholder helpers; wire the exemption into check_required_workflows so repo-template is skipped.
scripts/deploy-standard-workflows.sh: add SKIP_SELF_MANAGED declaration + is_deployable_workflow, skip_repo_self_manages, and reconcile_skip_repo_required_workflows (pure, takes the required-workflow list as args) so every required+deployable workflow on a SKIP_REPO has a reconciliation path (opt-in or self-managed).
standards/ci-standards.md: document the SKIP_REPOS opt-in / self-manage reconciliation pattern under "Deploying & syncing stubs".
Tests to Write
test/scripts/compliance-audit/feature-ideation-placeholder-context.bats: repo-template on the placeholder is NOT flagged; a normal repo on the same placeholder still IS.
test/scripts/deploy-standard-workflows/skip-repo-required-reconcile.bats: reconcile passes on the shipped config; every required+deployable workflow is reconciled per SKIP_REPO; a synthesized gap (dropping an opt-in/self-manage entry) fails.
TDD: bats cases written first (red), then implementation (green)
Full suite + dev-lead-lint.sh + shellcheck green
Test Results
ok 718 guard: still fires on an @donpetry-bot mention
ok 719 guard: still gates comment events on trusted author_association
ok 720 guard: still fires when donpetry-bot is assigned as reviewer
ok 721 install: the tests workflow exists
ok 722 install: every curl download uses bounded retries
ok 723 reusable: 'Check commenter trust level' GH_TOKEN uses the canonical fallback
ok 724 reusable: 'Resolve PR URL' GH_TOKEN uses the canonical fallback
ok 725 reusable: 'Trigger review agent' GH_TOKEN uses the canonical fallback
ok 726 stub: GH_PAT_WORKFLOWS input uses the GH_PAT_DON_PETRY || GH_PAT_WORKFLOWS fallback
ok 727 stub: retains DON_PETRY_BOT_GH_PAT (required by the reusable's ack step)
ok 728 stub: uses an explicit secrets mapping, not bare 'inherit'
ok 729 reusable: declares GH_PAT_WORKFLOWS and DON_PETRY_BOT_GH_PAT as required
...
ok: 729 not ok: 0 (full test/ tree)
scripts/compliance-audit.sh: added pure feature_ideation_should_flag_placeholder + feature_ideation_placeholder_exempt helpers; check_required_workflows now skips the placeholder finding for repo-template (its seed placeholder is intentional) while every non-template repo on the same placeholder is still flagged.
scripts/deploy-standard-workflows.sh: added SKIP_SELF_MANAGED map + is_deployable_workflow, skip_repo_self_manages, and the pure reconcile_skip_repo_required_workflows guard — every required-and-deployable workflow on a SKIP_REPO must be reconciled via a SKIP_OVERRIDES opt-in OR a self-manage declaration, else the guard (and its bats suite) fails. Refactored the entrypoint into a source-guarded main/parse_args so the pure functions are unit-testable (mirrors compliance-audit.sh).
standards/ci-standards.md: new "Self-managing meta-repos: SKIP_REPOS + SKIP_OVERRIDES" subsection documenting the two canonical reconciliation paths and the guard.
test/scripts/compliance-audit/feature-ideation-placeholder-context.bats: repo-template exemption cases (exempt repo NOT flagged; non-template on same placeholder still flagged).
test/scripts/deploy-standard-workflows/skip-repo-required-reconcile.bats (new): wires the real audit REQUIRED_WORKFLOWS to the real deploy config and asserts the shipped config reconciles cleanly, that dropping an opt-in or a self-manage entry surfaces a gap, and that manual-only required workflows (ci.yml/sonarcloud.yml) are excluded.
Acceptance Criteria
Audit on repo-template produces nofeature-ideation-placeholder-context finding; a non-template repo on the placeholder still does (bats-covered).
standards/ci-standards.md documents the SKIP_REPOS opt-in pattern.
No repo is simultaneously required-but-missing AND intentionally exempt without a SKIP_OVERRIDES opt-in — audit + deploy config are consistent, enforced by reconcile_skip_repo_required_workflows (bats-covered).
compliance-audit bats suite green.
Notes
The entrypoint refactor (top-level exec → source-guarded main) was required so the deploy script's pure helpers can be sourced by bats without executing the deploy sweep — the audit script already used this pattern. Because the audit and deploy scripts both source lib/ring-pins.sh (readonly vars), the reconcile test reads REQUIRED_WORKFLOWS from the audit in a separate subshell rather than sourcing both at once.
Activity
don-petry commentedon Jul 21, 2026
Dev-Lead Implementation Plan
Issue: #856 — [#850 D] Codify SKIP_REPOS opt-in + exempt repo-template from feature-ideation placeholder check
Scope
Exempt
repo-templatefrom thefeature-ideation-placeholder-contextaudit finding (its seed placeholder is intentional), and codify the SKIP_REPOS → SKIP_OVERRIDES opt-in as the canonical way a self-managing meta-repo satisfies a universal-required workflow, with a static consistency guard so no SKIP_REPO is left required-but-unreconciled.Implementation Checklist
scripts/compliance-audit.sh: add purefeature_ideation_placeholder_exempt+feature_ideation_should_flag_placeholderhelpers; wire the exemption intocheck_required_workflowssorepo-templateis skipped.scripts/deploy-standard-workflows.sh: addSKIP_SELF_MANAGEDdeclaration +is_deployable_workflow,skip_repo_self_manages, andreconcile_skip_repo_required_workflows(pure, takes the required-workflow list as args) so every required+deployable workflow on a SKIP_REPO has a reconciliation path (opt-in or self-managed).standards/ci-standards.md: document the SKIP_REPOS opt-in / self-manage reconciliation pattern under "Deploying & syncing stubs".Tests to Write
test/scripts/compliance-audit/feature-ideation-placeholder-context.bats: repo-template on the placeholder is NOT flagged; a normal repo on the same placeholder still IS.test/scripts/deploy-standard-workflows/skip-repo-required-reconcile.bats: reconcile passes on the shipped config; every required+deployable workflow is reconciled per SKIP_REPO; a synthesized gap (dropping an opt-in/self-manage entry) fails.Test Command
bats --print-output-on-failure test/scripts/compliance-audit/ test/scripts/deploy-standard-workflows/don-petry commentedon Jul 21, 2026
Dev-Lead: Implementation Complete
Plan Execution
repo-templatefrom thefeature-ideation-placeholder-contextcheck (scripts/compliance-audit.sh)scripts/deploy-standard-workflows.sh)standards/ci-standards.mddev-lead-lint.sh+ shellcheck greenTest Results
test/scripts/compliance-audit/— 173/173 passtest/scripts/deploy-standard-workflows/+ shared libs — 55/55 passbash .dev-lead/scripts/dev-lead-lint.sh— all checks passed (shellcheck 27 files + profile validation)Files Changed
scripts/compliance-audit.sh: added purefeature_ideation_should_flag_placeholder+feature_ideation_placeholder_exempthelpers;check_required_workflowsnow skips the placeholder finding forrepo-template(its seed placeholder is intentional) while every non-template repo on the same placeholder is still flagged.scripts/deploy-standard-workflows.sh: addedSKIP_SELF_MANAGEDmap +is_deployable_workflow,skip_repo_self_manages, and the purereconcile_skip_repo_required_workflowsguard — every required-and-deployable workflow on a SKIP_REPO must be reconciled via a SKIP_OVERRIDES opt-in OR a self-manage declaration, else the guard (and its bats suite) fails. Refactored the entrypoint into a source-guardedmain/parse_argsso the pure functions are unit-testable (mirrors compliance-audit.sh).standards/ci-standards.md: new "Self-managing meta-repos: SKIP_REPOS + SKIP_OVERRIDES" subsection documenting the two canonical reconciliation paths and the guard.test/scripts/compliance-audit/feature-ideation-placeholder-context.bats: repo-template exemption cases (exempt repo NOT flagged; non-template on same placeholder still flagged).test/scripts/deploy-standard-workflows/skip-repo-required-reconcile.bats(new): wires the real auditREQUIRED_WORKFLOWSto the real deploy config and asserts the shipped config reconciles cleanly, that dropping an opt-in or a self-manage entry surfaces a gap, and that manual-only required workflows (ci.yml/sonarcloud.yml) are excluded.Acceptance Criteria
repo-templateproduces nofeature-ideation-placeholder-contextfinding; a non-template repo on the placeholder still does (bats-covered).standards/ci-standards.mddocuments the SKIP_REPOS opt-in pattern.reconcile_skip_repo_required_workflows(bats-covered).Notes
The entrypoint refactor (top-level exec → source-guarded
main) was required so the deploy script's pure helpers can be sourced by bats without executing the deploy sweep — the audit script already used this pattern. Because the audit and deploy scripts bothsource lib/ring-pins.sh(readonly vars), the reconcile test readsREQUIRED_WORKFLOWSfrom the audit in a separate subshell rather than sourcing both at once.feat: implement issue #856 — [#850 D] Codify SKIP_REPOS opt-in + exem…