Skip to content

canary-rollout: autocut silently broken after #613 relocation — execs cut-release.sh (left in .github-private) #633

Closed

Description

@don-petry

Symptom

After the canary-rollout engine relocated to .github (#613, PRs #624/#628), autocut (#1069 — the front end that cuts a new candidate when a reusable changes on main) can no longer cut anything.

scripts/canary-rollout.sh execs the cut via:

CUT_RELEASE="${CUT_RELEASE:-${_HERE}/cut-release.sh}"
...
bash "$CUT_RELEASE" "$agent" "$newver" --ref "$mainsha" --channel next --push

But cut-release.sh was not in #613's move scope — it stayed in .github-private as the human/runbook CLI. So ${_HERE}/cut-release.sh = .github/scripts/cut-release.sh does not exist. The invocation is best-effort (|| echo warning), so the scheduled run stays green while no candidate is ever cut — the last manual seam (#1069) silently reopens.

Latent right now only because every registered reusable is currently "unchanged" (detection works — it reads the host from the registry). The next reusable change on any host would hit it. CANARY_AUTO_CUT=true is live.

Second, latent defect

Even if cut-release.sh were present, its this_repo() resolves this-repo agents (dev-lead) to GITHUB_REPOSITORY, which is now petry-projects/.github. dev-lead's reusable lives in .github-private — so an autocut cut for dev-lead would target the wrong host.

Fix

Make the engine self-contained: cut inline via the App-token gh-api path (_gh_create_annotated_tag + the existing _gh_move_tag) against the agent's registry host (already resolved correctly in _autocut_agent). No dependency on a script left in another repo; correct host for every agent incl. dev-lead. Mirrors the engine's existing pattern (it already carries _gh_move_tag/_gh_tag_commit "mirroring cut-release.sh"). cut-release.sh stays put in .github-private as the manual CLI.

Related: #613 (relocation), #1069 (autocut), #1076 (unified gh-api tag moves).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBug reports

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions