Skip to content

SonarCloud: resolve remaining S7635 secrets-inherit stubs (×18) #600

Closed

Description

@don-petry

SonarCloud S7635 (secrets: inherit) — resolve remaining caller stubs (×18)

18 open githubactions:S7635 findings remain across caller-workflow stubs. Canonical fix = inline # NOSONAR(githubactions:S7635) marker on the secrets: inherit line (see the S7635-gap playbook + in-flight ring/marker PRs, e.g. bmad #341). This tracks closing out the remaining stubs to zero — coordinate with in-flight ring/marker PRs to avoid conflicts.

Remaining by repo

  • petry-projects/markets — 5
  • petry-projects/broodminder-export — 4
  • petry-projects/repo-template — 4
  • petry-projects/bmad-bgreat-suite — 3
  • petry-projects/TalkTerm — 2

repo-template (×4) is highest-leverage: the template itself leaks the pattern, so every generated repo inherits S7635. Fix the template first.

Acceptance

  • githubactions:S7635 open count org-wide = 0
  • repo-template no longer emits S7635 (new repos start clean)
  • No conflict with in-flight ring/marker PRs

Part of #593. Filed from the 2026-07-03 org SonarCloud review.

Activity

  1. don-petry commented on Oct 21, 2026

    @don-petry
    ContributorAuthor

    Closing after the 2026-10-21 backlog triage.

    Why: No longer reproduces: 0 open githubactions:S7635 org-wide.
    Evidence: SonarCloud API issues/search rules=githubactions:S7635 total=0 (2026-10-21)

    Reopen if this still reproduces on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupenhancementFeature requestssecuritySecurity-related PRs and issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions