Skip to content

[Fleet Monitor] petry-projects/.github β€” pr-review-mention.ymlΒ #331

Closed

Description

@don-petry

🟑 WARNING: petry-projects/.github / pr-review-mention.yml

Metric Value
Failure Rate 16.7% (8 / 48 runs)
Status WARNING
p50 Duration 1s
p95 Duration 11s
Successful Runs 0
Cancelled Runs 0

Workflow: pr-review-mention.yml

Last updated by Fleet Monitor run on 2026-06-10.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 8, 2026
  2. don-petry commented on Jun 9, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #331 β€” [Fleet Monitor] petry-projects/.github β€” pr-review-mention.yml

    Root Cause

    Inspected failing runs 27174214611 and 27174211896 (the only 2 failures in the
    last 200 runs). Both fail at the "Post acknowledgement comment" step with:

    GraphQL: was submitted too quickly (addComment)
    ##[error]Process completed with exit code 1.
    

    This is GitHub's secondary anti-spam rate limit on addComment. When many
    @donpetry-bot mentions arrive within a short window (which happens during
    batched compliance / fanout activity), back-to-back invocations of gh pr comment get throttled. The Fleet Monitor's 33% reflects a tight rolling window
    that captured 9 such bursts.

    The downstream Trigger review agent step never runs because the failed
    comment step aborts the job β€” so a transient rate-limit on a courtesy ack
    silently kills the real dispatch.

    Scope

    Make the ack-comment step resilient to secondary rate limits: retry with
    jittered exponential backoff; if exhausted, log a WARN and continue so the
    dispatch step still runs. Non-rate-limit errors continue to fail loud (per
    AGENTS.md "Fail Loud, Never Fake" β€” disclosed fallback only).

    Implementation Checklist

    • .github/scripts/pr-review-mention/post-ack-comment.sh β€” new script
      encapsulating retry + non-fatal-on-rate-limit logic
    • .github/workflows/pr-review-mention-reusable.yml β€” checkout the
      tooling, call the new script from the "Post acknowledgement comment"
      step (mirrors the feature-ideation-reusable pattern with a
      tooling_ref input)
    • standards/workflows/pr-review-mention.yml β€” pass through the new
      optional tooling_ref input (default v1) so caller stubs don't need
      to change
    • .github/workflows/pr-review-mention-tests.yml β€” new CI workflow:
      shellcheck + bats, scoped to the new paths

    Tests to Write

    • test/workflows/pr-review-mention/post-ack-comment.bats
      • Success on first try β†’ exit 0, single gh invocation
      • Rate-limit on first try, success on retry β†’ exit 0, β‰₯ 2 invocations,
        "retrying" log
      • Rate-limit on every attempt β†’ exit 0 (non-fatal),
        WARN: ack comment skipped log, no further attempts after max
      • Non-rate-limit error (e.g., 404) β†’ exit non-zero, single attempt
      • Empty PR_URL β†’ exit non-zero (fail fast at boundary)
    • test/workflows/pr-review-mention/helpers/setup.bash β€” modeled on
      test/workflows/feature-ideation/helpers/setup.bash
    • test/workflows/pr-review-mention/stubs/gh β€” re-use the
      multi-call-capable stub from feature-ideation

    Test Command

    bats --print-output-on-failure test/workflows/pr-review-mention/

  3. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  4. don-petry commented on Jul 15, 2026

    @don-petry
    ContributorAuthor

    βœ… Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-06-10 (35 days) β€” the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions