Skip to content

[Fleet Monitor] petry-projects/.github β€” ci.ymlΒ #329

Closed

Description

@github-actions

🟠 DEGRADED: petry-projects/.github / ci.yml

Metric Value
Failure Rate 26.6% (64 / 241 runs)
Status DEGRADED
p50 Duration 184s
p95 Duration 390s
Successful Runs 175
Cancelled Runs 2

Workflow: ci.yml

Last updated by Fleet Monitor run on 2026-06-09.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 8, 2026
  2. don-petry commented on Jun 9, 2026

    @don-petry
    Contributor

    Dev-Lead Implementation Plan

    Issue: #329 β€” [Fleet Monitor] petry-projects/.github β€” ci.yml

    Triage Summary

    Pulled the last ~50 ci.yml runs and categorized failures:

    • PR-branch failures (vast majority) β€” Lint Markdown (MD051 broken link
      fragments) or Lint YAML (empty-lines trailing blank) errors in PR content.
      The CI workflow is correctly catching real lint issues; not workflow bugs.
    • 3 push-to-main failures (2026-06-08) β€” dependabot-rebase-reusable.yml:185
      trailing blank line. Already fixed in main (file is now 184 lines, terminates
      cleanly). No new remediation needed.
    • No infra-flake pattern observed β€” no checkout timeouts, action download
      failures, or transient errors. Local re-run of every lint suite on main
      passes cleanly (yamllint, markdownlint-cli2, actionlint, shellcheck).

    Root Cause of Inflated Failure Rate

    The Lint job runs three sub-steps sequentially (markdown β†’ yaml β†’ actions).
    When the first step fails, the remaining two are short-circuited. PR authors
    fix one issue, push, get the next failure, push, get the next β€” every
    intermediate push counts as a fresh failed CI run in the Fleet Monitor window.

    Scope

    Apply if: always() to the Lint YAML and Lint GitHub Actions steps so all
    three lint sub-checks run on every CI invocation. PR authors see every lint
    issue in one report and can fix them in a single push, reducing the
    fix→push→fail loop that inflates the workflow's failure rate. The Lint job
    name is preserved so the existing branch-protection required check is
    unaffected.

    Implementation Checklist

    • .github/workflows/ci.yml β€” add if: always() to the Lint YAML step
    • .github/workflows/ci.yml β€” add if: always() to the Lint GitHub Actions step

    Tests to Write

    • TDD exception applies β€” this is a behavior-preserving CI-configuration
      change. The gate semantics are identical (job still fails if any sub-step
      fails); only the diagnostic completeness improves. Validation is by local
      execution of every lint suite plus .dev-lead/scripts/dev-lead-lint.sh.

    Test Command

    yamllint, npx markdownlint-cli2 '**/*.md', actionlint, shellcheck, and
    bash .dev-lead/scripts/dev-lead-lint.sh

  3. don-petry commented on Jun 9, 2026

    @don-petry
    Contributor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Triaged the last ~50 ci.yml runs and root-caused the failures
    • .github/workflows/ci.yml β€” added if: always() to Lint YAML
    • .github/workflows/ci.yml β€” added if: always() to Lint GitHub Actions
    • Verified locally with yamllint, markdownlint-cli2, actionlint, shellcheck, and .dev-lead/scripts/dev-lead-lint.sh

    Triage Findings

    Cohort Count (sample of recent failed runs) Root cause
    PR-branch Lint Markdown failures ~20 Real MD051 broken-link-fragment issues in PR content
    PR-branch Lint YAML failures ~10 Real empty-lines trailing-blank issues in PR content
    main push failures (2026-06-08) 3 Same dependabot-rebase-reusable.yml:185 trailing blank β€” already fixed in main
    Infra flakes 0 None observed

    The workflow itself is correctly detecting real lint issues. The high failure
    rate is inflated because, when one of the three Lint sub-steps fails, the
    remaining two are skipped — so PR authors needed multiple fix→push cycles to
    discover every lint error, with each push counted as a fresh failed CI run.

    Test Results

    $ yamllint -c <(...) .github/workflows/ standards/workflows/ standards/dependabot/
    YAML: OK
    
    $ /tmp/actionlint -ignore 'SC2129' .github/workflows/*.yml
    actionlint: OK
    
    $ npx --yes markdownlint-cli2 '**/*.md'
    markdownlint-cli2 v0.22.1 (markdownlint v0.40.0)
    Finding: **/*.md !.claude/** !node_modules/**
    Linting: 40 file(s)
    Summary: 0 error(s)
    
    $ bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 12 file(s)...
      [lint] all checks passed
    

    Files Changed

    • .github/workflows/ci.yml β€” added if: always() to the second and third
      steps of the Lint job (Lint YAML, Lint GitHub Actions) plus an
      explanatory comment. The Lint job name is unchanged, so the existing
      Lint required status check in branch protection continues to work.

    Notes

    • TDD exception applied. This is a behavior-preserving CI-configuration
      change. The gate semantics are identical (the job still fails if any
      sub-step fails); only the diagnostic completeness improves.
    • Edge case acknowledged. If actions/checkout itself fails, if: always()
      would attempt to run the lint steps anyway, producing noisier output before
      failing. This is an unusual failure mode and the noisier signal is still
      obviously a checkout failure.
    • Follow-up to consider, not in scope here. The Fleet Monitor's
      metric does not de-duplicate consecutive failed runs on the same PR branch;
      iterative PR pushes inflate the rate. If that behavior is undesirable, the
      fix belongs in the Fleet Monitor itself, not ci.yml.
  4. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  5. don-petry commented on Jun 9, 2026

    @don-petry
    Contributor
    Already working on this: an open PR exists for issue #329.
  6. added a commit that references this issue on Jun 10, 2026
  7. added a commit that references this issue on Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions