Skip to content

dependency-audit-reusable: the required check is ecosystem discovery, not the scanners' outcome #1406

Closed

Description

@don-petry

The merge ruleset requires ecosystem discovery instead of the outcome of dependency scanning. Discovery can succeed while a downstream scanner reports vulnerable dependencies, leaving the documented dependency-security gate satisfied.

Location: .github/workflows/dependency-audit-reusable.yml:20
Severity: low · Rule: security_misconfiguration · Reachability: external
Subsystem: Event-driven automation and agents

The required dependency-security check selects ecosystem detection rather than the audit results. A dependency audit can fail while this required check remains successful, leaving the documented merge restriction unenforced.

The merge policy requires the ecosystem-detection job rather than a result that includes vulnerability audits. Detection can succeed while a downstream audit fails, leaving the dependency-audit merge prerequisite satisfied.

Evidence

  • Source/control: Dependency manifests and lockfiles supplied through pull requests or merge-group revisions.
  • Sink/decision: The required-status selection accepts dependency-audit / Detect ecosystems without requiring scanner outcomes.
  • Missing mitigation: No required final status waits for detection and every applicable scanner, then rejects failed or cancelled audits.

Assumptions
Based on these assumptions: A3 (Deployment configuration): The consuming repository runs the supplied audit workflow and code-quality ruleset without an additional required status that aggregates scanner results.
Findings that rely on assumptions are published at medium severity at most. If an assumption does not hold for your deployment, dismiss this finding.

Reachability call stack
  1. .github/workflows/dependency-audit.yml:25 — PR or merge-group event
  2. .github/workflows/dependency-audit.yml:37 — invoke reusable workflow
  3. .github/workflows/dependency-audit-reusable.yml:20 — detection publishes required success
  4. .github/workflows/dependency-audit-reusable.yml:89 — downstream scanner reports independent failure
  5. standards/rulesets/code-quality.json:30 — merge policy consumes detection alone [security decision]
  6. .github/workflows/dependency-audit.yml:25 — PR triggers dependency auditing
  7. .github/workflows/dependency-audit-reusable.yml:20 — required detection job reports ecosystem flags
  8. .github/workflows/dependency-audit-reusable.yml:73 — audit starts after detection
  9. .github/workflows/dependency-audit-reusable.yml:89 — advisory result fails only the audit job
  10. standards/rulesets/code-quality.json:30 — merge policy consumes the earlier detection result
  11. .github/workflows/dependency-audit.yml:26 — pull_request entrypoint
  12. .github/workflows/dependency-audit.yml:37 — invokes dependency-audit-reusable.yml
  13. .github/workflows/dependency-audit-reusable.yml:20 — detect reports the required status before audits
  14. .github/workflows/dependency-audit-reusable.yml:73 — audit-npm depends on detect and reports its result separately
  15. standards/rulesets/code-quality.json:30 — merge prerequisite selects only the detector status [security decision]

Filed from a CodeRabbit security scan (scan 2d23b5ee-606a-403f-b407-81ddebdb0115, revision 1ea9ee1fbecc). Finding IDs: 17a84ecc-16f0-45ea-978c-ba8035fbc476. CodeRabbit notes that findings relying on its stated assumptions are capped at medium severity; dismiss if an assumption does not hold.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressAn agent is actively working this issuesecuritySecurity-related PRs and issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions