Repository navigation
Description
The merge ruleset requires ecosystem discovery instead of the outcome of dependency scanning. Discovery can succeed while a downstream scanner reports vulnerable dependencies, leaving the documented dependency-security gate satisfied.
Location: .github/workflows/dependency-audit-reusable.yml:20
Severity: low · Rule: security_misconfiguration · Reachability: external
Subsystem: Event-driven automation and agents
The required dependency-security check selects ecosystem detection rather than the audit results. A dependency audit can fail while this required check remains successful, leaving the documented merge restriction unenforced.
The merge policy requires the ecosystem-detection job rather than a result that includes vulnerability audits. Detection can succeed while a downstream audit fails, leaving the dependency-audit merge prerequisite satisfied.
Evidence
- Source/control: Dependency manifests and lockfiles supplied through pull requests or merge-group revisions.
- Sink/decision: The required-status selection accepts dependency-audit / Detect ecosystems without requiring scanner outcomes.
- Missing mitigation: No required final status waits for detection and every applicable scanner, then rejects failed or cancelled audits.
Assumptions
Based on these assumptions: A3 (Deployment configuration): The consuming repository runs the supplied audit workflow and code-quality ruleset without an additional required status that aggregates scanner results.
Findings that rely on assumptions are published at medium severity at most. If an assumption does not hold for your deployment, dismiss this finding.
Reachability call stack
- .github/workflows/dependency-audit.yml:25 — PR or merge-group event
- .github/workflows/dependency-audit.yml:37 — invoke reusable workflow
- .github/workflows/dependency-audit-reusable.yml:20 — detection publishes required success
- .github/workflows/dependency-audit-reusable.yml:89 — downstream scanner reports independent failure
- standards/rulesets/code-quality.json:30 — merge policy consumes detection alone [security decision]
- .github/workflows/dependency-audit.yml:25 — PR triggers dependency auditing
- .github/workflows/dependency-audit-reusable.yml:20 — required detection job reports ecosystem flags
- .github/workflows/dependency-audit-reusable.yml:73 — audit starts after detection
- .github/workflows/dependency-audit-reusable.yml:89 — advisory result fails only the audit job
- standards/rulesets/code-quality.json:30 — merge policy consumes the earlier detection result
- .github/workflows/dependency-audit.yml:26 — pull_request entrypoint
- .github/workflows/dependency-audit.yml:37 — invokes dependency-audit-reusable.yml
- .github/workflows/dependency-audit-reusable.yml:20 — detect reports the required status before audits
- .github/workflows/dependency-audit-reusable.yml:73 — audit-npm depends on detect and reports its result separately
- standards/rulesets/code-quality.json:30 — merge prerequisite selects only the detector status [security decision]
Filed from a CodeRabbit security scan (scan 2d23b5ee-606a-403f-b407-81ddebdb0115, revision 1ea9ee1fbecc). Finding IDs: 17a84ecc-16f0-45ea-978c-ba8035fbc476. CodeRabbit notes that findings relying on its stated assumptions are capped at medium severity; dismiss if an assumption does not hold.
Activity
fix(security): harden dependency-audit Cargo/Python coverage and add …
fix(security): require dependency-audit / Audit gate instead of Detec…
docs: correct skipped-check and detection wording for the audit gate (#…
fix(security): require dependency-audit / Audit gate instead of Detec…