Skip to content

canary-rollout.sh rollback force-moves any destination tag, including immutable release tags, without checking it is a channel #1402

Closed

Description

@don-petry

Rollback accepts an arbitrary destination suffix and sends it to the privileged tag writer without confirming that it names a registered channel. A workflow dispatcher can therefore use the release-manager App to rewrite a version tag that the documented release policy requires to remain immutable.

Location: scripts/canary-rollout.sh:2528
Severity: medium · Rule: CWE-863 · Reachability: external
Subsystem: Organization administration and standards deployment

Evidence

  • Source/control: The workflow_dispatch ring input.
  • Sink/decision: Passing the unchecked destination tag to _gh_move_tag, which force-updates its reference using the configured write credential.
  • Missing mitigation: The privileged rollback operation does not distinguish mutable channel names from immutable release names before invoking the writer.
Reachability call stack
  1. .github/workflows/canary-rollout.yml:124 — dispatcher supplies ring
  2. .github/workflows/canary-rollout.yml:331 — construct rollback arguments
  3. .github/workflows/canary-rollout.yml:342 — invoke canary orchestrator
  4. scripts/canary-rollout.sh:4208 — dispatch to cmd_rollback
  5. scripts/canary-rollout.sh:2528 — pass unchecked destination to tag mover
  6. scripts/canary-rollout.sh:307 — force-update reference using App credential [sink]

Related: #1103 / #1117 (other cmd_rollback tag-targeting defect; separate root cause).


Filed from a CodeRabbit security scan (scan 2d23b5ee-606a-403f-b407-81ddebdb0115, revision 1ea9ee1fbecc). Finding IDs: 3888f0c9-506f-4f79-96ec-646d1b9ded23. CodeRabbit notes that findings relying on its stated assumptions are capped at medium severity; dismiss if an assumption does not hold.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressAn agent is actively working this issuesecuritySecurity-related PRs and issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions