Skip to content

dependabot-rebase-reusable merges with the bypass App after checks complete without requiring successful conclusions #1399

Closed

Description

@don-petry

The workflow directly merges with a bypass-capable App after checking conflict freedom and check completion, without checking successful conclusions. An eligible dependency update can therefore enter the protected default branch despite a failed required security or CI check.

Location: .github/workflows/dependabot-rebase-reusable.yml:178
Severity: medium · Rule: CWE-863 · Reachability: external
Subsystem: Event-driven automation and agents

Evidence

  • Source/control: Attacker-influenced upstream dependency or action content proposed in a genuine eligible Dependabot PR.
  • Sink/decision: App-authenticated PUT request to the pull-request merge endpoint.
  • Missing mitigation: The privileged merger never establishes that the effective required checks succeeded for the revision being merged.

Assumptions
Based on these assumptions: A3 (Deployment configuration): The reviewed callers run with the documented App credentials and supplied rulesets granting that App always-bypass authority over required checks.
Findings that rely on assumptions are published at medium severity at most. If an assumption does not hold for your deployment, dismiss this finding.

Reachability call stack
  1. standards/workflows/dependabot-rebase.yml:53 — invokes the reusable with App credentials.
  2. .github/workflows/dependabot-rebase-reusable.yml:75 — creates the App token.
  3. .github/workflows/dependabot-rebase-reusable.yml:87 — selects Dependabot PRs.
  4. .github/workflows/dependabot-rebase-reusable.yml:143 — requires an auto-merge request.
  5. .github/workflows/dependabot-rebase-reusable.yml:155 — checks conflict-only mergeability.
  6. .github/workflows/dependabot-rebase-reusable.yml:165 — ignores completed failures.
  7. .github/workflows/dependabot-rebase-reusable.yml:178 — merges with bypass authority.

Filed from a CodeRabbit security scan (scan 2d23b5ee-606a-403f-b407-81ddebdb0115, revision 1ea9ee1fbecc). Finding IDs: 64f4aafd-8d99-416f-826b-8c75f0594f01. CodeRabbit notes that findings relying on its stated assumptions are capped at medium severity; dismiss if an assumption does not hold.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressAn agent is actively working this issuesecuritySecurity-related PRs and issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions