Skip to content

dev-lead-retrigger.sh trusts the dev-lead/ branch prefix as proof of agent activity; fork PRs can suppress compliance retriggers #1391

Closed

Description

@don-petry

The activity check treats an attacker-selectable PR branch prefix as proof that the trusted dev-lead agent is working. A fork contributor can impersonate that activity and suppress automated compliance retriggers without permission to manage issue labels.

Location: scripts/lib/dev-lead-retrigger.sh:41
Severity: low · Rule: CWE-345 · Reachability: external
Subsystem: Organization administration and standards deployment

Evidence

  • Source/control: The head branch name of an open fork pull request returned by GitHub.
  • Sink/decision: The branch-only active decision, which causes the caller to consume the repository's engagement slot.
  • Missing mitigation: The check does not establish that the matching PR belongs to the trusted agent and originates from an authorized source repository.
Reachability call stack
  1. .github/workflows/compliance-retrigger.yml:5 — hourly schedule
  2. .github/workflows/compliance-retrigger.yml:43 — execute compliance-retrigger.sh
  3. scripts/compliance-retrigger.sh:361 — main calls retrigger_stale_issues
  4. scripts/compliance-retrigger.sh:219 — check activity for the selected stale issue
  5. scripts/lib/dev-lead-retrigger.sh:39 — retrieve open pull requests, including attacker fork metadata
  6. scripts/lib/dev-lead-retrigger.sh:41 — trust the matching head branch name [security decision]
  7. scripts/lib/dev-lead-retrigger.sh:47 — return active
  8. scripts/compliance-retrigger.sh:221 — consume the repository slot and skip retriggering [sink]
  9. scripts/compliance-retrigger.sh:285 — defer remaining legacy issues under the shared slot

Filed from a CodeRabbit security scan (scan 2d23b5ee-606a-403f-b407-81ddebdb0115, revision 1ea9ee1fbecc). Finding IDs: c5eaaa5e-0eb9-4cb5-a272-a666980b4b7c. CodeRabbit notes that findings relying on its stated assumptions are capped at medium severity; dismiss if an assumption does not hold.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressAn agent is actively working this issuesecuritySecurity-related PRs and issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions