Repository navigation
Closed
Description
Summary
The ADR-0007 ingress attribution shipped in #1238 fails closed almost everywhere. These four items are the places where unreadable or unattributable evidence can still read as healthy (or as "no caller"). They are the highest-priority follow-ups from the #1238 review (tracked in #1244).
Design principle (from the maintainer): expected outcomes must not be failures. A quiet ingress, or a repo that legitimately does not run a role, is "no caller" and must not hold the gate. Only unreadable evidence or a genuine misconfiguration should.
Items
- Item 3 —
_run_decision_classswallows jobs-read failures. It does_run_jobs_json … || echo '{}', so a sustained jobs outage returns an empty class, which_sample_decision_countssilently skips. Mix-shift sampling degrades to "insufficient" and is never recorded as UNRESOLVED, while the same condition elsewhere is. A failed read is also cached in_RUN_DECISION_CACHE. Fix: return a distinct non-zero status for a read error (vs "no decision step"), surface it through_sample_decision_counts, and map it to UNRESOLVED / a hold in_correctness_verdict. Do not cache the failure. Confirmed still open on main. - Item 11 — the ingress run list can silently truncate. The list is fetched with
-L ${CANARY_INGRESS_RUN_LIMIT:-5000}; the jobs cap fails closed when hit but the list cap does not, so a very busy ingress could look quieter than it is. Fix: detect a list that returned exactly its limit and treat it like the jobs cap (UNRESOLVED, or the truncation-aware baseline). - Item 12 — a job-less cancelled run is dropped as benign.
{skipped:"cancelled"}is decided before the UNATTRIBUTED branch, so a run whose jobs are merely not recorded yet (jobs API lag) is discarded instead of flagged. Fix: distinguish "cancelled before any job started" from "jobs not recorded yet" (e.g. require the run to be older than a settle window, or to report a cancelled conclusion with zero jobs on a re-read). - Item 10 — an empty ingress window never validates
ingress_job. With the per-role workflow absent, the ingress present and no completed run in the window,_ingress_agent_runsreturns[]without checking that the role exists, so a misspelledingress_joblooks like "no caller" andwaive_sample_if_no_callercan allow a dwell-only promotion. Mitigated today: as soon as any run appears without the role's job it is flagged NOROLE/UNRESOLVED. Approach is a maintainer decision (see below).
Item 10 — options (keeping expected outcomes from failing)
A runtime check cannot fail on "role absent from this member's ingress", because that is also what a legitimate non-consumer looks like. So:
- Static registry lint (recommended). Validate every registered
ingress_jobagainst the canonicalagent-ingress.ymltemplate in CI. Runtime keeps treating an empty window as "no caller" (expected, not a failure); a typo in the registry is caught before it ships. Dependency:standards/workflows/agent-ingress.ymldoes not exist in this repo yet ([Phase 3] Collapse the first repo's Class-1 event-driven stubs into agent-ingress.yml and rename the required checks .github-private#1729 AC11(a) is to publish it). The registry'singress.filecurrently points at the path inside each member repo. - Warn-only at runtime. Emit a
::warning::for "ingress present, zero runs, role never seen" with no effect on the gate. Cheap, but does not close the fail-open. - Runtime read of the live ingress file. Rejected as the primary approach: extra read per tick, and it cannot tell a registry typo from a non-consumer unless it compares across members.
- Accept as is.
Acceptance criteria
- Each item is fixed, or closed as "does not reproduce" with a test.
- Items 3, 11, 12 land first (one PR); item 10 follows the maintainer's decision.
- Existing end-to-end tests (canary-rollout evaluates only the newest candidate — every new cut cancels a pending ring1→stable human confirmation, so dev-lead stable is frozen at 09-07 #1118, canary-rollout: tag resolution cannot tell an API error from an absent tag, so a total lookup outage reads as "fully rolled out" #1225, canary-rollout health gate goes blind on an ADR-0007 collapsed repo: it resolves runs by per-role workflow NAME, which the ingress replaces with jobs #1224, canary autocut: scope bump signals to watched-path commits, paginate the range, and persist failed promotions #1023, canary-rollout: move the pair/ring verdict (per-pair state, tag-gap hold) into the pure gate core #1242) pass unchanged; none is flipped to match code.
shellcheck --severity=warning -xclean.
Metadata
Metadata
Assignees
Labels
No labels
Activity
don-petry commentedon Oct 4, 2026
PR A is up: #1250 covers items 3, 11 and 12 here (and closes #1248, item 13).
CANARY_INGRESS_RUN_LIMITwithout reaching the window start is UNRESOLVED (baseline: newest days only).Generated by Claude Code
don-petry commentedon Oct 4, 2026
PR A is merged: #1250 (squashed into main at 03:20Z; pr-review approved
97f1dbd).CANARY_INGRESS_RUN_LIMITwithout reaching the window start is UNRESOLVED (baseline: newest days only); a non-array list is UNRESOLVED; the limit is normalized once.agent-ingress.yml, which depends on that template landing in this repo; interim option: a warn-only annotation).Leaving this issue open for item 10.
Generated by Claude Code
feat(standards): publish the canonical agent-ingress.yml and lint the…
don-petry commentedon Oct 10, 2026
Item 10 (static registry lint, the accepted approach) is implemented in #1276, pending review/merge:
standards/workflows/agent-ingress.ymlpublished as the canonical ADR-0007 ingress (one job per ring-registered role; the pilot's two defective pins corrected topr-review/v1-stableandci-failure-analyst/v1-stable). Published as a standard only, not deployed.ingress_jobmust be a job of that template, plus plain/unique job-key checks;canary-rollout-tests.ymlnow triggers on registry edits (it previously did not).Items 3, 11, 12 and 13 shipped earlier in #1250.
Generated by Claude Code
fix(canary): fail closed on a non-array run list; Zulu cut date; cano…
don-petry commentedon Oct 21, 2026
Closing after the 2026-10-21 backlog triage.
Why: All four items shipped.
Evidence: PRs #1250, #1276 merged
Reopen if this still reproduces on main.