Skip to content

[qa-lead reach 2/3] Add persona-mention.yml to DEPLOYABLE_WORKFLOWS — blocked on the v1-stable ring tag (#783) #1156

Closed

Description

@don-petry

Story

As the org,
I want the weekly standards sweep to carry the persona-mention caller stub to the fleet,
so that a persona can be summoned somewhere other than petry-projects/.github-private.

Phase 2 of combsmith/.github-private#1643. This is the same shape as #1128 (#1045 Step D for apply-repo-settings): the template already exists, the stub is simply not in the deployable list.

Measured state, 2026-09-21

.github/workflows/persona-mention.yml exists in .github-private only — not in .github, TalkTerm, markets, ContentTwin, bmad-bgreat-suite, repo-template, broodly or incubator. DEPLOYABLE_WORKFLOWS in scripts/deploy-standard-workflows.sh today is: pr-review-mention, dev-lead, agent-shield, auto-rebase, dependabot-automerge, dependabot-rebase, dependency-audit, add-to-project, initiative-driver, pr-auto-review, feature-ideation. persona-mention.yml is absent, so no sweep can ever carry it.

standards/workflows/persona-mention.yml already exists, so nothing needs authoring — only listing.

BLOCKED BY #783 — do not start until persona-mention/v1-stable exists

Matching refs today: v1-next (fde249e0), v1-ring0 (a781ad9d), v1-ring1 (366ab877). There is no v1-stable.

A stable-tier repo (the * ring, i.e. most of the fleet) computes @persona-mention/v1-stable, and #1088's assert-exists check refuses a pin whose tag does not exist. Listing this stub before the ring soak completes therefore breaks the sweep for every stable-tier repo. #1128 records this precondition verbatim for the sibling agent; the same rule applies here.

Acceptance Criteria

  1. Re-verify the precondition in code, not just here: persona-mention/v1-stable exists and the ring soak ([promote persona-mention 1/3] Soak through the rings (next → ring0 → ring1 → stable) #783) reached it without skipping a tier.
  2. Add persona-mention.yml to DEPLOYABLE_WORKFLOWS in scripts/deploy-standard-workflows.sh.
  3. A --dry-run of the sweep for --workflow persona-mention.yml shows every target repo getting a pin whose tag exists — stable-tier repos @persona-mention/v1-stable, ring members their v1-<tier>. Paste that output into the PR. If any computed pin does not exist, stop and report it.
  4. Do not touch the template's uses: / checkout_ref: lockstep lines.
  5. Tests: the list contains the entry, and ring-pin emission for persona-mention in a stable-tier repo resolves to v1-stable.
  6. shellcheck --severity=warning -x clean; tests registered in the existing bats job.

Dev Notes

References

Activity

  1. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Blocking analysis — the ring soak and this story are circular (2026-09-21)

    Verified against standards/canary-rings.json and the live repo contents.

    persona-mention ring membership vs. actual adoption:

    tier members carries .github/workflows/persona-mention.yml?
    next .github-private yes
    ring0 .github no
    ring1 TalkTerm, bmad-bgreat-suite no
    stable * no

    persona-mention/v1-ring0 was advanced to fde249e0 on 2026-09-21 (identical to v1-next, release v1.9.0). That soaked nothing — ring0's only member has no caller stub, so no run exercises the tier. The same is true of ring1.

    The circularity: a real ring soak needs the stub deployed at each tier → deployment is this story → this story is gated on v1-stable existing → per #783 stable is the last tier, granted only after ring0 and ring1 have soaked. Each waits on the other.

    Why the gate exists anyway: deploy-standard-workflows.sh (~line 528) calls ring_tag_exists and, on a miss, logs refusing to deploy a non-resolving pin, sets _OVERALL_FAILED=1 and continues. So listing this stub before v1-stable exists does not corrupt anything — ring0/ring1 repos deploy correctly and only stable-tier repos are refused — but the weekly sweep (standards-deploy.yml, Mondays 08:16 UTC) is marked failed every run until the stable tag is cut.

    Two workable orders (maintainer decision, recorded here rather than chosen unilaterally):

    (A) is the honest reading of #783. (B) is faster and accepts that the soak was already done at next in .github-private — where the router has run continuously, including the #1134 stop-marker behaviour merged 2026-09-20.

  2. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Decision — option (B), tags first, one-pass deploy (maintainer, 2026-09-21)

    Recorded so the sequencing is unambiguous for whoever implements this.

    v1-ring1 and v1-stable are cut in tier order (no tier skipped, per #783's rule), and this story then lands in one pass: the sweep deploys the fleet with correct per-tier pins and no weekly-sweep failures.

    What this decision explicitly accepts: the ring soak below next is nominal. ring0 (.github) and ring1 (TalkTerm, bmad-bgreat-suite) have no persona-mention.yml stub, so no run exercises those tiers before stable. The soak evidence that exists is from next in .github-private, where the router has run continuously — including the #1134 stop-marker behaviour merged 2026-09-20 and live on v1-next/v1-ring0 (fde249e0).

    Consequence worth stating plainly: once deployed, the fleet's first real exercise of this router is production. The mitigations are the router's own fail-closed design (an unreadable label set or a failed contract fetch refuses to route, rather than routing unchecked) and the fleet-wide <id>:hands-off opt-out labels provisioned in combsmith/.github-private#1644.

    AC #1 remains as written and is satisfiable: v1-stable will exist, and no tier will have been skipped in tag order. Do not interpret it as requiring soak telemetry from ring0/ring1 — there is none, by this decision.

    Implementation is unblocked once persona-mention/v1-stable resolves. Verify that with ring_tag_exists (or git ls-remote) before starting, exactly as AC #1 says — do not take this comment's word for it.

  3. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Precondition MET — unblocked 2026-09-21

    persona-mention/v1-stable now resolves. Verified via the refs API:

    tag sha
    persona-mention/v1-next fde249e0
    persona-mention/v1-ring0 fde249e0
    persona-mention/v1-ring1 fde249e0
    persona-mention/v1-stable fde249e0

    compare v1-stable...v1-next → identical. Tiers were advanced in order (ring0 → ring1 → stable), so AC #1's no-skip requirement holds. Per the maintainer decision recorded above, soak evidence comes from next (.github-private); there is none from ring0/ring1 and none is required.

    Re-verify this yourself with ring_tag_exists / git ls-remote before starting (AC #1 says in code, not from a comment) — then proceed with AC #2 onward. AC #3's dry-run must still show every computed pin resolving before any PR is opened.

  4. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #1156 — [qa-lead reach 2/3] Add persona-mention.yml to DEPLOYABLE_WORKFLOWS — blocked on the v1-stable ring tag (#783)

    Precondition re-verification (AC #1) — VERIFIED IN CODE ✅

    Contrary to the issue's 2026-09-21 snapshot ("there is no v1-stable"), the ring soak
    (#783) has since completed. Verified via the live code path the sweep uses:

    • git ls-remote --tags on petry-projects/.github shows persona-mention/v1-stable
      now exists, pointing at fde249e0 — the same commit as v1-next, v1-ring0,
      and v1-ring1. Every tier is aligned at one commit, so stable never got ahead of
      ring1 → the soak reached stable without skipping a tier.
    • Through ring-pins.sh: persona-mention is ring-managed, channel major = 1, a
      stable-tier repo computes @persona-mention/v1-stable, and ring_tag_exists on the
      host confirms it resolves. Ring members (v1-next/v1-ring0/v1-ring1) all resolve too.

    The #1088 assert-exists precondition is therefore satisfied; listing the stub is safe.

    Scope

    Make persona-mention.yml eligible for the weekly standards sweep by adding it to
    DEPLOYABLE_WORKFLOWS — the template and ring registry already exist; this is listing only.

    Implementation Checklist

    • scripts/deploy-standard-workflows.sh — add persona-mention.yml to DEPLOYABLE_WORKFLOWS
    • Do NOT touch the template's uses: pin (AC Add workflow, environment, and orchestration guidance #4); no checkout_ref: line exists in it
    • Confirm no reconcile_skip_repo_required_workflows gap (persona-mention is NOT a required workflow)

    Tests to Write

    Verification / AC #3 evidence

    • Live --dry-run --workflow persona-mention.yml against the org, output pasted into the PR,
      showing every target repo pinned to an existing tag (stable → v1-stable, ring members → v1-<tier>).

    Test Command

    bats test/scripts/deploy-standard-workflows/ test/scripts/lib/ring-pins.bats and bash .dev-lead/scripts/dev-lead-lint.sh

  5. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet; the automation posts the authoritative
    completion record (with PR number + head SHA) after the push. Treat the notes
    below as intent, not delivered results.

    Precondition (AC #1) — re-verified in code

    The 2026-09-21 snapshot said "there is no v1-stable". That is no longer true — #783
    completed. Verified via the sweep's own code path (ring-pins.sh) and git ls-remote:
    persona-mention/v1-stable exists at fde249e0, the same commit as v1-next,
    v1-ring0, and v1-ring1. All tiers aligned at one commit ⇒ stable never got ahead of
    ring1 ⇒ the soak reached stable without skipping a tier. ring_tag_exists on the host
    confirms the computed stable-tier pin resolves.

    Plan Execution (intended)

    AC #3 — live --dry-run --workflow persona-mention.yml (provisional evidence, no PRs opened)

    [deploy] DRY RUN — no PRs will be opened
    [deploy] Deploying 1 workflow(s) to 11 repo(s)
    [deploy] SKIP  .github/persona-mention.yml (exempt)                                  # host, self-hosts via ./ ref
    [deploy] SKIP  .github-private/.github/workflows/persona-mention.yml already compliant # next-tier consumer
    [deploy] DRY   repo-template/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   ContentTwin/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   markets/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   broodly/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   google-app-scripts/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   incubator/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] DRY   bmad-bgreat-suite/persona-mention.yml would pin @persona-mention/v1-ring1
    [deploy] DRY   TalkTerm/persona-mention.yml would pin @persona-mention/v1-ring1
    [deploy] DRY   broodminder-export/persona-mention.yml would pin @persona-mention/v1-stable
    [deploy] Done.
    

    Every computed pin resolves to an existing tag (stable-tier → v1-stable; ring1 members
    → v1-ring1). The run exited 0 with no assert-exists refusal — no fleet-breaking pin.

    Files touched (this workspace, not yet pushed)

    • scripts/deploy-standard-workflows.sh: one line — persona-mention.yml added to DEPLOYABLE_WORKFLOWS.
    • test/scripts/deploy-standard-workflows/persona-mention-deployable.bats: new test (3 cases).

    Notes

    • persona-mention is NOT in the audit's REQUIRED_WORKFLOWS, so no
      reconcile_skip_repo_required_workflows gap is introduced (adoption ≠ reach). Confirmed:
      the "shipped deploy config reconciles…" guard test still passes.
    • Local checks (provisional, not the pushed run): shellcheck --severity=warning -x clean;
      .dev-lead/scripts/dev-lead-lint.sh all checks passed; the Standards Deploy bats suite is green.
    • Before release, mind the org automation-PR cap (standards/pr-limits.json, 50 org-wide):
      this stub's sweep fans out one PR per stable/ring1 repo.
  6. don-petry commented on Sep 21, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete — PR #1159

    The implementation for issue #1156 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  7. added a commit that references this issue on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupenhancementFeature requests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions