Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
43a2c65
feat: implement issue #382 — Enhance dev-lead and pr-review engines f…
Jun 11, 2026
c4ac980
fix(reviews): address review comments [skip ci-relay]
donpetry-bot Jun 11, 2026
b4411e1
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 11, 2026
d26a55a
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 12, 2026
21ada6e
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 12, 2026
00799b9
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 12, 2026
18948c2
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 12, 2026
90cfee3
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 12, 2026
9cc9c8c
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
30ca79c
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
5936b4c
Merge branch 'main' into dev-lead/issue-382-20260611-2227
github-actions[bot] Jun 13, 2026
e072fda
Merge branch 'main' into dev-lead/issue-382-20260611-2227
github-actions[bot] Jun 13, 2026
49e3847
fix(reviews): address review comments [skip ci-relay]
donpetry-bot Jun 13, 2026
0771568
Merge branch 'main' into dev-lead/issue-382-20260611-2227
github-actions[bot] Jun 13, 2026
9b64919
Merge branch 'main' into dev-lead/issue-382-20260611-2227
github-actions[bot] Jun 13, 2026
0912e2d
Merge branch 'main' into dev-lead/issue-382-20260611-2227
github-actions[bot] Jun 13, 2026
b188d47
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
8342eda
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
6eb497c
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
cdac1e9
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 13, 2026
8fb4d3b
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
a9333e3
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
d8373b0
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
62fb625
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
5d58213
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
8aeef09
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
88f9338
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
bacf70b
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
fd83f2b
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
ac4c56c
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
cf556e3
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
8ff1333
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
9a15670
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
665654e
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
cb003bd
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
e7ea1d0
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
c393f13
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
f3ba0a2
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 14, 2026
b1ab601
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
55d9f49
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
710c8d3
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
6cf5b28
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
3f6684f
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
64072f2
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
b647365
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
7fdb695
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
c1fd41d
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
1a441ec
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
d3a9c5f
Merge branch 'main' into dev-lead/issue-382-20260611-2227
don-petry Jun 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 177 additions & 20 deletions scripts/engine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,29 @@ set_engine_config() {
CLAUDE_SINGLE_MODEL_CHAIN="${CLAUDE_SINGLE_MODEL_CHAIN:-claude-fable-5,claude-opus-4-8,claude-opus-4-7}"
;;
gemini)
ENGINE_TRIAGE_MODEL="gemini-2.0-flash"
ENGINE_DEEP_MODEL="gemini-2.5-pro"
ENGINE_AUDIT_MODEL="gemini-2.5-pro"
ENGINE_ACTION_MODEL="gemini-2.5-pro"
ENGINE_SINGLE_MODEL="gemini-2.5-pro"
ENGINE_LABEL="triage: gemini-2.0-flash → deep: gemini-2.5-pro + duck: sonnet 4.6 → audit: gemini-2.5-pro"
ENGINE_SINGLE_LABEL="single-reviewer mode: gemini-2.5-pro"
# Per-engine model overrides via env (env → default).
# GEMINI_FLASH_MODEL controls the speed/cost tier (triage + action).
# GEMINI_PRO_MODEL controls the quality tier (deep + audit + single).
local _gflash="${GEMINI_FLASH_MODEL:-gemini-3.5-flash}"
local _gpro="${GEMINI_PRO_MODEL:-gemini-2.5-pro}"
ENGINE_TRIAGE_MODEL="$_gflash"
ENGINE_DEEP_MODEL="$_gpro"
ENGINE_AUDIT_MODEL="$_gpro"
ENGINE_ACTION_MODEL="$_gflash"
ENGINE_SINGLE_MODEL="$_gpro"
ENGINE_LABEL="triage: $_gflash → deep: $_gpro + duck: sonnet 4.6 → audit: $_gpro"
ENGINE_SINGLE_LABEL="single-reviewer mode: $_gpro"
# Cross-engine rubber duck: use Claude for diversity
DUCK_ENGINE="claude"
DUCK_MODEL="claude-sonnet-4-6"
# No in-engine chain for Gemini — only one production model in use today.
# In-Gemini model fallback chains (comma-separated, walked left-to-right on rate-limit).
# Flash chain: 3.5-flash (speed/cost) → 2.5-pro (quality fallback on exhaustion).
# Pro chain: 2.5-pro (quality) → 2.0-flash (graceful degradation on exhaustion).
# Override per workflow via env to tune cost/capability trade-offs.
GEMINI_FLASH_MODEL_CHAIN="${GEMINI_FLASH_MODEL_CHAIN:-${_gflash},gemini-2.5-pro}"
GEMINI_PRO_MODEL_CHAIN="${GEMINI_PRO_MODEL_CHAIN:-${_gpro},gemini-2.0-flash}"
# Clear the Claude-only chain vars so callers that check them unconditionally
# do not accidentally apply a stale Claude chain to the Gemini engine.
CLAUDE_TRIAGE_MODEL_CHAIN=""
CLAUDE_DEEP_MODEL_CHAIN=""
CLAUDE_AUDIT_MODEL_CHAIN=""
Expand All @@ -134,11 +146,11 @@ set_engine_config() {
# not a typo for o1-mini or gpt-4o-mini.
COPILOT_API_MODEL="${COPILOT_API_MODEL:-openai/o4-mini}"
export COPILOT_API_MODEL
ENGINE_LABEL="triage: o4-mini → deep: o4-mini + duck: gemini-2.0-flash → audit: o4-mini (GitHub Models API)"
ENGINE_LABEL="triage: o4-mini → deep: o4-mini + duck: gemini-3.5-flash → audit: o4-mini (GitHub Models API)"
ENGINE_SINGLE_LABEL="single-reviewer mode: o4-mini (GitHub Models API)"
# Cross-engine rubber duck: use Gemini when Copilot is primary
DUCK_ENGINE="gemini"
DUCK_MODEL="gemini-2.0-flash"
DUCK_MODEL="gemini-3.5-flash"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
# No in-engine chain for Copilot — single GitHub Models endpoint.
CLAUDE_TRIAGE_MODEL_CHAIN=""
CLAUDE_DEEP_MODEL_CHAIN=""
Expand All @@ -159,6 +171,7 @@ set_engine_config() {
export CLAUDE_TRIAGE_MODEL_CHAIN CLAUDE_DEEP_MODEL_CHAIN
export CLAUDE_AUDIT_MODEL_CHAIN CLAUDE_ACTION_MODEL_CHAIN
export CLAUDE_SINGLE_MODEL_CHAIN
export GEMINI_FLASH_MODEL_CHAIN GEMINI_PRO_MODEL_CHAIN
}

# Initial config
Expand Down Expand Up @@ -468,6 +481,114 @@ _gemini_invoke() {
--output-format text < "$prompt_file"
}

# _gemini_chain_invoke <chain_csv> <prompt_file> <timeout_sec> [extra_args...]
# Walks a comma-separated list of Gemini models, invoking _gemini_invoke with
# each model in sequence. Semantics mirror _claude_chain_invoke:
# - First model that succeeds (exit 0) wins; its stdout is emitted, exit 0 returned.
# - Rate-limited models (is_rate_limited_files) are logged and skipped; next tried.
# - Non-rate-limit failures stop the chain immediately; exit code propagated.
# - If every model rate-limits, returns 2 and writes the parsed reset time.
# - Empty/whitespace-only chain → config error exit 1.
#
# Sets _GEMINI_CHAIN_MODEL_USED to the model that produced the final output.
# Note: when called inside a pipeline (e.g. `... | tee ...`), the variable is
# set in a subshell and will not propagate to the parent — same limitation as
# _CLAUDE_CHAIN_MODEL_USED in _claude_chain_invoke.
_gemini_chain_invoke() {
local chain_csv="$1" prompt_file="$2" timeout_sec="$3"
shift 3
local extra_args=("$@")

if [ -z "$chain_csv" ]; then
echo "::error::_gemini_chain_invoke called with empty chain" >&2
return 1
fi

local -a models
local saved_ifs="$IFS"
IFS=',' read -ra models <<< "$chain_csv"
IFS="$saved_ifs"
Comment thread
don-petry marked this conversation as resolved.
Resolved

local stdout_tmp="" stderr_tmp=""
local final_stdout="" final_stderr="" final_model="" final_rc=0
local rc=0 attempted=0 all_rl=1
local model

for model in "${models[@]}"; do
# Trim whitespace
model="${model#"${model%%[![:space:]]*}"}"
model="${model%"${model##*[![:space:]]}"}"
[ -z "$model" ] && continue

attempted=$((attempted + 1))
stdout_tmp="$(mktemp 2>/dev/null)" || stdout_tmp=""
stderr_tmp="$(mktemp 2>/dev/null)" || stderr_tmp=""
rc=0

if [ -n "$stdout_tmp" ] && [ -n "$stderr_tmp" ]; then
# stderr intentionally passed through from _gemini_invoke (rate-limit msgs live there).
_gemini_invoke "$prompt_file" "$timeout_sec" "$model" "${extra_args[@]}" \
> "$stdout_tmp" 2> "$stderr_tmp" || rc=$?
else
# mktemp failure — clean up partial allocations and fall through without capture.
[ -n "$stdout_tmp" ] && rm -f "$stdout_tmp"
[ -n "$stderr_tmp" ] && rm -f "$stderr_tmp"
[ -n "$final_stdout" ] && rm -f "$final_stdout"
[ -n "$final_stderr" ] && rm -f "$final_stderr"
_gemini_invoke "$prompt_file" "$timeout_sec" "$model" "${extra_args[@]}" || rc=$?
_GEMINI_CHAIN_MODEL_USED="$model"
export _GEMINI_CHAIN_MODEL_USED
return "$rc"
fi

# Keep only the latest attempt's buffers
[ -n "$final_stdout" ] && rm -f "$final_stdout"
[ -n "$final_stderr" ] && rm -f "$final_stderr"
final_stdout="$stdout_tmp"
final_stderr="$stderr_tmp"
final_model="$model"

if [ "$rc" -eq 0 ]; then
final_rc=0
all_rl=0
break
fi
if ! is_rate_limited_files "$stdout_tmp" "$stderr_tmp"; then
# Non-rate-limit failure — propagate immediately without trying next model.
final_rc="$rc"
all_rl=0
break
fi
# Rate-limited; log and try next model.
# Phrasing avoids tokens that match _rate_limit_pattern so downstream callers
# that scan stderr do not misclassify a successful chain fallback as a rate-limit.
echo "::warning::[gemini] model $model throttled (rc=$rc) — trying next in chain" >&2
done

if [ "$attempted" -eq 0 ]; then
echo "::error::_gemini_chain_invoke: chain '$chain_csv' had no valid model entries" >&2
return 1
fi

if [ "$all_rl" -eq 1 ]; then
parse_reset_time_files "$final_stdout" "$final_stderr"
final_rc=2
fi

if [ -n "$final_stdout" ]; then
cat "$final_stdout"
rm -f "$final_stdout"
fi
if [ -n "$final_stderr" ]; then
cat "$final_stderr" >&2
rm -f "$final_stderr"
fi

_GEMINI_CHAIN_MODEL_USED="$final_model"
export _GEMINI_CHAIN_MODEL_USED
return "$final_rc"
}

# _claude_chain_invoke <chain_csv> <prompt_file> <timeout_sec> [extra_args...]
# Walks a comma-separated list of Claude models, invoking `claude --print --model X`
# with the given extra arguments. The first model whose run does NOT trigger
Expand Down Expand Up @@ -731,11 +852,13 @@ run_triage() {
fi
;;
gemini)
local _triage_gemini_chain="${GEMINI_FLASH_MODEL_CHAIN:-$ENGINE_TRIAGE_MODEL}"
if [ -n "$_tok_tmp" ]; then
_gemini_invoke "$prompt_file" "$TRIAGE_TIMEOUT_SEC" "$ENGINE_TRIAGE_MODEL" \
--approval-mode auto_edit | tee "$_tok_tmp" || rc=${PIPESTATUS[0]}
_GEMINI_CHAIN_MODEL_USED=""
_gemini_chain_invoke "$_triage_gemini_chain" "$prompt_file" "$TRIAGE_TIMEOUT_SEC" \
--approval-mode auto_edit > >(tee "$_tok_tmp") || rc=$?
else
_gemini_invoke "$prompt_file" "$TRIAGE_TIMEOUT_SEC" "$ENGINE_TRIAGE_MODEL" \
_gemini_chain_invoke "$_triage_gemini_chain" "$prompt_file" "$TRIAGE_TIMEOUT_SEC" \
--approval-mode auto_edit || rc=$?
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
fi
;;
Expand All @@ -749,7 +872,14 @@ run_triage() {
;;
esac
if [ "$rc" -eq 0 ]; then
local _triage_used="${_CLAUDE_CHAIN_MODEL_USED:-$ENGINE_TRIAGE_MODEL}"
local _triage_used
if [ "$REVIEW_ENGINE" = "claude" ] && [ -n "${_CLAUDE_CHAIN_MODEL_USED:-}" ]; then
_triage_used="$_CLAUDE_CHAIN_MODEL_USED"
elif [ "$REVIEW_ENGINE" = "gemini" ] && [ -n "${_GEMINI_CHAIN_MODEL_USED:-}" ]; then
_triage_used="$_GEMINI_CHAIN_MODEL_USED"
else
_triage_used="$ENGINE_TRIAGE_MODEL"
fi
Comment thread
don-petry marked this conversation as resolved.
Resolved
_record_engine_tokens "triage" "$REVIEW_ENGINE" "$_triage_used" "$prompt_file" "$_tok_tmp"
[ -n "$_tok_tmp" ] && rm -f "$_tok_tmp"
return 0
Expand Down Expand Up @@ -832,11 +962,28 @@ run_agentic() {
fi
;;
gemini)
# Capability-aware chain selection: flash chain for speed tiers, pro chain
# for quality tiers. Honor explicit model pin when it differs from the tier default.
local _agentic_gemini_chain _gemini_tier_default=""
case "$tier" in
deep) _agentic_gemini_chain="${GEMINI_PRO_MODEL_CHAIN:-$model}"
_gemini_tier_default="${ENGINE_DEEP_MODEL:-}" ;;
audit) _agentic_gemini_chain="${GEMINI_PRO_MODEL_CHAIN:-$model}"
_gemini_tier_default="${ENGINE_AUDIT_MODEL:-}" ;;
single) _agentic_gemini_chain="${GEMINI_PRO_MODEL_CHAIN:-$model}"
_gemini_tier_default="${ENGINE_SINGLE_MODEL:-}" ;;
*) _agentic_gemini_chain="${GEMINI_FLASH_MODEL_CHAIN:-$model}"
_gemini_tier_default="${ENGINE_ACTION_MODEL:-}" ;;
esac
Comment thread
don-petry marked this conversation as resolved.
Resolved
if [ -n "$_gemini_tier_default" ] && [ "$model" != "$_gemini_tier_default" ]; then
_agentic_gemini_chain="$model"
fi
if [ -n "$_tok_tmp" ]; then
_gemini_invoke "$prompt_file" "$DEEP_TIMEOUT_SEC" "$model" \
--approval-mode auto_edit | tee "$_tok_tmp" || rc=${PIPESTATUS[0]}
_GEMINI_CHAIN_MODEL_USED=""
_gemini_chain_invoke "$_agentic_gemini_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \
--approval-mode auto_edit > >(tee "$_tok_tmp") || rc=$?
else
_gemini_invoke "$prompt_file" "$DEEP_TIMEOUT_SEC" "$model" \
_gemini_chain_invoke "$_agentic_gemini_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \
--approval-mode auto_edit || rc=$?
fi
;;
Expand All @@ -857,6 +1004,8 @@ run_agentic() {
local _agentic_used="$model"
if [ "$REVIEW_ENGINE" = "claude" ] && [ -n "${_CLAUDE_CHAIN_MODEL_USED:-}" ]; then
_agentic_used="$_CLAUDE_CHAIN_MODEL_USED"
elif [ "$REVIEW_ENGINE" = "gemini" ] && [ -n "${_GEMINI_CHAIN_MODEL_USED:-}" ]; then
_agentic_used="$_GEMINI_CHAIN_MODEL_USED"
fi
_record_engine_tokens "$tier" "$REVIEW_ENGINE" "$_agentic_used" "$prompt_file" "$_tok_tmp"
fi
Expand Down Expand Up @@ -1095,11 +1244,17 @@ run_writer() {
fi
;;
gemini)
# Flash chain for writer (action) tier; honor explicit model pin.
local _writer_gemini_chain="${GEMINI_FLASH_MODEL_CHAIN:-$model}"
if [ -n "${ENGINE_ACTION_MODEL:-}" ] && [ "$model" != "$ENGINE_ACTION_MODEL" ]; then
_writer_gemini_chain="$model"
fi
if [ -n "$_tmp" ]; then
_gemini_invoke "$prompt_file" "$ACTION_TIMEOUT_SEC" "$model" \
--approval-mode auto_edit 2>&1 | tee "$_tmp" || rc=${PIPESTATUS[0]}
_GEMINI_CHAIN_MODEL_USED=""
_gemini_chain_invoke "$_writer_gemini_chain" "$prompt_file" "$ACTION_TIMEOUT_SEC" \
--approval-mode auto_edit > >(tee "$_tmp") 2>&1 || rc=$?
else
_gemini_invoke "$prompt_file" "$ACTION_TIMEOUT_SEC" "$model" \
_gemini_chain_invoke "$_writer_gemini_chain" "$prompt_file" "$ACTION_TIMEOUT_SEC" \
--approval-mode auto_edit || rc=$?
fi
;;
Expand All @@ -1124,6 +1279,8 @@ run_writer() {
local _writer_used="$model"
if [ "$REVIEW_ENGINE" = "claude" ] && [ -n "${_CLAUDE_CHAIN_MODEL_USED:-}" ]; then
_writer_used="$_CLAUDE_CHAIN_MODEL_USED"
elif [ "$REVIEW_ENGINE" = "gemini" ] && [ -n "${_GEMINI_CHAIN_MODEL_USED:-}" ]; then
_writer_used="$_GEMINI_CHAIN_MODEL_USED"
fi
_record_engine_tokens "writer" "$REVIEW_ENGINE" "$_writer_used" "$prompt_file" "$_tmp"
fi
Expand Down
1 change: 1 addition & 0 deletions scripts/lib/model-pricing.tsv
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,6 @@ claude-haiku-3-5* 2024-01-01 0.80 0.08 1.00 4.00

# ── Cross-engine (VERIFY — provisional; cache_write placeholder = input) ───────
o4-mini* 2025-01-01 2.00 0.50 2.00 8.00
gemini-3.5-flash* 2026-06-11 0.30 0.03 0.30 1.20
*gemini*flash* 2025-01-01 0.50 0.05 0.50 2.00
*gemini*pro* 2025-01-01 2.00 0.20 2.00 8.00
2 changes: 1 addition & 1 deletion scripts/validate-engines.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ _gemini_billing_probe() {
-X POST \
-H "Content-Type: application/json" \
-H "X-Goog-Api-Key: ${GOOGLE_API_KEY}" \
"https://generativelanguage.googleapis.com/v1beta/models/gemini-2.0-flash:generateContent" \
"https://generativelanguage.googleapis.com/v1beta/models/gemini-3.5-flash:generateContent" \
-d '{"contents":[{"parts":[{"text":"Hi"}]}],"generationConfig":{"maxOutputTokens":1}}' \
-w '\n%{http_code}' 2>/dev/null
) || true
Expand Down
33 changes: 32 additions & 1 deletion tests/dev-lead/fixtures/engines/stub-gemini
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
#!/usr/bin/env bash
# Configurable via:
# STUB_ENGINE_RESPONSE, STUB_ENGINE_EXIT, STUB_ENGINE_DELAY
# STUB_ENGINE_EXIT_BY_MODEL — pipe-delimited list of "model=exit_code" pairs.
# If set and a pair matches --model, that exit
# code overrides STUB_ENGINE_EXIT.
# STUB_ENGINE_RESPONSE_BY_MODEL — pipe-delimited "model=response" pairs,
# same lookup as EXIT_BY_MODEL.
# STUB_ENGINE_RECORD_MODELS — if set to a writable path, every --model value
# seen is appended as a new line for inspection.
# STUB_GEMINI_USAGE — "prompt cached candidates" emitted under
# .stats.models.<model>.tokens when --output-format json
# is requested. Default "120 20 40".
Expand All @@ -19,9 +26,23 @@ while [[ $# -gt 0 ]]; do
*) shift ;;
esac
done

if [ -n "${STUB_ENGINE_RECORD_MODELS:-}" ]; then
printf '%s\n' "$model" >> "$STUB_ENGINE_RECORD_MODELS" 2>/dev/null || true
fi

sleep "${STUB_ENGINE_DELAY:-0}"

# Resolve response: per-model override → default.
response="${STUB_ENGINE_RESPONSE:-stub engine response}"
if [ -n "${STUB_ENGINE_RESPONSE_BY_MODEL:-}" ] && [ -n "$model" ]; then
IFS='|' read -ra _pairs <<< "$STUB_ENGINE_RESPONSE_BY_MODEL"
for _p in "${_pairs[@]}"; do
case "$_p" in
"$model="*) response="${_p#"$model="}"; break ;;
esac
done
fi

if [ "$output_format" = "json" ]; then
read -r _p _c _cand <<< "${STUB_GEMINI_USAGE:-120 20 40}"
Expand All @@ -43,4 +64,14 @@ else
printf '%s\n' "$response"
fi

exit "${STUB_ENGINE_EXIT:-0}"
# Resolve exit code: per-model override → default.
exit_code="${STUB_ENGINE_EXIT:-0}"
if [ -n "${STUB_ENGINE_EXIT_BY_MODEL:-}" ] && [ -n "$model" ]; then
IFS='|' read -ra _epairs <<< "$STUB_ENGINE_EXIT_BY_MODEL"
for _ep in "${_epairs[@]}"; do
case "$_ep" in
"$model="*) exit_code="${_ep#"$model="}"; break ;;
esac
done
fi
exit "$exit_code"
8 changes: 5 additions & 3 deletions tests/dev-lead/unit/test_engine_chain.bats
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,17 @@ _source_engine() {

# ── Gemini/Copilot unchanged: no chain applied ────────────────────────────────

@test "gemini: no in-engine chain; single-model behavior unchanged" {
@test "gemini: in-engine chain uses gemini model (not claude)" {
_source_engine "gemini"
export STUB_ENGINE_EXIT=0

run run_writer "$TEST_PROMPT"

[ "$status" -eq 0 ]
# No claude model recorded (we ran gemini)
[ ! -s "$MODEL_RECORD" ]
# A gemini model was invoked (stub-gemini now records to MODEL_RECORD)
grep -q "gemini" "$MODEL_RECORD"
# No claude model was invoked
! grep -q "claude" "$MODEL_RECORD"
}

# ── File-based rate-limit + reset-time helpers ─────────────────────────────
Expand Down
Loading
Loading