Repository navigation
fix(ci-status): filter own-checks by workflowName (consumer formats) (#536) - #539
Conversation
…rmats) (#536) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 43 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
Code Review
This pull request updates the CI status check logic in scripts/lib/ci-status.sh to filter out own-checks based on the workflowName property, and adds corresponding tests in tests/test_ci_status.bats. Feedback on the changes suggests narrowing down the regex pattern ^PR Review to prevent it from matching and incorrectly filtering out other external workflows that start with the same prefix.
| # (#536: a consumer old check "pr-review / review" had workflowName | ||
| # "PR Review Agent"). Falls back to name patterns when the rollup does | ||
| # not expose workflowName. | ||
| ($wf | test("^PR Review")) or |
There was a problem hiding this comment.
The prefix regex ^PR Review is too broad and will match any workflow name starting with those words, such as PR Reviewer, PR Review Gate, PR Review Lint, or PR Review CI. If a consumer has a workflow with such a name and it fails, it will be incorrectly filtered out as an "own-check", causing the agent to falsely treat the CI status as passing.
To prevent this, use a more precise regex that only matches the specific known cascade workflows (e.g., PR Review, PR Review Agent, PR Review Reusable, PR Review — Mention Trigger, PR Review Trigger).
| ($wf | test("^PR Review")) or | |
| ($wf | test("^PR Review( Agent| Reusable| — Mention Trigger| Trigger)?$")) or |
There was a problem hiding this comment.
Pull request overview
Updates CI gating logic to more reliably ignore the PR Review agent’s own check runs across varying consumer check-name formats, preventing stale “own-check” failures from causing clean PRs to be classified as ci-failing (issue #536 fan-out).
Changes:
- Extend
compute_ci_statusown-check detection to treat any check withworkflowNamestarting withPR Reviewas an own-check (with existing name-based fallbacks). - Add Bats helpers/tests covering the consumer legacy format (
pr-review / review+workflowName: PR Review Agent) and a regression guard ensuring external failures still surface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/lib/ci-status.sh |
Enhances own-check filtering by adding a workflowName-prefix match for PR Review cascade workflows, while preserving existing name-pattern fallbacks. |
tests/test_ci_status.bats |
Adds new rollup builders and regression tests to validate filtering behavior for legacy consumer check-name formats without swallowing external failing checks. |
|
…rmats) (#536) (#539) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rmats) (#536) (#539) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rmats) (#536) (#539) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rmats) (#536) (#539) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rmats) (#536) (#539) Ring-1 (markets) surfaced that a consumer's OLD pr-review check appears as 'pr-review / review' with workflowName 'PR Review Agent' — not matched by the job-name patterns, so a stale failed own-check classified the PR ci-failing and the agent skipped it. Add a robust primary signal: filter any check whose workflowName starts with 'PR Review' (the cascade workflows), regardless of job-name format. Falls back to the existing name patterns when workflowName is absent (e.g. in unit tests), so the external 'Build / review' guard still holds. +2 tests (consumer format filtered; external 'Backend CI' still fails the gate). Promote via pr-review/stable. Part of #536 · #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>



Ring-1 (markets) found that a consumer's old pr-review check is named
pr-review / reviewwithworkflowName: PR Review Agent— the job-name filter missed it, so a stale failed own-check made the agent skip clean consumer PRs asci-failing.Fix: filter any check whose
workflowNamestarts withPR Review(the cascade workflows) — robust to any job-name format. Falls back to name patterns when workflowName is absent (unit tests), preserving the externalBuild / reviewguard. +2 tests (37/37). Promote via pr-review/stable. Part of #536.