Repository navigation
fix(ci-status): filter nested 'review / review' own-check (#497/#469) - #531
Conversation
…ck (#497, #469) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR extends the CI status filtering logic to handle the nested job name form ChangesOwn-check filtering for nested job names
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the CI status computation script to recognize and filter out the nested 'review / review' job name, which is generated when the cascade is invoked via a trigger stub. This prevents a stale or failed self-hosted review check from blocking subsequent reviews. Additionally, corresponding BATS tests have been added to verify this behavior and ensure that genuine external failures are still correctly identified. There are no review comments, and I have no feedback to provide.
|
There was a problem hiding this comment.
Pull request overview
Updates the CI-status classifier used by the PR Review Agent so it correctly ignores the agent’s own nested check name (review / review) that appears when invoked via the trigger stub → reusable workflow chain, preventing stale/failed self-checks from causing false ci-failing gating and skipping the approval backlog.
Changes:
- Extend the “own-check” filter in
compute_ci_statusto matchreview / reviewexactly (avoids accidentally filtering external checks likeBuild / review). - Add regression tests covering
review / reviewfailure cases plus an external-failure guard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/lib/ci-status.sh |
Adds an exact-match filter for review / review in the own-check exclusion logic and documents why it must be exact. |
tests/test_ci_status.bats |
Adds 3 regression tests validating the new nested own-check filter while ensuring real external failures still gate. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
…ck (#497, #469) (#531) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ck (#497, #469) (#531) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ck (#497, #469) (#531) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ck (#497, #469) (#531) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ck (#497, #469) (#531) The #497 self-host flip routes pr-review via a trigger stub → reusable, so the agent's own check appears in the rollup as the nested 'review / review' rather than the bare 'review'. The #469 own-check filter only matched the bare name, so a stale/failed own check now classified clean PRs as ci-failing → the agent skipped them and never re-reviewed (it skipped the entire approval backlog). Match 'review / review' exactly (not a '/ review' suffix, which would wrongly filter a genuine external 'Build / review'). Adds 3 regression tests; the existing external-check guard still passes. Promote via pr-review/stable. Part of #497 · epic #495. Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>



Second-order fix from ring-0 validation. After the self-host flip, the agent's own check appears as the nested
review / review(stub → reusable), which the #469 own-check filter (barereviewonly) missed. A stale failed own-check therefore classified clean PRs asci-failing, so the agent skipped its entire approval backlog and never re-reviewed.Fix: match
review / reviewexactly (not a/ reviewsuffix — that would wrongly filter a real externalBuild / review). +3 regression tests; existing external-check guard still green (35/35 bats).After merge: cut
pr-review/v1.4.0, movestable, re-validate that the agent now reviews+approves the backlog. Part of #497 · epic #495.Summary by CodeRabbit
Bug Fixes
Tests