Skip to content

feat: implement issue #409 — petry-projects — workflow failures detected 2026-05-30 - #526

Merged
don-petry merged 4 commits into
mainfrom
dev-lead/issue-409-20260609-2123
Jun 10, 2026
Merged

don-petry merged 4 commits into
mainfrom
dev-lead/issue-409-20260609-2123

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #409

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 9, 2026 21:31
Copilot AI review requested due to automatic review settings June 9, 2026 21:31
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c3738500-f206-4ed2-9d90-7cb8cee4ee7c

📥 Commits

Reviewing files that changed from the base of the PR and between dec3c15 and 4120eb7.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead-reusable.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-409-20260609-2123

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable dev-lead workflow to avoid modifying the tracked .gitignore during runs, which can interfere with subsequent git operations (and lead to workflow failures).

Changes:

  • Replace the “append to .gitignore then revert” approach with a local-only ignore entry in .git/info/exclude for .dev-lead/.

@don-petry
don-petry disabled auto-merge June 9, 2026 21:35
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1 — Quality Gate passed comment (0 new issues, 0 security hotspots; no actionable findings)
```
The SonarQube comment is purely a passing status notification. The PR is clean, all checks are green, and there are no open threads to resolve.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:36
@don-petry
don-petry disabled auto-merge June 9, 2026 23:55
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 23:55
@don-petry
don-petry disabled auto-merge June 10, 2026 01:43
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 01:44
@don-petry
don-petry disabled auto-merge June 10, 2026 01:51
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 01:53

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 4120eb7080469d351805021d5c697ecdd95a128a
Review mode: triage-approved (single reviewer)

Summary

Single-file workflow refactor: .github/workflows/dev-lead-reusable.yml now writes .dev-lead/ to .git/info/exclude (local-only, never tracked) instead of mutating tracked .gitignore and reverting it. Behaviour-preserving — git exclusion is identical either way — but removes a fallible git checkout .gitignore || true revert step that could leave the working tree dirty on PR branches that themselves modify .gitignore. Net +3/-4 LOC.

Linked issue analysis

Closes #409. The issue surfaced two failure patterns: (1) bmad-bgreat-suite/claude.yml CRITICAL — out of scope here, tracked in bmad-bgreat-suite#184 with PR #287 open; (2) .github/dev-lead.yml WARNING caused by .gitignore mutation + revert racing with PR-branch .gitignore changes. This PR addresses pattern (2) directly with the correct fix (use git's local-only exclude file). Scope decision is appropriate.

Findings

No findings.

  • Mechanism is correct: .git/info/exclude is local-only and provides identical exclusion semantics to .gitignore for untracked paths.
  • mkdir -p .git/info is defensive but harmless — the directory is guaranteed to exist in a checkout, and -p is idempotent.
  • Removal of the revert step is safe because nothing tracked has been modified.
  • No security or secret-handling implications; the change is confined to local-only git metadata.

CI status

All checks green (Lint, ShellCheck, CodeQL [actions+python], SonarCloud, AgentShield, Secret scan, validate-agent-profiles, gh-aw-compile, bats, unit/unit-tests, validate-fixtures, prompt-coverage, concurrency-config, caller-permissions, toplevel-permissions, Agent Security Scan, Compile agentic workflows). Dependency-audit jobs SKIPPED (no relevant ecosystem files changed) — expected. review / review IN_PROGRESS (this review). mergeStateStatus: BLOCKED only because reviewDecision is REVIEW_REQUIRED, which this approval resolves.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry
don-petry merged commit 3d2d143 into main Jun 10, 2026
32 of 33 checks passed
@don-petry
don-petry deleted the dev-lead/issue-409-20260609-2123 branch June 10, 2026 01:57
don-petry added a commit that referenced this pull request Jun 12, 2026
…ted 2026-05-30 (#526)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 14, 2026
…ted 2026-05-30 (#526)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 18, 2026
…ted 2026-05-30 (#526)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…ted 2026-05-30 (#526)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…ted 2026-05-30 (#526)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

petry-projects — workflow failures detected 2026-05-30

3 participants