You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(feature-ideation): re-dispatch only for authors with write access - #2444
Updates the redispatch job of .github/workflows/feature-ideation.yml to the current template in combsmith/.github (#1447, #1452). Only that job and its trigger comment change. project_context, the schedule and the channel pin are untouched.
New Ideas are re-dispatched only when the author has admin or write permission on this repo.
The dispatch uses the job token with actions: write. The personal token is no longer referenced.
Verified live on combsmith/.github: a maintainer's Idea produced one enhancement comment, and an Idea from an account without write access started no run.
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.
Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
Dev-Lead — waiting on PR blockers (intent: review-changes)
PR:#2444
No changes were committed, but the PR still can't be marked done: required checks SonarCloud, agent-shield / AgentShield, dependency-audit / Detect ecosystems, duplicate-decl-gate are still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-11-03T13:44:36Z
@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required checks SonarCloud, agent-shield / AgentShield, dependency-audit / Detect ecosystems, duplicate-decl-gate are still pending. I'll re-check automatically.
Next attempt after: 2026-11-03T13:44:36Z
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
.github/workflows/feature-ideation.yml-138-138: 1
138-138: Minor · Potential issue · Low value
Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.
The permission lookup has no failure handling. If GitHub returns 404 for an author who is not a repository collaborator, gh api fails before the case can issue the intended skip notice.
The redispatch job fails instead of successfully skipping the Idea with a notice.
This can occur when: A non-collaborator opens an Idea with a valid GitHub username.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: cbf6118a-e6f8-4e59-af7a-48e4a2773984
Commits
Reviewing files that changed from the base of the PR and between 7fe26d3 and caeaa81.
Files selected for processing: 1
.github/workflows/feature-ideation.yml
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Acknowledged: CodeRabbit's summary has no actionable, outside-diff or nitpick findings, no retained concerns and no architecture-review findings. Merge risk is Minimal and all 4 pre-merge checks passed. The description-check note about a missing 'Interaction contract' section concerns the PR body, not code.
Addressed 0 threads: there were no open review threads, and `coderabbitai` has approved the PR.
**Issue comments:** I posted one `informational` disposition on each of the four bot comments. None of them contains a finding.
- **Codex summary:** the Codex review of `caeaa81` failed, with no findings.
- **Codex usage-limit notice:** nothing to act on.
- **CodeRabbit summary:** no actionable, outside-diff, nitpick or architecture findings. Merge risk is Minimal and all 4 pre-merge checks passed. Its only note is that the PR description lacks an "Interaction contract" section, which is the PR body rather than code.
- **SonarCloud:** quality gate passed.
I left the two `don-petry` comments (the `dev-lead-fix-reviews` status and the rate-limit ack) alone because they are our own automation.
**CI:** nothing failed, but the PR isn't fully green yet.
- The four `cancelled` checks are two `dev-lead / dispatch` runs and two `review / review` runs. I didn't change anything for them: a newer `dev-lead / dispatch` run is in progress, and I haven't confirmed that newer runs of the `review / review` checks exist or are passing.
- `bats` is still in progress, and `agents-paused-preflight`, `auto-rebase-retry-resilience`, `dismiss-stale-bot-reviews-permissions`, `reusable-pin-compliance` and `unit` are still queued.
- I made no code changes and no commits, and I didn't run the test suite.
Files changed: none.
The automated review cascade escalated this PR to a human reviewer at review cycle 0/3 (risk: HIGH, reviewed commit caeaa81f56d7a8725fb5d252621bbd90e82fbc16).
Why: the cascade could neither approve the PR nor auto-request fixes, so it requested human review via CODEOWNERS and set the needs-human-review label. A human should review the PR, or remove the needs-human-review label to re-engage the automated cascade.
Reviewer summary: Moves the feature-ideation redispatch job from a personal token to the job token (actions: write) and adds a check so only authors with write access trigger a re-dispatch. The code looks correct. It is rated HIGH because it changes the token and the authorization check on a job that anyone can trigger in this public repo, so a human needs to approve it.
This note is updated in place on re-escalation; it is not re-posted.
It is labeled needs-human-review (flagged for human review — this label is applied by automation as well as by people, so an item can become held without anyone noticing), so dev-lead will not pick it up while that label is present. This notice is posted once so the withhold is visible rather than looking like a stalled run.
To re-enable automated pickup: remove the needs-human-review label.
…th refactor to separate PR
The redispatch job permission changes and github.token auth switch belong in a dedicated PR for that specific auth refactor (complementary to #2444). This PR focuses on issue #2446 (quota handling in PR review health). Restore feature-ideation.yml to its pre-sync state.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
#2444 switched the redispatch job to GH_TOKEN: ${{ github.token }}. The job
token can start workflow_dispatch runs, and GH_PAT_WORKFLOWS is being retired
(#1326). The test still required secrets.GH_PAT_WORKFLOWS, so bats has failed
on main since #2444. It now asserts the redispatch job sets GH_TOKEN from
github.token and that the workflow no longer references GH_PAT_WORKFLOWS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ort (#2448)
* feat: implement issue #2446 — [Fleet Monitor] combsmith/.github-private — .github/workflows/daily-pr-review-health.yml
* fix(reviews): recognise 'reached your limit' refusals, trap temp-file cleanup, tighten stderr test
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* docs: add function docstrings for complexity thresholds
Add concise docstrings to fmt_dur, llm_quota_refused, and conclusion_icon
functions to satisfy docstring coverage requirements (80% threshold).
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix(bot): narrow quota refusal detection to match Claude-specific patterns
Replaced generic 'limit reached' and 'rate limit' patterns with specific
Claude quota wording. Now matches '[0-9]+-[a-z]+ limit reached' (e.g.
'5-hour limit reached') instead of any 'limit reached' phrase, and removed
the overly-broad 'rate[ -]?limit' pattern. Preserves detection of all
tested quota refusals while avoiding false positives on unrelated errors.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix: add docstrings to setup() and teardown() in pr_review_health.bats
Addresses CodeRabbit docstring coverage threshold requirement.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix(bot): move docstrings before function definitions to meet coverage requirement
Moved docstrings from inside functions to before their definitions for:
- fmt_dur() in scripts/pr_review_health.sh
- conclusion_icon() in scripts/pr_review_health.sh
- setup() in tests/pr_review_health.bats
- teardown() in tests/pr_review_health.bats
This fixes the docstring coverage check which requires docstrings to precede function definitions, bringing coverage from 60% to 100%.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix(bot): remove redundant cleanup and use overall variable in LLM prompt
- Remove duplicate file cleanup that was redundant with trap cleanup
- Add the pre-computed overall health status to the LLM prompt context
- Remove unnecessary shellcheck disable comment now that overall is used
Fixes SonarQube issues: unused variable and redundant code cleanup.
* fix(bot): revert feature-ideation.yml to synced template state
.github/workflows/feature-ideation.yml is SOURCE OF TRUTH from combsmith/.github/standards/workflows/feature-ideation.yml and is read-only per CLAUDE.md #2185. The permissions block and redispatch logic must not be modified in this repo; such changes belong in the central template.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix(bot): use [[ instead of [ for conditional tests in llm_quota_refused
SonarCloud flagged two instances of using [ for conditional tests in
scripts/pr_review_health.sh. The [[ construct is safer and more feature-rich
for bash conditional expressions, avoiding issues with word splitting and
pathname expansion.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
* fix(bot): remove out-of-scope feature-ideation.yml changes — defer auth refactor to separate PR
The redispatch job permission changes and github.token auth switch belong in a dedicated PR for that specific auth refactor (complementary to #2444). This PR focuses on issue #2446 (quota handling in PR review health). Restore feature-ideation.yml to its pre-sync state.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
redispatchjob of.github/workflows/feature-ideation.ymlto the current template in combsmith/.github (#1447, #1452). Only that job and its trigger comment change.project_context, the schedule and the channel pin are untouched.actions: write. The personal token is no longer referenced.Verified live on combsmith/.github: a maintainer's Idea produced one enhancement comment, and an Idea from an account without write access started no run.
🤖 Generated with Claude Code
Problem
See the linked issue.
Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
No test files were added or updated. Verification:
bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.