Repository navigation
refactor(persona): run gating, model and posting as separate jobs - #2442
Conversation
Split the persona runtime reusable into three jobs, each on its own runner: gate (resolve, pre-gate, identity, preflight), run (the model) and post (the only writer). post checks out the workflow SHA, receives the advisory as one validated artifact file, and holds the one posting PAT the manifest names. The caller now names the secrets it passes instead of inheriting them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
QA Lead — test-risk advisoryRisk tier: LOW. The new handoff helpers have thorough unit tests, including negative paths: oversized, symlinked, extra-entry, renamed and shell-injection inputs. Contract tests pin which job holds which credential, and that the token selection never falls through to the other PAT. If the cross-job wiring is wrong, the run fails visibly: nothing gets posted and the job goes red. What I'd shore up (highest leverage first):
Escalate? no Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture |



Summary
Splits the persona runtime reusable into three jobs, each on its own runner:
gaterunpostgithub.workflow_sha, with no persisted credentials.runhandspostone artifact file holding only the redacted advisory text, kept for one day.postchecks it before parsing it.persona-runner.ymlnames the secrets it passes instead of inheriting them.AGENTS.mdinventory are updated to match.This goes live on merge:
persona-runner.ymlcalls the reusable by local path.Tests
Run locally at this head:
actionlinton both persona workflows;shellcheck --severity=warning scripts/*.sh scripts/lib/persona-runner.sh; the repo'scheck-*andvalidate-caller-inputsscripts. All pass.tests/persona_runner.bats(68/68),tests/test_fleet_pause_coverage.bats(60/60),tests/test_fleet_paused_run.bats,tests/fleet_monitor_run.bats,tests/test_persona_pr_pregate.bats,tests/resolve_persona_identity.bats,tests/test_persona_authz_preflight.sh,tests/persona_reach_check.bats,tests/caller_stub_freeze.bats,tests/dev-lead/unit/test_engine_mcp.bats,tests/dev-lead/unit/test_engine_models.bats. All pass.🤖 Generated with Claude Code