Repository navigation
feat: implement issue #2013 — dev-lead fix-reviews: posts "Fixed" replies for changes that were never pushed, and edits tests to match its own code - #2019
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T14:14:09Z. |
There was a problem hiding this comment.
Code Review
This pull request implements ADR-0010, introducing mechanisms to verify pushed commits and retract unlanded claims for write-mode personas on shared branches, alongside a test-tamper guard to prevent unauthorized test rewrites. The feedback suggests improving the robustness of jq parsing in scripts/lib/claim-landing.sh by using literal string matching (contains and split/join) instead of regex functions (test and gsub), and safely handling potentially null fields. Additionally, it is recommended to assert specific non-zero exit codes in the unit tests to prevent false positives.
Dev-Lead — review-changes (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T14:19:55Z. |
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Review — fix requested (cycle 1/3)The automated review identified the following issues. Please address each one: Findings to fixAutomated review — NEEDS HUMAN REVIEWRisk: MEDIUM SummaryThis PR adds harness controls that verify a claim landed, retract claims that did not, and guard against test tampering. It tightens the security posture: retraction PATCHes only this bot's own comments and passes the body as argv, the retraction reason is sanitised to [a-z-], and the removed trailing try_enable_auto_merge used to re-enable auto-merge after a guard abort (cp_rc==3). CI_WEAKENING_DETECTED is a false positive (the skip strings are the guard's regex and quoted bats fixtures, and the existing-test edits only re-point claim SHAs and add assertions), but required checks are not finished (bats and unit are in progress, several validate-* jobs are queued) and the merge state is BLOCKED, so this escalates instead of approving. Downstream impactThis change is consumed by 8 downstream repo(s) that pin the affected reusable workflow / lib / prompt. Impacted consumers: Findings
Reviewed by the PR-review cascade (triage: haiku 4.5 [sonnet 5.5, sonnet 5] → deep: opus 5.5 [opus 4.8, sonnet 5.5] + duck: gemini-3.8-flash [sonnet 5.5] → audit: opus 5.5 [opus 4.8, opus 4.7]). Reply if you need a human review. Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Requires human review: Auto-approval blocked because this review re-detected 6 unresolved issues already reported by Cubic.
Re-trigger cubic
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
Resolved — the `needs-human-review` hold was lifted; dev-lead has picked this item up. Click to expand the prior hold notice.dev-lead is withholding action on this item. It is labeled To re-enable automated pickup: remove the |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T14:54:11Z. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T15:06:31Z. |
There was a problem hiding this comment.
All reported issues were addressed across 10 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T18:42:26Z. |
don-petry
left a comment
There was a problem hiding this comment.
Review against the corrected body of issue #2013 ("dev-lead fix-reviews: posts "Fixed" replies for changes that were never pushed, and edits tests to match its own code"). Criteria 1, 4 and 5 are met for fix-reviews and fix-bot-comment. Criteria 2 and 3 are not met; the inline comments say what is required. The issue body's "Remaining work on PR #2019" section has the same list.
Also: the PR description still quotes the old issue text ("From the issue: (observed on ...)"). Update it from the current issue body.
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-02T23:32:09Z. |
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
da692ef to
809b3d9
Compare
Dev-Lead — rebase (applied)Rebase completed and pushed. |
|
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-03T14:49:04Z. |
Automated review — escalated to humanThe automated review cascade escalated this PR to a human reviewer at review cycle 1/3 (risk: HIGH, reviewed commit Why: the cascade could neither approve the PR nor auto-request fixes, so it requested human review via CODEOWNERS and set the Reviewer summary: The new test-regression guard runs PR-tree test commands (npm test, make test, pytest, bats, or $DEV_LEAD_TEST_CMD) deterministically inside the dev-lead job. That job has GH_PAT_DON_PETRY (write+workflows) in its job-level GH_TOKEN, plus CLAUDE_CODE_OAUTH_TOKEN and GOOGLE_API_KEY*. The code comment says env -i keeps tokens away from the test process, but that is false: same-uid code can read ancestor environments via /proc//environ. The CI-weakening hard stop is a confirmed false positive (the matches are regex fixtures only), but the secret-isolation problem, the bats/unit checks still in progress, and the reusable-workflow impact on 8 pinned consumers block approval. This note is updated in place on re-escalation; it is not re-posted. |
|
dev-lead is withholding action on this item. It is labeled To re-enable automated pickup: remove the |



Problem
dev-lead
fix-reviews: posts "Fixed" replies for changes that were never pushed, and edits tests to match its own codeFrom #2013 (observed on combsmith/.github#1220, three incidents):
15a919ewas pushed with the existing suite red: it added a new test and broke an existing one without editing it. CodeRabbit then confirmed the reply as addressed, so a wrong fix cleared a review gate.13927fcrewrote an existing test to match the code, applying a bot's "update the older test so the suite can pass" literally.Fix (ADR-0011): verify what landed and retract claims that did not (
claim-landing.sh,addressed-claim-verify.sh); refuse an unjustified existing-test rewrite (test-tamper-guard.sh); refuse a push when a test that passed on the pre-pass head fails on the result (test-regression-guard.sh). Applies to fix-reviews, fix-bot-comment, review-changes and human-pr.Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
tests/dev-lead/unit/test_addressed_claim_verify.bats,tests/dev-lead/unit/test_claim_landing.batstests/dev-lead/unit/test_fix_reviews.bats,tests/dev-lead/unit/test_test_tamper_guard.bats,tests/dev-lead/unit/test_test_regression_guard.bats. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.
Closes #2013