Repository navigation
feat: implement issue #1805 — dev-lead PR bodies are just 'Closes #N' — triage escalates every dev-lead PR for missing 3+ of 5 required description sections - #1806
Conversation
… — triage escalates every dev-lead PR for missing 3+ of 5 required description sections
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
🤖 CodeAnt AI — Review Status
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodeAnt Nitpicks2 code suggestions1. With
|
There was a problem hiding this comment.
Code Review
This pull request introduces structured PR-body generation and backfilling for the dev-lead agent to prevent triage escalation due to missing description sections, updating the PR template, scripts, and adding unit tests. The review feedback highlights several key improvements: securing temporary file creation in dev-lead-fix-issue.sh using mktemp with error handling, making the HTML comment stripping regex in dev-lead-pr-body.sh non-greedy to prevent over-matching, and asserting specific non-zero exit codes in the BATS tests instead of using generic non-zero checks.
|
Running
Neither is touched by this PR. This PR's diff is confined to the dev-lead PR-body sections work ( This is the pre-existing #1448 known-red state, which is exactly why |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1806 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
Superseded by automated re-review at
|
Superseded by automated re-review at
|
|
No description provided. |
|
This branch touches none of those covered files (its diff is |
Dev-Lead — review-changes (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: MEDIUM
Reviewed commit: 7c32edb3bdcd33a261bbdfb36e1f3d7198e4e48e
Cascade: triage → deep (triage: haiku 4.5 [sonnet 5] → deep: opus 4.8 [sonnet 5] + duck: o4-mini → audit: fable 5)
Summary
Implements structured dev-lead PR bodies (#1805) via a pure, unit-tested lib plus an idempotent marker-keyed backfill; the generated body passes sc_description_missing with 0|. On deep inspection the three escalated advisory signals are non-blocking: a minor /tmp file leak only on a terminal gh-create failure, a by-design template-guidance gap (enforcement is the triage gate, not the template), and an explicitly-mitigated best-effort TOCTOU in the backfill. The only red check (template-drift) is the pre-existing known-red failure under #1448/#1486 documented in the workflow and covers no file this PR touches; all PR-relevant checks (shellcheck, bats, unit-tests, CodeQL, SonarCloud, actionlint, AgentShield) are green. No auth/secrets/migrations/injection and no safety hard-stops.
Findings
- minor: Under
set -euo pipefail, a failedgh pr createexits beforerm -f "$pr_body_file", leaking the PID-named temp body file in /tmp on the create-failure path. Low blast radius (one file per failed run on a terminal-abort path; OS reclaims /tmp), but atrap 'rm -f "$pr_body_file"' EXITafter mktemp would close it cleanly. - info: The template comment instructs contributors to keep the five required sections, but nothing in the template can force it. This is by design: the enforcing layer is the sc_description_missing triage gate that escalates PRs missing 3+ sections, plus the new backfill for existing PRs. Not a code defect.
- info: dlpb_backfill_pr_body re-reads the PR body immediately before
gh pr editand skips when it changed since the snapshot, shrinking the TOCTOU window; the author documents it cannot be fully closed and the whole backfill is best-effort (all gh failures swallowed). Acceptable for a cosmetic body append that preserves original content.
Reviewed by the PR-review cascade (triage: haiku 4.5 [sonnet 5] → deep: opus 4.8 [sonnet 5] + duck: o4-mini → audit: fable 5). Reply if you need a human review.
|



User description
Closes #1805
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Add complete PR descriptions for dev-lead changes and repair incomplete existing PRs
What Changed
Impact
✅ Fewer dev-lead PRs escalated for incomplete descriptions✅ Clearer test, risk, rollback, and monitoring guidance✅ Existing PR content preserved during one-time repairs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.