Repository navigation
feat: implement issue #1735 — Bot-acknowledged threads are permanently unresolvable after #1691 — harness must scan the whole thread, not comments(last:1) - #1752
Conversation
…y unresolvable after #1691 — harness must scan the whole thread, not comments(last:1)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
There was a problem hiding this comment.
Code Review
This pull request implements a full-thread scan to identify the latest addressed-marker reply instead of only checking the last comment, preventing threads from becoming permanently unresolvable when a bot acknowledgement lands after a marker. It introduces helper functions to find the latest marker index, classify post-marker bot comments, and verify that no unaddressed comments have landed since the marker, along with comprehensive unit tests. The review feedback recommends optimizing acv_latest_marker_index and acv_post_marker_clear by replacing loop-based jq subprocess spawning with single jq invocations and using here-strings to avoid unnecessary subshells.
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
1 similar comment
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-10T13:26:39Z. |
Superseded by automated re-review at
|
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-10T20:12:40Z. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Superseded by automated re-review at
|
|
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: MEDIUM
Reviewed commit: 93557907a0c0a30e168d57fa29ffa3744c2bf9de
Review mode: triage-approved (single reviewer)
Summary
All blocking gates from prior cycles are now clear. The implementation of #1735 was verified correct and complete in cycles 1–2 (full-thread marker scan via acv_latest_marker_index, narrow fail-closed bot-ack/finding classifiers, #1415 human-block preserved, #1692 claim gate composed, all five AC6 cases covered at unit and harness level); the diff to this PR's four files is byte-identical since then — only merges of main landed (none touching these files). The single prior blocker — the unresolved CodeAnt thread at scripts/lib/addressed-claim-verify.sh:251 — has been resolved: the owner ratified the dev-lead's refutation and all five review threads on the PR are now resolved. CI is fully green at the reviewed head. Approving.
Linked issue analysis
Closes #1735 (open). All seven acceptance criteria remain substantively addressed, re-verified against the current diff:
- AC1 —
comments(last:1)replaced byacv_latest_marker_index, a single-jq-pass full-thread scan for the latest marker reply from our account; foreign markers do not authorize. - AC2 —
acv_bot_comment_is_acknowledgementclassifies post-marker bot comments; the finding regex is checked FIRST so mixed ack+finding blocks; the codeant 'Customized review instruction saved' shape clears. - AC3 — any marker-less human comment after our marker blocks unconditionally via the shared
review_thread_is_agent_authoreddiscriminator — no second classifier (#1415 preserved). - AC4 — fail-closed throughout: empty/ambiguous bodies rc2, negated acknowledgements ('cannot acknowledge') guarded before the ack match, unknown author types rc2, unparseable JSON rc2.
- AC5 — the #1692 claim gate still runs on the marker body; both gates must pass.
- AC6 — all five mandated cases present as pure unit tests (22 new cases in test_addressed_claim_verify.bats) plus four end-to-end harness cases in test_fix_reviews.bats asserting actual mutation/no-mutation, with harness exit status captured.
- AC7 — ShellCheck and bats green.
Dev-notes constraints honoured: #1691 untouched (harness remains sole resolver), #1692 built upon rather than bypassed.
Findings
No blocking findings.
- Prior blocker resolved — the CodeAnt thread at
scripts/lib/addressed-claim-verify.sh:251(text-only agent-authorship discriminator) that forced escalation in cycles 1 and 2 is now resolved, along with all four other review threads (gemini jq-loop performance ×2, codeant negated-ack, codeant harness exit-status — each fixed in code and confirmed). The owner has thereby ratified the accepted CodeAnt custom instruction, which was the human action the prior reviews required. No new comments or threads have appeared since. - Commits since prior review (9690203..9355790) are a merge of main only (#1724 agent-ingress reference, lint.yml, seed-repo-template.sh); none touch this PR's four files.
- Secret scan: the run_secret_scanning MCP tool is not available in this run; the gitleaks CI check is green and the diff is shell + bats only — no secret-shaped content.
- Residual accepted risk, documented: a human comment quoting an automation marker verbatim classifies as agent-authored and does not block. This is the trade-off the ratified refutation defends and #1735 AC3 mandates; fail-closed defaults bound the exposure.
CI status
All checks green at 9355790: shellcheck, ShellCheck, bats, unit-tests, unit, CodeQL, Analyze (actions/python), SonarCloud, gitleaks (Secret scan), actionlint, agent-shield, CodeRabbit, holdout-guard, and all governance validators SUCCESS. Skipped jobs are ecosystem-specific audit lanes and dev-lead orchestration, not verification gates. No CI security warnings. PR is MERGEABLE.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.



User description
Closes #1735
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Prevent addressed review threads from remaining permanently unresolved when a bot acknowledges the response afterward
What Changed
Impact
✅ Fewer permanently stuck review threads✅ Bot acknowledgements no longer block resolution✅ New or unclear feedback keeps review threads open💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.