Skip to content

[Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent #873

Closed

Description

@github-actions

Story

As a release engineer for the org agent fleet,
I want have scripts/cut-release.sh recognize feature-ideation as a releasable agent with the next/ring0/ring1/stable channels, and document it in the versioning + runbook docs,
so that feature-ideation can be cut and promoted through the same canary/ring tag model as pr-review and dev-lead, so callers pin once to a channel and promotion/rollback is a single tag move.

Acceptance Criteria

  1. valid_agent in scripts/cut-release.sh accepts feature-ideation (alongside pr-review and dev-lead) and rejects unknown agents unchanged; its usage/error strings list feature-ideation.
  2. release_ref and channel_ref produce feature-ideation/vX.Y.Z and feature-ideation/<channel> correctly, and a --dry-run for feature-ideation prints the intended immutable + channel tag names without creating or pushing anything.
  3. tests/test_cut_release.bats adds cases asserting feature-ideation is accepted and that release_ref/channel_ref format its tags correctly; the full bats file passes.
  4. docs/release/versioning.md documents the feature-ideation agent: its channel set {next, ring0, ring1, stable}, and an explicit note that — unlike pr-review/dev-lead whose reusables live in this repo — feature-ideation's reusable lives in petry-projects/.github, so its release/channel tags are cut against that repo.
  5. docs/release/runbook.md extends the 'Agents covered' line and the cut/promote/rollback examples to include feature-ideation.
  6. shellcheck scripts/cut-release.sh passes with no new findings.

Tasks / Subtasks

Dev Notes

  • scripts/cut-release.sh structure: pure helpers (valid_agent, validate_version, release_ref, channel_ref) at top level (sourced by tests via a source-guard at the bottom), main() does the git tag/push. valid_agent currently matches pr-review | dev-lead only — add feature-ideation.
  • release_ref()/channel_ref() are name-agnostic (printf '%s/v%s' / printf '%s/%s'), so they already format feature-ideation tags once valid_agent allows the name.
  • CROSS-REPO WRINKLE: docs/release/versioning.md defines a 'release' as the reusable workflow PLUS the scripts it executes, moving together as one whole-repo commit — true for pr-review/dev-lead because those reusables live in THIS repo. feature-ideation's reusable lives in petry-projects/.github (see .github/workflows/feature-ideation.yml header: 'Reusable: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml'), so feature-ideation's release/channel tags must be cut against petry-projects/.github, not this repo's origin. main() currently hardcodes git push origin. Suggested approach: add an optional remote/repo target (e.g. a --repo/remote arg) so feature-ideation tags push to petry-projects/.github; keep origin the default for pr-review/dev-lead. Do NOT bake the unresolved target mechanism into an AC — the dry-run (no mutation) is the testable surface here; confirm the target approach via the open question before wiring live pushes.
  • AGENTS.md 'Release channel tags & the mutable-ref exception' scopes the protective ruleset to pr-review/**, dev-lead/**. feature-ideation's channel tags live on petry-projects/.github, so the ruleset bounding them is created there (untracked prerequisite). Add a sentence to this section noting feature-ideation channel pins are the same sanctioned exception and that their ruleset lives in the public repo.
  • Testing standard: bats unit tests source cut-release.sh (source-guard prevents main() from running) and exercise only the pure helpers — keep the new cases at that level (no git-backed flow in tests, matching the existing file's note).
  • Pattern precedent: this mirrors the pr-review/dev-lead rollout in epic Initiative: Safe Release Strategy for Agentic Workflows (versioning · rings · canary) #495 (docs/initiatives/agentic-release-strategy.md) and the ci-failure-analyst generalization (open epics [Phase 1] Generalize cut-release.sh + the release standard to cover non-agent reusables #686/[Phase 2] Cut ci-failure-analyst initial release + channel tags and extend the release-channel ruleset #688).

Project Structure Notes

All touched files are in this repo: scripts/cut-release.sh, tests/test_cut_release.bats, docs/release/{versioning,runbook}.md, AGENTS.md. No new files. The only structural novelty is acknowledging an agent whose reusable lives in a different repo — captured as a documented cross-repo note rather than a structural change here.

References

  • scripts/cut-release.sh#valid_agent
  • tests/test_cut_release.bats
  • docs/release/versioning.md#what-is-versioned
  • docs/release/runbook.md#agents-covered
  • AGENTS.md#release-channel-tags--the-mutable-ref-exception
  • .github/workflows/feature-ideation.yml (header: Reusable in petry-projects/.github)

Likely target surface

  • scripts/cut-release.sh
  • tests/test_cut_release.bats
  • docs/release/versioning.md
  • docs/release/runbook.md
  • AGENTS.md

Story prepared by the BMAD Scrum Master (Bob) for epic #872. Status: ready-for-dev.

Activity

  1. don-petry commented on Jun 21, 2026

    @don-petry
    Collaborator

    Dev-Lead Implementation Plan

    Issue: #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

    Scope

    Recognize feature-ideation as a releasable agent in scripts/cut-release.sh (next/ring0/ring1/stable channels via the existing name-agnostic helpers), make its dry-run print the intended immutable + channel tag names with no mutation (cross-repo live push left as a TODO), and document it in the versioning + runbook docs and the AGENTS.md mutable-ref exception.

    Implementation Checklist

    • scripts/cut-release.sh: add feature-ideation to the valid_agent case; update usage header + unknown-agent error string to list it. release_ref/channel_ref unchanged (already name-agnostic).
    • scripts/cut-release.sh: add a TODO noting feature-ideation's reusable lives in petry-projects/.github, so live channel pushes must target that repo (mechanism = open question; dry-run only for now).
    • docs/release/versioning.md: add feature-ideation to the "What is versioned" table, document its channel set {next, ring0, ring1, stable}, and add the explicit cross-repo note (reusable in petry-projects/.github).
    • docs/release/runbook.md: extend "Agents covered" and the cut/promote/rollback examples to include feature-ideation.
    • AGENTS.md: add a sentence to "Release channel tags & the mutable-ref exception" noting feature-ideation channel pins are the same sanctioned exception and that their ruleset lives in the public repo.

    Tests to Write

    • tests/test_cut_release.bats: valid_agent accepts feature-ideation.
    • tests/test_cut_release.bats: release_ref formats feature-ideation/vX.Y.Z.
    • tests/test_cut_release.bats: channel_ref formats feature-ideation/<channel> (e.g. ring0).

    Test Command

    bats tests/test_cut_release.bats (plus bash .dev-lead/scripts/dev-lead-lint.sh and shellcheck scripts/cut-release.sh)

  2. don-petry commented on Jun 21, 2026

    @don-petry
    Collaborator

    Dev-Lead: Implementation Complete

    Plan Execution

    • scripts/cut-release.sh: added feature-ideation to valid_agent; updated usage header + unknown-agent error string. release_ref/channel_ref unchanged (already name-agnostic — confirmed).
    • scripts/cut-release.sh: added TODO(#872) cross-repo note + a guard that refuses a non-dry-run cut for feature-ideation (so tags are never written to the wrong remote while the cross-repo push target is an open question). --dry-run prints the intended immutable + channel tags with no mutation.
    • tests/test_cut_release.bats: added valid_agent (feature-ideation accepted), release_ref (feature-ideation/v1.4.0), and channel_ref (feature-ideation/ring0) cases.
    • docs/release/versioning.md: added feature-ideation to the "What is versioned" table, documented the {next, ring0, ring1, stable} channel set, and added a dedicated "Cross-repo: feature-ideation" section + dry-run example.
    • docs/release/runbook.md: extended "Agents covered" and the cut/promote/rollback examples/notes for feature-ideation's cross-repo tags.
    • AGENTS.md: added a paragraph to "Release channel tags & the mutable-ref exception" noting feature-ideation pins are the same sanctioned exception and that their ruleset lives in petry-projects/.github.

    Test Results

    1..17
    ok 1 valid_agent: pr-review is accepted
    ok 2 valid_agent: dev-lead is accepted
    ok 3 valid_agent: feature-ideation is accepted
    ... (validate_version + ref helpers) ...
    ok 14 release_ref: feature-ideation variant
    ok 16 channel_ref: next channel
    ok 17 channel_ref: feature-ideation ring0 channel
    

    17/17 pass, 0 failures.

    bash .dev-lead/scripts/dev-lead-lint.sh → all checks passed (shellcheck on 72 files + agent-profile + CODEOWNERS validation).
    shellcheck scripts/cut-release.sh → clean, no new findings.

    Manual dry-run verification:

    $ scripts/cut-release.sh feature-ideation 1.4.0 --channel ring0 --dry-run
    release tag: feature-ideation/v1.4.0
    channel tag: feature-ideation/ring0 -> feature-ideation/v1.4.0
    (dry-run) no tags created or pushed.        # exit 0, no tags written
    $ scripts/cut-release.sh feature-ideation 1.4.0 --channel ring0 --push
    ::error::live cut/push for 'feature-ideation' is not wired yet ...   # exit 1, no tags written
    

    Files Changed

    • scripts/cut-release.sh: feature-ideation accepted by valid_agent; usage/error strings updated; cross-repo TODO(#872) + guard refusing live (non-dry-run) cuts.
    • tests/test_cut_release.bats: +3 feature-ideation cases (valid_agent, release_ref, channel_ref).
    • docs/release/versioning.md: table row, channel-set note, "Cross-repo: feature-ideation" section, dry-run example.
    • docs/release/runbook.md: "Agents covered" + cut/promote/rollback cross-repo notes/examples.
    • AGENTS.md: feature-ideation paragraph in the mutable-ref exception section.

    Notes

    • Scope decision: per the story's dev notes, the live cross-repo push mechanism (push target against petry-projects/.github) is an open question reserved for a human decision and was deliberately not wired. Beyond the documented TODO, I added a guard that refuses a non-dry-run feature-ideation cut so the script can never write tags to this repo's origin by mistake; --dry-run (the testable surface in AC Go-live improvements for PR review agent #2) is fully supported.
    • Untracked prerequisite (not in this repo): the release-channel-tags ruleset bounding feature-ideation/** must be created on petry-projects/.github — documented in AGENTS.md and versioning.md, no action possible here.
    • No new test files added, so no lint.yml bats-list change is needed.
  3. added a commit that references this issue on Jun 21, 2026
  4. added 14 commits that reference this issue on Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupinitiativeEpic / initiative tracking issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions