Skip to content

Stale-base / test-deletion merge guards (#655 prevention) #823

Closed

Description

@don-petry

Story

As a maintainer,
I want protect .github-private against the stale-base semantic-revert class and against silent test deletions,
so that a fleet-critical fix cannot be silently reverted by a PR branched off an old base that also deletes its regression test.

Acceptance Criteria

  1. 'Require branches to be up to date before merge' (or a merge queue) is enabled on .github-private main; the decision is recorded against bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618); idea:approved stopped planning #655 item 1.
  2. A CI signal flags PRs that net-delete files under tests/ for explicit human acknowledgement (bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618); idea:approved stopped planning #655 item 2).
  3. Both are documented in AGENTS.md / standards/ci-standards.md.

Tasks / Subtasks

Dev Notes

Project Structure Notes

Branch-protection config + a CI workflow + docs. Independent of the planner code path.

References

Likely target surface

  • .github/workflows/
  • AGENTS.md

Story prepared by the BMAD Scrum Master (Bob) for epic #817. Status: ready-for-dev.

Activity

  1. added
    initiativeEpic / initiative tracking issue
    initiative:holdInitiative driver must not release this issue (human hold)
    dev-lead:hands-offExclude from dev-lead agent automation
    on Jun 20, 2026
  2. don-petry commented on Jun 20, 2026

    @don-petry
    CollaboratorAuthor

    Decision (S6 / #655 item 1): "require branches up to date before merging" is sufficient — merge queue is under investigation but NOT implemented here.

    Remaining in this story:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-lead:hands-offExclude from dev-lead agent automationinitiativeEpic / initiative tracking issueinitiative:holdInitiative driver must not release this issue (human hold)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions