Repository navigation
Closed
Labels
dev-lead:hands-offExclude from dev-lead agent automationExclude from dev-lead agent automationinitiativeEpic / initiative tracking issueEpic / initiative tracking issueinitiative:holdInitiative driver must not release this issue (human hold)Initiative driver must not release this issue (human hold)
Description
Story
As a maintainer,
I want protect .github-private against the stale-base semantic-revert class and against silent test deletions,
so that a fleet-critical fix cannot be silently reverted by a PR branched off an old base that also deletes its regression test.
Acceptance Criteria
- 'Require branches to be up to date before merge' (or a merge queue) is enabled on .github-private main; the decision is recorded against bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);
idea:approvedstopped planning #655 item 1. - A CI signal flags PRs that net-delete files under tests/ for explicit human acknowledgement (bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);
idea:approvedstopped planning #655 item 2). - Both are documented in AGENTS.md / standards/ci-standards.md.
Tasks / Subtasks
- Enable required-up-to-date-branch or a merge queue on .github-private main and record the decision. (AC: test issue from agent #1)
- Add a CI check that flags net test deletions for human ack. (AC: Go-live improvements for PR review agent #2)
- Document the guards. (AC: Add @claude delegation, auto-merge, and rebase handling #3)
Dev Notes
- Satisfies the still-open acceptance items tracked on bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);
idea:approvedstopped planning #655 (merge-queue decision + test-deletion guard). - hands_off: enabling branch protection / a merge queue is an org-admin action; the CI-signal portion is codeable but the dominant action needs a human, so this story is gated.
- Highest-leverage guard for the exact bug that broke idea:approved in production (bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);
idea:approvedstopped planning #655): feat: implement issue #574 — pr-review: PRs with >300 changed files hard-fail the cascade (gh pr diff 406); define org standard for oversized PRs #606 merged from a stale base and reverted feat: implement issue #591 — bug(initiative-planner): claude-code-action rejectsdiscussionevents — theidea:approvedauto-trigger never plans #618 with a green CI because it deleted the regression test in the same diff.
Project Structure Notes
Branch-protection config + a CI workflow + docs. Independent of the planner code path.
References
Likely target surface
.github/workflows/AGENTS.md
Story prepared by the BMAD Scrum Master (Bob) for epic #817. Status: ready-for-dev.
Metadata
Metadata
Assignees
Labels
dev-lead:hands-offExclude from dev-lead agent automationExclude from dev-lead agent automationinitiativeEpic / initiative tracking issueEpic / initiative tracking issueinitiative:holdInitiative driver must not release this issue (human hold)Initiative driver must not release this issue (human hold)
Activity
don-petry commentedon Jun 20, 2026
Decision (S6 / #655 item 1): "require branches up to date before merging" is sufficient — merge queue is under investigation but NOT implemented here.
petry-projects/.github-privatemain enforcesstrict_required_status_checks_policy: true(verified) — i.e. branches must be up to date before merge. This is the highest-leverage guard against the bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);idea:approvedstopped planning #655 stale-base semantic-revert class (PR [Phase 2] Add next + per-ring channel tags (blue/green green channel) #499 exercised it: it wentBEHINDand requiredupdate-branchbefore merge). Merge queue is being evaluated separately and is explicitly out of scope here.Remaining in this story:
tests/for explicit human acknowledgement (bug: stale-base merge (#606) silently reverted the initiative-planner discussion→dispatch fix (#618);idea:approvedstopped planning #655 item 2).AGENTS.md/standards/ci-standards.md.feat: S6 stale-base guards — test-deletion CI signal + fleet pipeline…